'Review Request 120766: Remove no longer used widget classes KoUniColorDialog & KoOpacityConfigWidget'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Review Request 120766: Remove no longer used widget classes KoUniColorDialog & KoOpacityConfigWidget
From:       "Friedrich W. H. Kossebau" <kossebau () kde ! org>
Date:       2014-10-23 21:05:10
Message-ID: 20141023210510.18179.83 () probe ! kde ! org
[Download RAW message or body]

--===============7623280497827603568==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120766/
-----------------------------------------------------------

Review request for Calligra, Camilla Boemann and Boudewijn Rempt.

Repository: calligra

Description
-------

While checking the includes for classes from libkowidgets I found those two classes \
are no longer used by any code, so I propose to remove them as dead code.

Last usage of KoUniColorDialog was removed in \
53356cb20f1100edf716beba8c407953b3c692ec (by rempt) Last usage of \
KoOpacityConfigWidget was removed in 76242efb3bd5a116f034ef785c0a2e9e3608fc64 (by \
boemann)

Diffs
-----

  libs/widgets/CMakeLists.txt 324b762 
  libs/widgets/KoOpacityConfigWidget.h 6fc81ef 
  libs/widgets/KoOpacityConfigWidget.cpp 48d6395 
  libs/widgets/KoUniColorDialog.h 4cce042 
  libs/widgets/KoUniColorDialog.cpp 935b644 
  plugins/defaultTools/defaulttool/DefaultTool.cpp f26d4bf 

Diff: https://git.reviewboard.kde.org/r/120766/diff/

Testing
-------

Thanks,

Friedrich W. H. Kossebau

--===============7623280497827603568==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120766/">https://git.reviewboard.kde.org/r/120766/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra, Camilla Boemann and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">While checking the includes for classes from \
libkowidgets I found those two classes are no longer used by any code, so I propose \
to remove them as dead code.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Last usage of KoUniColorDialog was \
removed in 53356cb20f1100edf716beba8c407953b3c692ec (by rempt) Last usage of \
KoOpacityConfigWidget was removed in 76242efb3bd5a116f034ef785c0a2e9e3608fc64 (by \
boemann)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/widgets/CMakeLists.txt <span style="color: grey">(324b762)</span></li>

 <li>libs/widgets/KoOpacityConfigWidget.h <span style="color: \
grey">(6fc81ef)</span></li>

 <li>libs/widgets/KoOpacityConfigWidget.cpp <span style="color: \
grey">(48d6395)</span></li>

 <li>libs/widgets/KoUniColorDialog.h <span style="color: grey">(4cce042)</span></li>

 <li>libs/widgets/KoUniColorDialog.cpp <span style="color: \
grey">(935b644)</span></li>

 <li>plugins/defaultTools/defaulttool/DefaultTool.cpp <span style="color: \
grey">(f26d4bf)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120766/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7623280497827603568==--

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 