'Re: Review Request 119098: Better highlight of eraser, alpha lock and mirror modal buttons'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 119098: Better highlight of eraser, alpha lock and mirror modal buttons
From:       "Commit Hook" <null () kde ! org>
Date:       2014-07-03 7:51:13
Message-ID: 20140703075113.22336.44247 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119098/#review61524
-----------------------------------------------------------

This review has been submitted with commit e472babe77eb9ec1ccbef4cafc3b6253bbc870df \
by Ivan Yossi to branch master.

- Commit Hook

On July 3, 2014, 7:28 a.m., Ivan Yossi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119098/
> -----------------------------------------------------------
> 
> (Updated July 3, 2014, 7:28 a.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> We change the button background to highlight color if the mode is activated.
> 
> implemented as a function this is the effect
> https://plus.google.com/104926764783100830207/posts/DinU4TWLs5h
> 
> The only remaining issue is that the color doesn't update if user changes themes.
> 
> 
> Diffs
> -----
> 
> krita/ui/kis_paintop_box.h cfe66bd 
> krita/ui/kis_paintop_box.cc df3a99c 
> 
> Diff: https://git.reviewboard.kde.org/r/119098/diff/
> 
> 
> Testing
> -------
> 
> Compiles and doesn't crash krita.
> 
> 
> Thanks,
> 
> Ivan Yossi
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119098/">https://git.reviewboard.kde.org/r/119098/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit e472babe77eb9ec1ccbef4cafc3b6253bbc870df by Ivan Yossi to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On July 3rd, 2014, 7:28 a.m. UTC, Ivan Yossi wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Ivan Yossi.</div>

<p style="color: grey;"><i>Updated July 3, 2014, 7:28 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We change the button background to highlight color if the mode is \
activated.

implemented as a function this is the effect
https://plus.google.com/104926764783100830207/posts/DinU4TWLs5h

The only remaining issue is that the color doesn&#39;t update if user changes \
themes.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles and doesn&#39;t crash krita.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>krita/ui/kis_paintop_box.h <span style="color: grey">(cfe66bd)</span></li>

 <li>krita/ui/kis_paintop_box.cc <span style="color: grey">(df3a99c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119098/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 