'Re: Review Request 118984: KoPart argument of KoDocument and descendants should not be optional'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 118984: KoPart argument of KoDocument and descendants should not be optional
From:       "Commit Hook" <null () kde ! org>
Date:       2014-07-02 9:21:17
Message-ID: 20140702092117.22318.78904 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118984/#review61464
-----------------------------------------------------------

This review has been submitted with commit 8f83fa3a0996c8ab5aa78ef539bdc88685399264 \
by Jaroslaw Staniek to branch master.

- Commit Hook

On June 29, 2014, 9:14 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118984/
> -----------------------------------------------------------
> 
> (Updated June 29, 2014, 9:14 p.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> KoPart argument of KoDocument and descendants should not be optional
> 
> Currently KoPart is required, there is even assertion for, so express this in the \
> API. Current API apparently caused one crash (in spreadsheet plugin of Kexi).
> 
> Also put 2 more assertions as early as possible.
> 
> Finally, fixed outdated docs.
> 
> 
> Diffs
> -----
> 
> karbon/ui/KarbonDocument.cpp eed34ea 
> krita/ui/kis_doc2.h 657fabc 
> krita/ui/kis_doc2.cc aad9ae5 
> plan/kptmaindocument.h 5c7e44d 
> plan/kptmaindocument.cpp 9b9f485 
> sheets/DocBase.h 946e9cd 
> sheets/DocBase.cpp b01a200 
> sheets/part/Doc.h bf8341c 
> sheets/part/Doc.cpp 44fd7ab 
> words/part/KWDocument.cpp 533b8e1 
> 
> Diff: https://git.reviewboard.kde.org/r/118984/diff/
> 
> 
> Testing
> -------
> 
> Builds, nobody is used the argument-less constructor (after \
> https://git.reviewboard.kde.org/r/118983/ is pushed) 
> 
> Thanks,
> 
> Jarosław Staniek
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118984/">https://git.reviewboard.kde.org/r/118984/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 8f83fa3a0996c8ab5aa78ef539bdc88685399264 by Jaroslaw Staniek to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On June 29th, 2014, 9:14 p.m. UTC, Jarosław Staniek wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Jarosław Staniek.</div>

<p style="color: grey;"><i>Updated June 29, 2014, 9:14 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KoPart argument of KoDocument and descendants should not be optional

Currently KoPart is required, there is even assertion for, so express this in the \
API. Current API apparently caused one crash (in spreadsheet plugin of Kexi).

Also put 2 more assertions as early as possible.

Finally, fixed outdated docs.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds, nobody is used the argument-less constructor (after \
https://git.reviewboard.kde.org/r/118983/ is pushed)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>karbon/ui/KarbonDocument.cpp <span style="color: grey">(eed34ea)</span></li>

 <li>krita/ui/kis_doc2.h <span style="color: grey">(657fabc)</span></li>

 <li>krita/ui/kis_doc2.cc <span style="color: grey">(aad9ae5)</span></li>

 <li>plan/kptmaindocument.h <span style="color: grey">(5c7e44d)</span></li>

 <li>plan/kptmaindocument.cpp <span style="color: grey">(9b9f485)</span></li>

 <li>sheets/DocBase.h <span style="color: grey">(946e9cd)</span></li>

 <li>sheets/DocBase.cpp <span style="color: grey">(b01a200)</span></li>

 <li>sheets/part/Doc.h <span style="color: grey">(bf8341c)</span></li>

 <li>sheets/part/Doc.cpp <span style="color: grey">(44fd7ab)</span></li>

 <li>words/part/KWDocument.cpp <span style="color: grey">(533b8e1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118984/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 