'Re: Review Request 114613: Add support for Karbon specific dockers'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 114613: Add support for Karbon specific dockers
From:       "Elvis Stansvik" <elvstone () gmail ! com>
Date:       2013-12-22 17:22:00
Message-ID: 20131222172200.4579.16486 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114613/
-----------------------------------------------------------

(Updated Dec. 22, 2013, 5:22 p.m.)

Status
------

This change has been marked as submitted.

Review request for Calligra.

Repository: calligra

Description
-------

This patch adds a new service type "Karbon/Dock" and makes KarbonFactory load plugins of this type. \
Currently there are no such plugins, but I'm working on one.

Diffs
-----

  karbon/ui/KarbonFactory.cpp 1e3bf31 
  karbon/data/CMakeLists.txt 57d0056 
  karbon/data/karbon_dock.desktop PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/114613/diff/

Testing
-------

Tested locally that Karbon will now load plugins of type "Karbon/Dock".

Thanks,

Elvis Stansvik

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114613/">https://git.reviewboard.kde.org/r/114613/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
 <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Elvis Stansvik.</div>

<p style="color: grey;"><i>Updated Dec. 22, 2013, 5:22 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a new service type \
&quot;Karbon/Dock&quot; and makes KarbonFactory load plugins of this type. Currently there are no such \
plugins, but I&#39;m working on one.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested locally that Karbon will now load \
plugins of type &quot;Karbon/Dock&quot;.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>karbon/ui/KarbonFactory.cpp <span style="color: grey">(1e3bf31)</span></li>

 <li>karbon/data/CMakeLists.txt <span style="color: grey">(57d0056)</span></li>

 <li>karbon/data/karbon_dock.desktop <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114613/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 