'Re: Review Request 114435: Turn off anti-aliasing when painting Karbon page rect / margins'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 114435: Turn off anti-aliasing when painting Karbon page rect / margins
From:       "Elvis Stansvik" <elvstone () gmail ! com>
Date:       2013-12-16 22:39:05
Message-ID: 20131216223905.29890.25044 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114435/
-----------------------------------------------------------

(Updated Dec. 16, 2013, 10:39 p.m.)

Status
------

This change has been marked as submitted.

Review request for Calligra.

Repository: calligra

Description
-------

The page rectangle and margins are strictly horizontal/vertical lines, so I don't \
think it makes sense to paint them anti-aliased. They look sharper when it's turned \
off. What do you think? (See before/after screenshot).

Diffs
-----

  karbon/ui/widgets/KarbonCanvas.cpp 4737040 

Diff: http://git.reviewboard.kde.org/r/114435/diff/

Testing
-------

File Attachments
----------------

Before (with anti-aliasing)
  http://git.reviewboard.kde.org/media/uploaded/files/2013/12/13/1e481a13-2d70-4242-bf7d-f10b7bce011a__before.png
 After (without anti-aliasing)
  http://git.reviewboard.kde.org/media/uploaded/files/2013/12/13/c2057f12-6ee0-4239-8075-6536373a3f30__after.png

Thanks,

Elvis Stansvik

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114435/">http://git.reviewboard.kde.org/r/114435/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Elvis Stansvik.</div>

<p style="color: grey;"><i>Updated Dec. 16, 2013, 10:39 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The page rectangle and margins are strictly horizontal/vertical lines, \
so I don&#39;t think it makes sense to paint them anti-aliased. They look sharper \
when it&#39;s turned off. What do you think? (See before/after screenshot).</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>karbon/ui/widgets/KarbonCanvas.cpp <span style="color: \
grey">(4737040)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114435/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/12/13/1e481a13-2d70-4242-bf7d-f10b7bce011a__before.png">Before \
(with anti-aliasing)</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/12/13/c2057f12-6ee0-4239-8075-6536373a3f30__after.png">After \
(without anti-aliasing)</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 