[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 114434: Consistent style for tool tooltips
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2013-12-16 22:02:24
Message-ID: 20131216220224.21703.83175 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114434/#review45828
-----------------------------------------------------------
Ship it!
Ship It!
- C. Boemann
On Dec. 16, 2013, 8:06 a.m., Elvis Stansvik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114434/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 8:06 a.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> As discussed briefly on IRC, decapitalize and remove " Tool" suffix from user visible tool names.
>
>
> Diffs
> -----
>
> braindump/plugins/stateshape/StateToolFactory.cpp aa5d15e
> braindump/plugins/webshape/WebToolFactory.cpp f2cb907
> karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyToolFactory.cpp 0cc22b6
> karbon/plugins/tools/KarbonGradientToolFactory.cpp 538d305
> karbon/plugins/tools/KarbonPatternToolFactory.cpp 977ab13
> karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsToolFactory.cpp 409f2d2
> libs/basicflakes/plugin/KoCreatePathToolFactory.cpp f14139c
> libs/basicflakes/plugin/KoPencilToolFactory.cpp 135c321
> libs/flake/tools/KoPathToolFactory.cpp 1846c86
> plugins/artistictextshape/ArtisticTextToolFactory.cpp 07fe8dd
> plugins/chartshape/ChartToolFactory.cpp 269d570
> plugins/commentshape/CommentToolFactory.cpp 2268200b
> plugins/formulashape/KoFormulaToolFactory.cpp 9b33b68
> plugins/musicshape/MusicToolFactory.cpp 58c90d1
> plugins/musicshape/SimpleEntryToolFactory.cpp d381537
> plugins/pictureshape/PictureToolFactory.cpp c1e1c3f
> plugins/staging/templateshape/TemplateToolFactory.cpp 51d046a
> plugins/textshape/ReviewTool.cpp 3686bf7
> plugins/videoshape/VideoToolFactory.cpp 8c75f61
> sheets/plugins/calendar/CalendarToolFactory.cpp 77e4f19
> sheets/shape/TableToolFactory.cpp 2d70f06
> stage/part/tools/KPrPlaceholderToolFactory.cpp a13d8ad
>
> Diff: http://git.reviewboard.kde.org/r/114434/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Elvis Stansvik
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114434/">http://git.reviewboard.kde.org/r/114434/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- C. Boemann</p>
<br />
<p>On December 16th, 2013, 8:06 a.m. UTC, Elvis Stansvik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Elvis Stansvik.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2013, 8:06 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As discussed briefly on IRC, decapitalize and remove " Tool" \
suffix from user visible tool names.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>braindump/plugins/stateshape/StateToolFactory.cpp <span style="color: \
grey">(aa5d15e)</span></li>
<li>braindump/plugins/webshape/WebToolFactory.cpp <span style="color: \
grey">(f2cb907)</span></li>
<li>karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyToolFactory.cpp <span \
style="color: grey">(0cc22b6)</span></li>
<li>karbon/plugins/tools/KarbonGradientToolFactory.cpp <span style="color: \
grey">(538d305)</span></li>
<li>karbon/plugins/tools/KarbonPatternToolFactory.cpp <span style="color: \
grey">(977ab13)</span></li>
<li>karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsToolFactory.cpp <span \
style="color: grey">(409f2d2)</span></li>
<li>libs/basicflakes/plugin/KoCreatePathToolFactory.cpp <span style="color: \
grey">(f14139c)</span></li>
<li>libs/basicflakes/plugin/KoPencilToolFactory.cpp <span style="color: \
grey">(135c321)</span></li>
<li>libs/flake/tools/KoPathToolFactory.cpp <span style="color: \
grey">(1846c86)</span></li>
<li>plugins/artistictextshape/ArtisticTextToolFactory.cpp <span style="color: \
grey">(07fe8dd)</span></li>
<li>plugins/chartshape/ChartToolFactory.cpp <span style="color: \
grey">(269d570)</span></li>
<li>plugins/commentshape/CommentToolFactory.cpp <span style="color: \
grey">(2268200b)</span></li>
<li>plugins/formulashape/KoFormulaToolFactory.cpp <span style="color: \
grey">(9b33b68)</span></li>
<li>plugins/musicshape/MusicToolFactory.cpp <span style="color: \
grey">(58c90d1)</span></li>
<li>plugins/musicshape/SimpleEntryToolFactory.cpp <span style="color: \
grey">(d381537)</span></li>
<li>plugins/pictureshape/PictureToolFactory.cpp <span style="color: \
grey">(c1e1c3f)</span></li>
<li>plugins/staging/templateshape/TemplateToolFactory.cpp <span style="color: \
grey">(51d046a)</span></li>
<li>plugins/textshape/ReviewTool.cpp <span style="color: grey">(3686bf7)</span></li>
<li>plugins/videoshape/VideoToolFactory.cpp <span style="color: \
grey">(8c75f61)</span></li>
<li>sheets/plugins/calendar/CalendarToolFactory.cpp <span style="color: \
grey">(77e4f19)</span></li>
<li>sheets/shape/TableToolFactory.cpp <span style="color: \
grey">(2d70f06)</span></li>
<li>stage/part/tools/KPrPlaceholderToolFactory.cpp <span style="color: \
grey">(a13d8ad)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114434/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic