[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 114243: Don't print annotations
From:       "C. Boemann" <cbr () boemann ! dk>
Date:       2013-12-01 20:43:08
Message-ID: 20131201204308.31456.31192 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114243/#review44960
-----------------------------------------------------------

Ship it!


Ship It!

- C. Boemann


On Dec. 1, 2013, 8:40 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114243/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2013, 8:40 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch prevents annotations (comments) to be printed. Annotations were \
> previously visible in "print preview" but since the annotations are shown outside \
> the page only one thin edge was shown, where the page shadow was. This patch \
> disables painting of annotations when printing. 
> This patch was originally from zagge but he had a bug in it that I fixed.
> 
> 
> Diffs
> -----
> 
> libs/flake/KoShapePaintingContext.h b8ddac1 
> libs/flake/KoShapePaintingContext.cpp 7939de7 
> plugins/textshape/AnnotationTextShape.cpp 311d6bf 
> 
> Diff: http://git.reviewboard.kde.org/r/114243/diff/
> 
> 
> Testing
> -------
> 
> Testing with my standard text documents with annotations.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
> 


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114243/">http://git.reviewboard.kde.org/r/114243/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />









<p>- C. Boemann</p>


<br />
<p>On December 1st, 2013, 8:40 p.m. UTC, Inge Wallin wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Inge Wallin.</div>


<p style="color: grey;"><i>Updated Dec. 1, 2013, 8:40 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch prevents annotations (comments) to be printed. Annotations \
were previously visible in &quot;print preview&quot; but since the annotations are \
shown outside the page only one thin edge was shown, where the page shadow was. This \
patch disables painting of annotations when printing.

This patch was originally from zagge but he had a bug in it that I fixed.
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing with my standard text documents with annotations.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/flake/KoShapePaintingContext.h <span style="color: \
grey">(b8ddac1)</span></li>

 <li>libs/flake/KoShapePaintingContext.cpp <span style="color: \
grey">(7939de7)</span></li>

 <li>plugins/textshape/AnnotationTextShape.cpp <span style="color: \
grey">(311d6bf)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114243/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic