[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 110821: Pasting of text when text tool is not active, and of images when default
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2013-12-01 7:55:10
Message-ID: 20131201075510.330.6061 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110821/
-----------------------------------------------------------
(Updated Dec. 1, 2013, 7:55 a.m.)
Status
------
This change has been marked as submitted.
Review request for Calligra.
Repository: calligra
Description
-------
Pasting of images of text and images was broken, because you could only paste text if \
the texttool was active, or you could only paste images if the default tool was \
active.
This patch changes it so that pasting of these things is now handled by toolproxy, so \
you are able to paste in all cases, unless the active tool consumes the data.
Diffs
-----
libs/flake/KoDocumentResourceManager.h 27302a0
libs/flake/KoDocumentResourceManager.cpp e42dc9d
libs/flake/KoShapeAnchor.cpp 83087c3
libs/flake/KoShapeController.cpp 817ba5e
libs/flake/KoShapePaste.cpp 1457daf
libs/flake/KoToolProxy.cpp 634a1ed
libs/kotext/KoTextEditor.h 9fd3c05
libs/kotext/KoTextEditor.cpp 40ac427
libs/kotext/KoTextPaste.h 522ccce
libs/kotext/KoTextPaste.cpp 2304d6a
libs/kotext/commands/ChangeTrackedDeleteCommand.cpp 044fd27
libs/kotext/commands/TextPasteCommand.h 77d710a
libs/kotext/commands/TextPasteCommand.cpp 34ea25c
libs/kotext/opendocument/KoTextLoader.cpp 7831109
libs/kotext/opendocument/KoTextSharedLoadingData.h 5ebb7a1
libs/kotext/opendocument/KoTextSharedLoadingData.cpp d9a73e9
libs/kotext/tests/TestKoTextEditor.h 60fe599
libs/kotext/tests/TestKoTextEditor.cpp 75fa075
plugins/defaultTools/defaulttool/DefaultTool.cpp 68ba881
plugins/textshape/TextShapeFactory.cpp d7e8fe8
plugins/textshape/TextTool.cpp 96294a0
words/part/KWView.cpp b299234
Diff: http://git.reviewboard.kde.org/r/110821/diff/
Testing
-------
Thanks,
C. Boemann
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110821/">http://git.reviewboard.kde.org/r/110821/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Dec. 1, 2013, 7:55 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Pasting of images of text and images was broken, because you could only \
paste text if the texttool was active, or you could only paste images if the default \
tool was active.
This patch changes it so that pasting of these things is now handled by toolproxy, so \
you are able to paste in all cases, unless the active tool consumes the data.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoDocumentResourceManager.h <span style="color: \
grey">(27302a0)</span></li>
<li>libs/flake/KoDocumentResourceManager.cpp <span style="color: \
grey">(e42dc9d)</span></li>
<li>libs/flake/KoShapeAnchor.cpp <span style="color: grey">(83087c3)</span></li>
<li>libs/flake/KoShapeController.cpp <span style="color: grey">(817ba5e)</span></li>
<li>libs/flake/KoShapePaste.cpp <span style="color: grey">(1457daf)</span></li>
<li>libs/flake/KoToolProxy.cpp <span style="color: grey">(634a1ed)</span></li>
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(9fd3c05)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(40ac427)</span></li>
<li>libs/kotext/KoTextPaste.h <span style="color: grey">(522ccce)</span></li>
<li>libs/kotext/KoTextPaste.cpp <span style="color: grey">(2304d6a)</span></li>
<li>libs/kotext/commands/ChangeTrackedDeleteCommand.cpp <span style="color: \
grey">(044fd27)</span></li>
<li>libs/kotext/commands/TextPasteCommand.h <span style="color: \
grey">(77d710a)</span></li>
<li>libs/kotext/commands/TextPasteCommand.cpp <span style="color: \
grey">(34ea25c)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: \
grey">(7831109)</span></li>
<li>libs/kotext/opendocument/KoTextSharedLoadingData.h <span style="color: \
grey">(5ebb7a1)</span></li>
<li>libs/kotext/opendocument/KoTextSharedLoadingData.cpp <span style="color: \
grey">(d9a73e9)</span></li>
<li>libs/kotext/tests/TestKoTextEditor.h <span style="color: \
grey">(60fe599)</span></li>
<li>libs/kotext/tests/TestKoTextEditor.cpp <span style="color: \
grey">(75fa075)</span></li>
<li>plugins/defaultTools/defaulttool/DefaultTool.cpp <span style="color: \
grey">(68ba881)</span></li>
<li>plugins/textshape/TextShapeFactory.cpp <span style="color: \
grey">(d7e8fe8)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(96294a0)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(b299234)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110821/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic