[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 111914: Add support for annotations, a.k.a. notes, to Words and Author
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2013-11-29 22:32:45
Message-ID: 20131129223245.11901.19020 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111914/#review44846
-----------------------------------------------------------
uhm please hold the merge until the scrollbar is fixed
- C. Boemann
On Nov. 29, 2013, 8:56 p.m., Inge Wallin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111914/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2013, 8:56 p.m.)
>
>
> Review request for Calligra.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> This patch adds support for annotations, also known as comments, to Words and Author.
>
> Annotations work now and you can check out the branch text-annotation if you want to test it.
>
> There is one misfeature: annotations are shown when printing but that should be disabled asap.
>
>
> Diffs
> -----
>
> ANNOTATIONS-ODF PRE-CREATION
> TODO-ANNOTATIONS PRE-CREATION
> libs/flake/CMakeLists.txt a6614f2
> libs/flake/KoAnnotationLayoutManager.h PRE-CREATION
> libs/flake/KoAnnotationLayoutManager.cpp PRE-CREATION
> libs/flake/KoShapeController.h 2ae03ca
> libs/flake/KoShapeController.cpp 817ba5e
> libs/flake/KoShapeManager.h 9df1671
> libs/flake/KoShapeManager.cpp 36666ce
> libs/kotext/CMakeLists.txt 2e66080
> libs/kotext/KoAnnotation.h c4457fd
> libs/kotext/KoAnnotation.cpp e5a8a53
> libs/kotext/KoTextEditor.h 9fd3c05
> libs/kotext/KoTextEditor.cpp 40ac427
> libs/kotext/KoTextRangeManager.cpp fdde8ee
> libs/kotext/commands/AddAnnotationCommand.h PRE-CREATION
> libs/kotext/commands/AddAnnotationCommand.cpp PRE-CREATION
> libs/kotext/commands/DeleteAnnotationsCommand.h PRE-CREATION
> libs/kotext/commands/DeleteAnnotationsCommand.cpp PRE-CREATION
> libs/kotext/commands/DeleteCommand.cpp ad81ce0
> libs/kotext/opendocument/KoTextLoader.cpp 7831109
> libs/main/KoModeBox.cpp 0f5f2f4
> libs/textlayout/KoTextDocumentLayout.h a0fabcf
> libs/textlayout/KoTextDocumentLayout.cpp a314223
> plugins/textshape/AnnotationTextShape.h PRE-CREATION
> plugins/textshape/AnnotationTextShape.cpp PRE-CREATION
> plugins/textshape/AnnotationTextShapeFactory.h PRE-CREATION
> plugins/textshape/AnnotationTextShapeFactory.cpp PRE-CREATION
> plugins/textshape/CMakeLists.txt 1838cf1
> plugins/textshape/ReviewTool.h e2b8f95
> plugins/textshape/ReviewTool.cpp 53c87c7
> plugins/textshape/ReviewToolFactory.cpp 48b56f1
> plugins/textshape/SimpleRootAreaProvider.cpp eb76e57
> plugins/textshape/TextPlugin.cpp b99243f
> plugins/textshape/TextTool.h a87a9d1
> plugins/textshape/TextTool.cpp 96294a0
> plugins/textshape/TextToolFactory.cpp 0ced315
> plugins/textshape/dialogs/SimpleAnnotationWidget.h PRE-CREATION
> plugins/textshape/dialogs/SimpleAnnotationWidget.cpp PRE-CREATION
> plugins/textshape/dialogs/SimpleAnnotationWidget.ui PRE-CREATION
> plugins/textshape/dialogs/SimpleSpellCheckingWidget.ui 07b3cda
> words/part/KWCanvas.cpp f33d993
> words/part/KWCanvasBase.h 31111ce
> words/part/KWCanvasBase.cpp 22d1c5f
> words/part/KWDocument.h fc552ba
> words/part/KWDocument.cpp c1f70ca
> words/part/KWOdfSharedLoadingData.cpp 450b580
> words/part/KWOdfWriter.cpp 771eee2
> words/part/KWView.h 473348f
> words/part/KWView.cpp 7c61533
> words/part/KWViewModeNormal.cpp 88e67b2
> words/part/frames/KWTextFrameSet.cpp 1bb513c
> words/part/words.rc 7a26cb8
>
> Diff: http://git.reviewboard.kde.org/r/111914/diff/
>
>
> Testing
> -------
>
> Created test files in LO with annotations and loaded them. Also created our own test files.
>
>
> Thanks,
>
> Inge Wallin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111914/">http://git.reviewboard.kde.org/r/111914/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">uhm please hold the \
merge until the scrollbar is fixed</pre> <br />
<p>- C. Boemann</p>
<br />
<p>On November 29th, 2013, 8:56 p.m. UTC, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2013, 8:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for annotations, also known as comments, to \
Words and Author.
Annotations work now and you can check out the branch text-annotation if you want to \
test it.
There is one misfeature: annotations are shown when printing but that should be \
disabled asap.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Created test files in LO with annotations and loaded them. Also created \
our own test files.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ANNOTATIONS-ODF <span style="color: grey">(PRE-CREATION)</span></li>
<li>TODO-ANNOTATIONS <span style="color: grey">(PRE-CREATION)</span></li>
<li>libs/flake/CMakeLists.txt <span style="color: grey">(a6614f2)</span></li>
<li>libs/flake/KoAnnotationLayoutManager.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoAnnotationLayoutManager.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/flake/KoShapeController.h <span style="color: grey">(2ae03ca)</span></li>
<li>libs/flake/KoShapeController.cpp <span style="color: grey">(817ba5e)</span></li>
<li>libs/flake/KoShapeManager.h <span style="color: grey">(9df1671)</span></li>
<li>libs/flake/KoShapeManager.cpp <span style="color: grey">(36666ce)</span></li>
<li>libs/kotext/CMakeLists.txt <span style="color: grey">(2e66080)</span></li>
<li>libs/kotext/KoAnnotation.h <span style="color: grey">(c4457fd)</span></li>
<li>libs/kotext/KoAnnotation.cpp <span style="color: grey">(e5a8a53)</span></li>
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(9fd3c05)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(40ac427)</span></li>
<li>libs/kotext/KoTextRangeManager.cpp <span style="color: \
grey">(fdde8ee)</span></li>
<li>libs/kotext/commands/AddAnnotationCommand.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/AddAnnotationCommand.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/DeleteAnnotationsCommand.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/DeleteAnnotationsCommand.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/kotext/commands/DeleteCommand.cpp <span style="color: \
grey">(ad81ce0)</span></li>
<li>libs/kotext/opendocument/KoTextLoader.cpp <span style="color: \
grey">(7831109)</span></li>
<li>libs/main/KoModeBox.cpp <span style="color: grey">(0f5f2f4)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.h <span style="color: \
grey">(a0fabcf)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.cpp <span style="color: \
grey">(a314223)</span></li>
<li>plugins/textshape/AnnotationTextShape.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/AnnotationTextShape.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/AnnotationTextShapeFactory.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/AnnotationTextShapeFactory.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(1838cf1)</span></li>
<li>plugins/textshape/ReviewTool.h <span style="color: grey">(e2b8f95)</span></li>
<li>plugins/textshape/ReviewTool.cpp <span style="color: grey">(53c87c7)</span></li>
<li>plugins/textshape/ReviewToolFactory.cpp <span style="color: \
grey">(48b56f1)</span></li>
<li>plugins/textshape/SimpleRootAreaProvider.cpp <span style="color: \
grey">(eb76e57)</span></li>
<li>plugins/textshape/TextPlugin.cpp <span style="color: grey">(b99243f)</span></li>
<li>plugins/textshape/TextTool.h <span style="color: grey">(a87a9d1)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(96294a0)</span></li>
<li>plugins/textshape/TextToolFactory.cpp <span style="color: \
grey">(0ced315)</span></li>
<li>plugins/textshape/dialogs/SimpleAnnotationWidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleAnnotationWidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleAnnotationWidget.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleSpellCheckingWidget.ui <span style="color: \
grey">(07b3cda)</span></li>
<li>words/part/KWCanvas.cpp <span style="color: grey">(f33d993)</span></li>
<li>words/part/KWCanvasBase.h <span style="color: grey">(31111ce)</span></li>
<li>words/part/KWCanvasBase.cpp <span style="color: grey">(22d1c5f)</span></li>
<li>words/part/KWDocument.h <span style="color: grey">(fc552ba)</span></li>
<li>words/part/KWDocument.cpp <span style="color: grey">(c1f70ca)</span></li>
<li>words/part/KWOdfSharedLoadingData.cpp <span style="color: \
grey">(450b580)</span></li>
<li>words/part/KWOdfWriter.cpp <span style="color: grey">(771eee2)</span></li>
<li>words/part/KWView.h <span style="color: grey">(473348f)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(7c61533)</span></li>
<li>words/part/KWViewModeNormal.cpp <span style="color: grey">(88e67b2)</span></li>
<li>words/part/frames/KWTextFrameSet.cpp <span style="color: \
grey">(1bb513c)</span></li>
<li>words/part/words.rc <span style="color: grey">(7a26cb8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111914/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic