[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 113783: fix tests on provided area rect in TestDocumentLayout.cpp
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2013-11-10 8:46:14
Message-ID: 20131110084614.14985.7533 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113783/#review43320
-----------------------------------------------------------
Ship it!
thanks, yes your fixes makes sense
- C. Boemann
On Nov. 10, 2013, 5:31 a.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113783/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2013, 5:31 a.m.)
>
>
> Review request for Calligra, C. Boemann and Inge Wallin.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> 83902350e8b0e2f13443ea19ba95b6397261620b includes the squashed \
> a32fd9886c719a9d019c7d13925a862801ad675d, which has the message: "Seems that \
> boemann is not building the tests. Booo!"
> I could only add:
> "Seems that boemann & ingwa are not running the tests. More Booo!" ;)
>
> The other comment there though I have to paraphrase here:
> "The test now succeeds but I don't know exactly if the tested rects make sense."
>
> Do they?
>
> Added "+ 100" to all the tests for TestBlockLayout, to adapt to the x and y offset \
> resulting from this change to libs/textlayout/tests/MockRootAreaProvider.cpp:
> - m_suggestedSize(QSizeF(200,1000)),
> + m_suggestedRect(QRectF(100, 100, 200,1000)),
>
>
> Let's make sure again there is no red in \
> http://build.kde.org/job/calligra_master/test/?width=800&height=600 Yes, krita devs \
> need to do definitely something about it, but it is not only them. So everybody \
> don't forget to give it a look now and then.
>
> Diffs
> -----
>
> libs/textlayout/tests/TestBlockLayout.cpp 422e97e
> libs/textlayout/tests/TestDocumentLayout.cpp c411305
>
> Diff: http://git.reviewboard.kde.org/r/113783/diff/
>
>
> Testing
> -------
>
> Oh yes ;)
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113783/">http://git.reviewboard.kde.org/r/113783/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">thanks, yes your fixes \
makes sense
</pre>
<br />
<p>- C. Boemann</p>
<br />
<p>On November 10th, 2013, 5:31 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra, C. Boemann and Inge Wallin.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2013, 5:31 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">83902350e8b0e2f13443ea19ba95b6397261620b includes the squashed \
a32fd9886c719a9d019c7d13925a862801ad675d, which has the message: "Seems that \
boemann is not building the tests. Booo!"
I could only add:
"Seems that boemann & ingwa are not running the tests. More Booo!" ;)
The other comment there though I have to paraphrase here:
"The test now succeeds but I don't know exactly if the tested rects make \
sense."
Do they?
Added "+ 100" to all the tests for TestBlockLayout, to adapt to the x and y \
offset resulting from this change to libs/textlayout/tests/MockRootAreaProvider.cpp:
- m_suggestedSize(QSizeF(200,1000)),
+ m_suggestedRect(QRectF(100, 100, 200,1000)),
Let's make sure again there is no red in \
http://build.kde.org/job/calligra_master/test/?width=800&height=600 Yes, krita \
devs need to do definitely something about it, but it is not only them. So everybody \
don't forget to give it a look now and then.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Oh yes ;)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/textlayout/tests/TestBlockLayout.cpp <span style="color: \
grey">(422e97e)</span></li>
<li>libs/textlayout/tests/TestDocumentLayout.cpp <span style="color: \
grey">(c411305)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113783/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic