[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 113261: Port KoRdfFoaF & KoRdfCalendarEvent to Akonadi
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2013-11-03 21:25:33
Message-ID: 20131103212533.8054.39189 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113261/#review42910
-----------------------------------------------------------
Ship it!
weee, great job - let's get it in
- C. Boemann
On Nov. 3, 2013, 9:20 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113261/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2013, 9:20 p.m.)
>
>
> Review request for Calligra, C. Boemann and Boudewijn Rempt.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Time to get rid of those mass "Deprecated!!11!" warnings finally, no? :)
>
> Instead of saving to some default addressbook/calendar queries the user where to \
> save to. Simplest solution, as with Akonadi there is no such concept as a default \
> addressbook/calendar. And this is prototype code anyway.
> Also sets the minimal KDEPIM wanted to 4.6, as that only brings KCalCore in and I \
> did not feel like if-def-ing KoRdfCalendarEvent. KDEPIM >= 4.6 might not be on \
> CentOO 6, but Plan needs newer Akonadi classes (4.5) for some time/releases already \
> (without telling), so pushing the min. req. directly to 4.6.0 seemed okay to me.
> Which means no KDEPIM export support for those RDF classes on CentOS 6 in the next \
> release, but that should be okay, or is anybody known to need it there?
>
> Diffs
> -----
>
> CMakeLists.txt 4336d86
> README.PACKAGERS e82029c
> plugins/semanticitems/contact/CMakeLists.txt ad9fcab
> plugins/semanticitems/contact/KoRdfFoaF.h 64317c7
> plugins/semanticitems/contact/KoRdfFoaF.cpp 8344136
> plugins/semanticitems/event/CMakeLists.txt 4222655
> plugins/semanticitems/event/KoRdfCalendarEvent.h 351820c
> plugins/semanticitems/event/KoRdfCalendarEvent.cpp 9763abe
>
> Diff: http://git.reviewboard.kde.org/r/113261/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113261/">http://git.reviewboard.kde.org/r/113261/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">weee, great job - \
let's get it in</pre> <br />
<p>- C. Boemann</p>
<br />
<p>On November 3rd, 2013, 9:20 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra, C. Boemann and Boudewijn Rempt.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2013, 9:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Time to get rid of those mass "Deprecated!!11!" warnings \
finally, no? :)
Instead of saving to some default addressbook/calendar queries the user where to save \
to. Simplest solution, as with Akonadi there is no such concept as a default \
addressbook/calendar. And this is prototype code anyway.
Also sets the minimal KDEPIM wanted to 4.6, as that only brings KCalCore in and I did \
not feel like if-def-ing KoRdfCalendarEvent. KDEPIM >= 4.6 might not be on CentOO \
6, but Plan needs newer Akonadi classes (4.5) for some time/releases already (without \
telling), so pushing the min. req. directly to 4.6.0 seemed okay to me.
Which means no KDEPIM export support for those RDF classes on CentOS 6 in the next \
release, but that should be okay, or is anybody known to need it there?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4336d86)</span></li>
<li>README.PACKAGERS <span style="color: grey">(e82029c)</span></li>
<li>plugins/semanticitems/contact/CMakeLists.txt <span style="color: \
grey">(ad9fcab)</span></li>
<li>plugins/semanticitems/contact/KoRdfFoaF.h <span style="color: \
grey">(64317c7)</span></li>
<li>plugins/semanticitems/contact/KoRdfFoaF.cpp <span style="color: \
grey">(8344136)</span></li>
<li>plugins/semanticitems/event/CMakeLists.txt <span style="color: \
grey">(4222655)</span></li>
<li>plugins/semanticitems/event/KoRdfCalendarEvent.h <span style="color: \
grey">(351820c)</span></li>
<li>plugins/semanticitems/event/KoRdfCalendarEvent.cpp <span style="color: \
grey">(9763abe)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113261/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic