[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 109907: Use platform native file dialogs
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2013-09-25 6:27:46
Message-ID: 20130925062746.26150.8369 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109907/#review40733
-----------------------------------------------------------
i think we can ship your branch, except for a few issues
libs/main/KoMainWindow.cpp
<http://git.reviewboard.kde.org/r/109907/#comment29961>
could we please leave these changes out
libs/main/KoMainWindow.cpp
<http://git.reviewboard.kde.org/r/109907/#comment29962>
could we please leave this changes out
libs/main/KoMainWindow.cpp
<http://git.reviewboard.kde.org/r/109907/#comment29963>
seems to be one of the features that we loose, but is it really not possible to \
recreate the effect?
- C. Boemann
On Sept. 23, 2013, 3:01 a.m., Yue Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109907/
> -----------------------------------------------------------
>
> (Updated Sept. 23, 2013, 3:01 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Currently kfiledialog and kofiledialog is widely used, this results in non-native \
> file dialog on Mac/Windows/Gnome. However, qfiledialog static methods does not \
> support modal sheet in Mac, so a KoModalFileDialog is created for window-modal file \
> dialog, such as save as or import, while other file dialog such as open will use \
> qfiledialog static methods.
> This is a very first version which blocks save as encrypted since encrypted odf has \
> same suffix as normal odf while when using native dialog you have to use suffix to \
> distinguish different format. My idea is to create another menu item "Save As \
> Encrypted..." where encrypted odf will be saved.
> There are still many file dialogs not touched yet, and for places where kfilewidget \
> is used, such as startup file open widget, kexi file widget, export to pdf widget, \
> it is impossible to use native dialog. My idea is redesign those widget and split \
> the configure part and file chooser part into two separate dialogs, then use native \
> file dialogs.
>
> Diffs
> -----
>
> krita/plugins/extensions/bigbrother/bigbrother.cc 5ba4ac5
> libs/main/CMakeLists.txt 3a9110c
> libs/main/KoDetailsPaneBase.ui d692a00
> libs/main/KoExistingDocumentPane.h fd7b4fd
> libs/main/KoExistingDocumentPane.cpp 2ea6746
> libs/main/KoFileDialog.h da94281
> libs/main/KoFileDialog.cpp c5a7fc2
> libs/main/KoFileDialogHelper.h PRE-CREATION
> libs/main/KoFileDialogHelper.cpp PRE-CREATION
> libs/main/KoMainWindow.cpp d5fbde0
> libs/main/KoOpenPane.h 46c291d
> libs/main/KoOpenPane.cpp a1a7411
> libs/main/KoOpenPaneBase.ui 0b2f2cf
> plan/workpackage/application.cpp b3642d6
> sheets/dialogs/CSVDialog.h 0763538
> sheets/dialogs/CSVDialog.cpp 4d6a19d
>
> Diff: http://git.reviewboard.kde.org/r/109907/diff/
>
>
> Testing
> -------
>
> Works fine on OS X 10.8
>
>
> File Attachments
> ----------------
>
> save as dialog
> http://git.reviewboard.kde.org/media/uploaded/files/2013/04/08/Screen_Shot_2013-04-07_at_11.54.47_PM.png
>
>
> Thanks,
>
> Yue Liu
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109907/">http://git.reviewboard.kde.org/r/109907/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i think we can ship your \
branch, except for a few issues</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109907/diff/3/?file=191253#file191253line814" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/main/KoMainWindow.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KoMainWindow::exportConfirmation(const QByteArray &outputFormat)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">812</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">(</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">814</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span \
class="p">(</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">could we \
please leave these changes out</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109907/diff/3/?file=191253#file191253line872" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/main/KoMainWindow.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KoMainWindow::saveDocument(bool saveas, bool silent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">870</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KoFilterManager</span><span class="o">::</span><span \
class="n">Export</span><span class="p">,</span> <span class="n">d</span><span \
class="o">-></span><span class="n">rootDocument</span><span \
class="o">-></span><span class="n">extraNativeMimeTypes</span><span \
class="p">(</span><span class="n">KoDocument</span><span class="o">::</span><span \
class="n">ForExport</span><span class="p">));</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">872</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">KoFilterManager</span><span class="o">::</span><span \
class="n">Export</span><span class="p">,</span> <span class="n">d</span><span \
class="o">-></span><span class="n">rootDocument</span><span \
class="o">-></span><span class="n">extraNativeMimeTypes</span><span \
class="p">(</span><span class="n">KoDocument</span><span class="o">::</span><span \
class="n">ForExport</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">could we \
please leave this changes out</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109907/diff/3/?file=191253#file191253line924" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/main/KoMainWindow.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KoMainWindow::saveDocument(bool saveas, bool silent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">919</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">else</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">seems to be \
one of the features that we loose, but is it really not possible to recreate the \
effect?</pre> </div>
<br />
<p>- C.</p>
<br />
<p>On September 23rd, 2013, 3:01 a.m. UTC, Yue Liu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Yue Liu.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2013, 3:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently kfiledialog and kofiledialog is widely used, this results in \
non-native file dialog on Mac/Windows/Gnome. However, qfiledialog static methods does \
not support modal sheet in Mac, so a KoModalFileDialog is created for window-modal \
file dialog, such as save as or import, while other file dialog such as open will use \
qfiledialog static methods.
This is a very first version which blocks save as encrypted since encrypted odf has \
same suffix as normal odf while when using native dialog you have to use suffix to \
distinguish different format. My idea is to create another menu item "Save As \
Encrypted..." where encrypted odf will be saved.
There are still many file dialogs not touched yet, and for places where kfilewidget \
is used, such as startup file open widget, kexi file widget, export to pdf widget, it \
is impossible to use native dialog. My idea is redesign those widget and split the \
configure part and file chooser part into two separate dialogs, then use native file \
dialogs.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works fine on OS X 10.8</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krita/plugins/extensions/bigbrother/bigbrother.cc <span style="color: \
grey">(5ba4ac5)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(3a9110c)</span></li>
<li>libs/main/KoDetailsPaneBase.ui <span style="color: grey">(d692a00)</span></li>
<li>libs/main/KoExistingDocumentPane.h <span style="color: \
grey">(fd7b4fd)</span></li>
<li>libs/main/KoExistingDocumentPane.cpp <span style="color: \
grey">(2ea6746)</span></li>
<li>libs/main/KoFileDialog.h <span style="color: grey">(da94281)</span></li>
<li>libs/main/KoFileDialog.cpp <span style="color: grey">(c5a7fc2)</span></li>
<li>libs/main/KoFileDialogHelper.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/main/KoFileDialogHelper.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/main/KoMainWindow.cpp <span style="color: grey">(d5fbde0)</span></li>
<li>libs/main/KoOpenPane.h <span style="color: grey">(46c291d)</span></li>
<li>libs/main/KoOpenPane.cpp <span style="color: grey">(a1a7411)</span></li>
<li>libs/main/KoOpenPaneBase.ui <span style="color: grey">(0b2f2cf)</span></li>
<li>plan/workpackage/application.cpp <span style="color: grey">(b3642d6)</span></li>
<li>sheets/dialogs/CSVDialog.h <span style="color: grey">(0763538)</span></li>
<li>sheets/dialogs/CSVDialog.cpp <span style="color: grey">(4d6a19d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109907/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/04/08/Screen_Shot_2013-04-07_at_11.54.47_PM.png">save \
as dialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic