'Re: Review Request 112131: Make it possible for tools to report that they can work with more than on'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 112131: Make it possible for tools to report that they can work with more than on
From:       "C. Boemann" <cbr () boemann ! dk>
Date:       2013-09-04 7:38:49
Message-ID: 20130904073849.30770.75554 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112131/
-----------------------------------------------------------

(Updated Sept. 4, 2013, 7:38 a.m.)

Status
------

This change has been marked as submitted.

Review request for Calligra.

Description
-------

In the annotation branch, we have made an annotation shape that is subclass of the \
textshape.

And we need for the textshape to be able to be default tool for the annotation shape \
as well as the normal textshape

The solution is for the activationId of toolfactories to be a comma seperated list of \
shape ids

Diffs
-----

  libs/flake/KoToolManager.cpp 6134099 

Diff: http://git.reviewboard.kde.org/r/112131/diff/

Testing
-------

i've tested it in the annotation branch where it works flawlessly

Thanks,

C. Boemann

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/112131/">http://git.reviewboard.kde.org/r/112131/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>

<p style="color: grey;"><i>Updated Sept. 4, 2013, 7:38 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In the annotation branch, we have made an annotation shape that is \
subclass of the textshape.

And we need for the textshape to be able to be default tool for the annotation shape \
as well as the normal textshape

The solution is for the activationId of toolfactories to be a comma seperated list of \
shape ids</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">i&#39;ve tested it in the annotation branch where it works \
flawlessly</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/flake/KoToolManager.cpp <span style="color: grey">(6134099)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/112131/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 