[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2013-08-28 7:45:46
Message-ID: 20130828074546.15742.8214 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111747/
-----------------------------------------------------------
(Updated Aug. 28, 2013, 7:45 a.m.)
Review request for Calligra.
Changes
-------
and agaist current master
Description
-------
An earlier version of this patch has already been up for review before, but now is \
the time to ask for it to be merged
Diffs (updated)
-----
flow/part/FlowView.cpp b30dbe9
libs/basicflakes/tools/KoCreatePathTool.h 101ad4e
libs/basicflakes/tools/KoCreatePathTool.cpp 8f0f547
libs/basicflakes/tools/KoCreatePathTool_p.h 51f4a8f
libs/kopageapp/CMakeLists.txt 7cbf340
libs/kopageapp/KoPAView.h 80b9f78
libs/kopageapp/KoPAView.cpp bb88ee4
libs/kopageapp/tools/backgroundTool/BackgroundToolWidget.ui 937e569
libs/kopageapp/tools/backgroundTool/CMakeLists.txt 339c671
libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h 45a240f
libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp 69f7649
libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.h cb75621
libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp b803e79
libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp 505c3da
libs/kopageapp/widgets/KoPABackgroundFillWidget.h PRE-CREATION
libs/kopageapp/widgets/KoPABackgroundFillWidget.cpp PRE-CREATION
libs/main/KoModeBox.cpp a653216
libs/main/KoModeBoxDocker.cpp a6969fd
libs/main/KoModeBoxDocker_p.h f480781
libs/main/KoModeBox_p.h 2d54bf5
libs/widgets/KoFillConfigWidget.h c2d8fca
libs/widgets/KoFillConfigWidget.cpp 3948290
libs/widgets/KoStrokeConfigWidget.h 8b37d48
libs/widgets/KoStrokeConfigWidget.cpp 4f4ead8
plugins/defaultTools/defaulttool/DefaultTool.cpp 0e77389
plugins/dockers/CMakeLists.txt 2c041e7
plugins/dockers/Plugin.cpp 9b6c442
plugins/dockers/styledocker/StrokeFillWidget.h 06082e4
plugins/dockers/styledocker/StrokeFillWidget.cpp 1945a57
plugins/dockers/styledocker/StyleButtonBox.h e2957fa
plugins/dockers/styledocker/StyleButtonBox.cpp 291a5af
plugins/dockers/styledocker/StyleDocker.h 6daa8f4
plugins/dockers/styledocker/StyleDocker.cpp 9f86be9
plugins/dockers/styledocker/StyleDockerFactory.h acd91ac
plugins/dockers/styledocker/StyleDockerFactory.cpp 5898610
plugins/dockers/styledocker/StylePreview.h da81351
plugins/dockers/styledocker/StylePreview.cpp e196fe3
plugins/textshape/dialogs/SimpleTableWidget.ui cf9efa0
stage/part/CMakeLists.txt 65b956e
stage/part/KPrPageLayoutWidget.h PRE-CREATION
stage/part/KPrPageLayoutWidget.cpp PRE-CREATION
stage/part/KPrView.cpp 6ec2402
stage/part/dockers/KPrPageLayoutDocker.h ed7a547
stage/part/dockers/KPrPageLayoutDocker.cpp 8348e2c
Diff: http://git.reviewboard.kde.org/r/111747/diff/
Testing
-------
just working with it, and fixing the reviews from the earlier review
Thanks,
C. Boemann
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111747/">http://git.reviewboard.kde.org/r/111747/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2013, 7:45 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">and agaist current master</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">An earlier version of this patch has already been up for review before, \
but now is the time to ask for it to be merged</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">just working with it, and fixing the reviews from the earlier \
review</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>flow/part/FlowView.cpp <span style="color: grey">(b30dbe9)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool.h <span style="color: \
grey">(101ad4e)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool.cpp <span style="color: \
grey">(8f0f547)</span></li>
<li>libs/basicflakes/tools/KoCreatePathTool_p.h <span style="color: \
grey">(51f4a8f)</span></li>
<li>libs/kopageapp/CMakeLists.txt <span style="color: grey">(7cbf340)</span></li>
<li>libs/kopageapp/KoPAView.h <span style="color: grey">(80b9f78)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(bb88ee4)</span></li>
<li>libs/kopageapp/tools/backgroundTool/BackgroundToolWidget.ui <span style="color: \
grey">(937e569)</span></li>
<li>libs/kopageapp/tools/backgroundTool/CMakeLists.txt <span style="color: \
grey">(339c671)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h <span style="color: \
grey">(45a240f)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp <span style="color: \
grey">(69f7649)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.h <span \
style="color: grey">(cb75621)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp <span \
style="color: grey">(b803e79)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp <span \
style="color: grey">(505c3da)</span></li>
<li>libs/kopageapp/widgets/KoPABackgroundFillWidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/kopageapp/widgets/KoPABackgroundFillWidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/main/KoModeBox.cpp <span style="color: grey">(a653216)</span></li>
<li>libs/main/KoModeBoxDocker.cpp <span style="color: grey">(a6969fd)</span></li>
<li>libs/main/KoModeBoxDocker_p.h <span style="color: grey">(f480781)</span></li>
<li>libs/main/KoModeBox_p.h <span style="color: grey">(2d54bf5)</span></li>
<li>libs/widgets/KoFillConfigWidget.h <span style="color: \
grey">(c2d8fca)</span></li>
<li>libs/widgets/KoFillConfigWidget.cpp <span style="color: \
grey">(3948290)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.h <span style="color: \
grey">(8b37d48)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.cpp <span style="color: \
grey">(4f4ead8)</span></li>
<li>plugins/defaultTools/defaulttool/DefaultTool.cpp <span style="color: \
grey">(0e77389)</span></li>
<li>plugins/dockers/CMakeLists.txt <span style="color: grey">(2c041e7)</span></li>
<li>plugins/dockers/Plugin.cpp <span style="color: grey">(9b6c442)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.h <span style="color: \
grey">(06082e4)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.cpp <span style="color: \
grey">(1945a57)</span></li>
<li>plugins/dockers/styledocker/StyleButtonBox.h <span style="color: \
grey">(e2957fa)</span></li>
<li>plugins/dockers/styledocker/StyleButtonBox.cpp <span style="color: \
grey">(291a5af)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.h <span style="color: \
grey">(6daa8f4)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.cpp <span style="color: \
grey">(9f86be9)</span></li>
<li>plugins/dockers/styledocker/StyleDockerFactory.h <span style="color: \
grey">(acd91ac)</span></li>
<li>plugins/dockers/styledocker/StyleDockerFactory.cpp <span style="color: \
grey">(5898610)</span></li>
<li>plugins/dockers/styledocker/StylePreview.h <span style="color: \
grey">(da81351)</span></li>
<li>plugins/dockers/styledocker/StylePreview.cpp <span style="color: \
grey">(e196fe3)</span></li>
<li>plugins/textshape/dialogs/SimpleTableWidget.ui <span style="color: \
grey">(cf9efa0)</span></li>
<li>stage/part/CMakeLists.txt <span style="color: grey">(65b956e)</span></li>
<li>stage/part/KPrPageLayoutWidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrPageLayoutWidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrView.cpp <span style="color: grey">(6ec2402)</span></li>
<li>stage/part/dockers/KPrPageLayoutDocker.h <span style="color: \
grey">(ed7a547)</span></li>
<li>stage/part/dockers/KPrPageLayoutDocker.cpp <span style="color: \
grey">(8348e2c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111747/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic