'Re: Review Request 111960: Patch to support single layered grayscale photoshop documents'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 111960: Patch to support single layered grayscale photoshop documents
From:       "C. Boemann" <cbr () boemann ! dk>
Date:       2013-08-11 8:12:57
Message-ID: 20130811081257.32431.46317 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111960/#review37501
-----------------------------------------------------------

you already have a  ship-it

Such minor issues are not worth making an extra review over

- C. Boemann

On Aug. 11, 2013, 5:22 a.m., Siddharth Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111960/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2013, 5:22 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Patch to support single layered grayscale photoshop documents
> 
> 
> Diffs
> -----
> 
>   psd.cpp 29603b9 
>   psd_image_data.h 2fcbcd1 
>   psd_image_data.cpp 3c08693 
> 
> Diff: http://git.reviewboard.kde.org/r/111960/diff/
> 
> 
> Testing
> -------
> 
> I tested with a grayscale image, it works fine for me
> 
> 
> Thanks,
> 
> Siddharth Sharma
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111960/">http://git.reviewboard.kde.org/r/111960/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you already have a  \
ship-it

Such minor issues are not worth making an extra review over</pre>
 <br />

<p>- C.</p>

<br />
<p>On August 11th, 2013, 5:22 a.m. UTC, Siddharth Sharma wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Siddharth Sharma.</div>

<p style="color: grey;"><i>Updated Aug. 11, 2013, 5:22 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch to support single layered grayscale photoshop documents</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tested with a grayscale image, it works fine for me</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>psd.cpp <span style="color: grey">(29603b9)</span></li>

 <li>psd_image_data.h <span style="color: grey">(2fcbcd1)</span></li>

 <li>psd_image_data.cpp <span style="color: grey">(3c08693)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111960/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 