[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 111960: Patch to support single layered grayscale photoshop documents
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2013-08-09 17:24:05
Message-ID: 20130809172405.21786.60030 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111960/#review37442
-----------------------------------------------------------
Found what I think is a bug (fallthrough in a case) and some minor formatting issues.
krita/plugins/formats/psd/psd.cpp
<http://git.reviewboard.kde.org/r/111960/#comment27696>
missing break?
krita/plugins/formats/psd/psd_image_data.cpp
<http://git.reviewboard.kde.org/r/111960/#comment27697>
Hmm, indent error or can't the reviewboard show this correctly?
krita/plugins/formats/psd/psd_image_data.cpp
<http://git.reviewboard.kde.org/r/111960/#comment27698>
Calligra uses braces in column 1 at the start of a function.
- Inge Wallin
On Aug. 9, 2013, 10:22 a.m., Siddharth Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111960/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 10:22 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Patch to support single layered grayscale photoshop documents
>
>
> Diffs
> -----
>
> kexi/kexiutils/transliteration_table.cpp.orig.bz2 d00dd1d
> krita/plugins/formats/psd/psd.cpp 29603b9
> krita/plugins/formats/psd/psd_image_data.h 2fcbcd1
> krita/plugins/formats/psd/psd_image_data.cpp 3c08693
>
> Diff: http://git.reviewboard.kde.org/r/111960/diff/
>
>
> Testing
> -------
>
> I tested with a grayscale image, it works fine for me
>
>
> Thanks,
>
> Siddharth Sharma
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111960/">http://git.reviewboard.kde.org/r/111960/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Found what I think is a \
bug (fallthrough in a case) and some minor formatting issues.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111960/diff/3/?file=177583#file177583line38" \
style="color: black; font-weight: bold; text-decoration: \
underline;">krita/plugins/formats/psd/psd.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QPair<QString, QString> psd_colormode_to_colormodelid(PSDColorMode colormode, \
quint16 channelDepth)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">38</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">colorSpaceId</span><span class="p">.</span><span class="n">first</span> \
<span class="o">=</span> <span class="n">GrayColorModelID</span><span \
class="p">.</span><span class="n">id</span><span class="p">();</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">missing \
break?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111960/diff/3/?file=177585#file177585line219" \
style="color: black; font-weight: bold; text-decoration: \
underline;">krita/plugins/formats/psd/psd_image_data.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">217</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="nb">true</span><span \
class="p">;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">218</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="k">return</span> <span \
class="nb">true</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, indent \
error or can't the reviewboard show this correctly?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111960/diff/3/?file=177585#file177585line590" \
style="color: black; font-weight: bold; text-decoration: \
underline;">krita/plugins/formats/psd/psd_image_data.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">589</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="kt">bool</span> <span class="n">PSDImageData</span><span \
class="o">::</span><span class="n">readGrayscale</span><span class="p">(</span><span \
class="n">QIODevice</span> <span class="o">*</span><span class="n">io</span><span \
class="p">,</span> <span class="n">KisPaintDeviceSP</span> <span \
class="n">dev</span><span class="p">){</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Calligra \
uses braces in column 1 at the start of a function.</pre> </div>
<br />
<p>- Inge</p>
<br />
<p>On August 9th, 2013, 10:22 a.m. UTC, Siddharth Sharma wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Siddharth Sharma.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2013, 10:22 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch to support single layered grayscale photoshop documents</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tested with a grayscale image, it works fine for me</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/kexiutils/transliteration_table.cpp.orig.bz2 <span style="color: \
grey">(d00dd1d)</span></li>
<li>krita/plugins/formats/psd/psd.cpp <span style="color: \
grey">(29603b9)</span></li>
<li>krita/plugins/formats/psd/psd_image_data.h <span style="color: \
grey">(2fcbcd1)</span></li>
<li>krita/plugins/formats/psd/psd_image_data.cpp <span style="color: \
grey">(3c08693)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111960/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic