[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 110700: Remove unused storage/API from StyleManager
From: "Elvis Stansvik" <elvstone () gmail ! com>
Date: 2013-08-04 12:36:28
Message-ID: 20130804123628.2129.55087 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110700/
-----------------------------------------------------------
(Updated Aug. 4, 2013, 12:36 p.m.)
Status
------
This change has been discarded.
Review request for Calligra, C. Boemann, Gopalakrishna Bhat, Pierre \
Stirnweiss, and Thorsten Zachmann.
Description
-------
In KoStyleManager, nothing is ever added to the d->unusedParagraphStyles \
hash, so I suggest we remove it along with the accompanying API.
I'm guessing it was an unfinished attempt to make ToC/bibliography styles \
not appear at all in the UI until they're used (I mean, not even appear as \
"Unused") ?
The code that used the API were the bibliography and ToC templates, but \
nothing was ever inserted into d->unusedParagraphStyles.
Diffs
-----
libs/kotext/styles/KoStyleManager.h c44ba32
libs/kotext/styles/KoStyleManager.cpp f7b9b5f
libs/textlayout/ToCGenerator.cpp 30df21e
plugins/textshape/dialogs/BibliographyTemplate.h 99ca6c4
plugins/textshape/dialogs/BibliographyTemplate.cpp 4bb2bd0
plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp c93a673
plugins/textshape/dialogs/SimpleTableOfContentsWidget.cpp 48fb88e
plugins/textshape/dialogs/TableOfContentsTemplate.h f98f6f9
plugins/textshape/dialogs/TableOfContentsTemplate.cpp 2bd73e7
Diff: http://git.reviewboard.kde.org/r/110700/diff/
Testing
-------
Tested bibliography functionality before/after the removal. There was no \
change in behavior that I could see.
Thanks,
Elvis Stansvik
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110700/">http://git.reviewboard.kde.org/r/110700/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px \
gray solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This \
change has been discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Calligra, C. Boemann, Gopalakrishna Bhat, Pierre \
Stirnweiss, and Thorsten Zachmann.</div> <div>By Elvis Stansvik.</div>
<p style="color: grey;"><i>Updated Aug. 4, 2013, 12:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In KoStyleManager, nothing is ever added to the \
d->unusedParagraphStyles hash, so I suggest we remove it along with the \
accompanying API.
I'm guessing it was an unfinished attempt to make ToC/bibliography \
styles not appear at all in the UI until they're used (I mean, not even \
appear as "Unused") ?
The code that used the API were the bibliography and ToC templates, but \
nothing was ever inserted into d->unusedParagraphStyles.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested bibliography functionality before/after the removal. \
There was no change in behavior that I could see.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/styles/KoStyleManager.h <span style="color: \
grey">(c44ba32)</span></li>
<li>libs/kotext/styles/KoStyleManager.cpp <span style="color: \
grey">(f7b9b5f)</span></li>
<li>libs/textlayout/ToCGenerator.cpp <span style="color: \
grey">(30df21e)</span></li>
<li>plugins/textshape/dialogs/BibliographyTemplate.h <span style="color: \
grey">(99ca6c4)</span></li>
<li>plugins/textshape/dialogs/BibliographyTemplate.cpp <span style="color: \
grey">(4bb2bd0)</span></li>
<li>plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp <span \
style="color: grey">(c93a673)</span></li>
<li>plugins/textshape/dialogs/SimpleTableOfContentsWidget.cpp <span \
style="color: grey">(48fb88e)</span></li>
<li>plugins/textshape/dialogs/TableOfContentsTemplate.h <span \
style="color: grey">(f98f6f9)</span></li>
<li>plugins/textshape/dialogs/TableOfContentsTemplate.cpp <span \
style="color: grey">(2bd73e7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110700/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic