[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 111044: Implement borders for shapes
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2013-07-30 14:19:47
Message-ID: 20130730141947.13117.80575 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111044/#review36813
-----------------------------------------------------------
Ship it!
Ship It!
- C. Boemann
On July 19, 2013, 6:26 a.m., Inge Wallin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111044/
> -----------------------------------------------------------
>
> (Updated July 19, 2013, 6:26 a.m.)
>
>
> Review request for Calligra, C. Boemann, Boudewijn Rempt, and Thorsten Zachmann.
>
>
> Description
> -------
>
> This patch implements loading, saving and painting of borders for shapes in \
> general. It also implements calls to actually paint borders in particular for the \
> picture shape and text shape.
> At the same time I moved border painting from KWCanvasBase to KoBorder, which I \
> announced some weeks ago that I wanted to do.
> A patch this deep in the libraries should not go in without a run of cstester. I \
> would be glad for help with this since I only have a semi-weak laptop.
>
> Diffs
> -----
>
> libs/flake/KoShape.h fe6cc3f
> libs/flake/KoShape.cpp 6d14a8c
> libs/flake/KoShape_p.h aa6633c
> libs/odf/KoBorder.h bdbf86e
> libs/odf/KoBorder.cpp 58f8e45
> libs/textlayout/FloatingAnchorStrategy.h eb0ff6b
> libs/textlayout/FloatingAnchorStrategy.cpp 465f149
> libs/textlayout/KoTextDocumentLayout.cpp 70f4ccd
> libs/textlayout/KoTextLayoutRootAreaProvider.h d8c7ac3
> libs/textlayout/KoTextShapeData.cpp 1b424b7
> plugins/pictureshape/PictureShape.cpp 976fadd
> plugins/textshape/SimpleRootAreaProvider.h 62534a6
> plugins/textshape/SimpleRootAreaProvider.cpp 63f1898
> plugins/textshape/TextShape.cpp b230f0a
> words/part/KWCanvasBase.cpp 7d12890
> words/part/KWRootAreaProvider.h 45b4870
> words/part/KWRootAreaProvider.cpp fc8660d
>
> Diff: http://git.reviewboard.kde.org/r/111044/diff/
>
>
> Testing
> -------
>
> Tested with all the files with the string "border" in it in the test suite.
>
>
> Thanks,
>
> Inge Wallin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111044/">http://git.reviewboard.kde.org/r/111044/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- C.</p>
<br />
<p>On July 19th, 2013, 6:26 a.m. UTC, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra, C. Boemann, Boudewijn Rempt, and Thorsten \
Zachmann.</div> <div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated July 19, 2013, 6:26 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch implements loading, saving and painting of borders for shapes \
in general. It also implements calls to actually paint borders in particular for the \
picture shape and text shape.
At the same time I moved border painting from KWCanvasBase to KoBorder, which I \
announced some weeks ago that I wanted to do.
A patch this deep in the libraries should not go in without a run of cstester. I \
would be glad for help with this since I only have a semi-weak laptop.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with all the files with the string "border" in it in \
the test suite.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoShape.h <span style="color: grey">(fe6cc3f)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(6d14a8c)</span></li>
<li>libs/flake/KoShape_p.h <span style="color: grey">(aa6633c)</span></li>
<li>libs/odf/KoBorder.h <span style="color: grey">(bdbf86e)</span></li>
<li>libs/odf/KoBorder.cpp <span style="color: grey">(58f8e45)</span></li>
<li>libs/textlayout/FloatingAnchorStrategy.h <span style="color: \
grey">(eb0ff6b)</span></li>
<li>libs/textlayout/FloatingAnchorStrategy.cpp <span style="color: \
grey">(465f149)</span></li>
<li>libs/textlayout/KoTextDocumentLayout.cpp <span style="color: \
grey">(70f4ccd)</span></li>
<li>libs/textlayout/KoTextLayoutRootAreaProvider.h <span style="color: \
grey">(d8c7ac3)</span></li>
<li>libs/textlayout/KoTextShapeData.cpp <span style="color: \
grey">(1b424b7)</span></li>
<li>plugins/pictureshape/PictureShape.cpp <span style="color: \
grey">(976fadd)</span></li>
<li>plugins/textshape/SimpleRootAreaProvider.h <span style="color: \
grey">(62534a6)</span></li>
<li>plugins/textshape/SimpleRootAreaProvider.cpp <span style="color: \
grey">(63f1898)</span></li>
<li>plugins/textshape/TextShape.cpp <span style="color: grey">(b230f0a)</span></li>
<li>words/part/KWCanvasBase.cpp <span style="color: grey">(7d12890)</span></li>
<li>words/part/KWRootAreaProvider.h <span style="color: grey">(45b4870)</span></li>
<li>words/part/KWRootAreaProvider.cpp <span style="color: \
grey">(fc8660d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111044/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic