[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 111321: Solve bug 283164: delete key doesn't delete multiple cells
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2013-07-29 9:05:44
Message-ID: 20130729090544.1889.32028 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111321/#review36720
-----------------------------------------------------------
Ship it!
Ok, enough time waiting for this
- C. Boemann
On June 30, 2013, 2:55 a.m., Inge Wallin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111321/
> -----------------------------------------------------------
>
> (Updated June 30, 2013, 2:55 a.m.)
>
>
> Review request for Calligra and Marijn Kruisselbrink.
>
>
> Description
> -------
>
> This very simple fix seems to solve the bug mentioned in the summary. I have \
> tested a lot with a different types of editing (editing in the cell editor, editing \
> in the cell itself) and I have found no regressions.
>
> Diffs
> -----
>
> sheets/ui/CellToolBase.cpp 55c499e
>
> Diff: http://git.reviewboard.kde.org/r/111321/diff/
>
>
> Testing
> -------
>
> Lots of manual testing.
>
>
> Thanks,
>
> Inge Wallin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111321/">http://git.reviewboard.kde.org/r/111321/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, enough time waiting \
for this</pre> <br />
<p>- C.</p>
<br />
<p>On June 30th, 2013, 2:55 a.m. UTC, Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra and Marijn Kruisselbrink.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated June 30, 2013, 2:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This very simple fix seems to solve the bug mentioned in the summary. I \
have tested a lot with a different types of editing (editing in the cell editor, \
editing in the cell itself) and I have found no regressions.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Lots of manual testing.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sheets/ui/CellToolBase.cpp <span style="color: grey">(55c499e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111321/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic