[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 111615: Wrap KoShapeBackground in QSharedPointer
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2013-07-29 8:46:14
Message-ID: 20130729084614.32012.36231 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111615/#review36715
-----------------------------------------------------------
Ship it!
Ship It!
- C. Boemann
On July 29, 2013, 8:33 a.m., Boudewijn Rempt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111615/
> -----------------------------------------------------------
>
> (Updated July 29, 2013, 8:33 a.m.)
>
>
> Review request for Calligra and Jan Hambrecht.
>
>
> Description
> -------
>
> This patch wraps KoShapeBackground in a QPointer instead of doing manual \
> refcounting. Bug 321714 shows, imo, that the manual refcounting is fragile and \
> sometimes breaks. I don't remember why we weren't supposed to use QPointer (other \
> than that it gets a little ugly with subclassing), but it seems a good fit here.
> There are other classes that do manual refcounting, and I think those should be \
> converted, too -- but in another patch.
>
> This addresses bug 321714.
> http://bugs.kde.org/show_bug.cgi?id=321714
>
>
> Diffs
> -----
>
> karbon/plugins/tools/KarbonPatternEditStrategy.h b66b78d
> karbon/plugins/tools/KarbonGradientTool.cpp 79d4fde
> karbon/plugins/tools/KarbonGradientEditStrategy.cpp 0bf30d1
> karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp 2517164
> karbon/plugins/tools/CalligraphyTool/KarbonCalligraphicShape.cpp e9921b8
> filters/karbon/wmf/WmfExport.cpp bf0aa85
> karbon/plugins/tools/KarbonPatternEditStrategy.cpp 1b4e0c0
> karbon/plugins/tools/KarbonPatternTool.cpp 5c0ac36
> karbon/ui/KarbonView.cpp 7e54ede
> karbon/ui/widgets/KarbonPaletteBarWidget.cpp 5898872
> karbon/ui/widgets/KarbonSmallStylePreview.cpp f6d76cf
> krita/ui/flake/kis_shape_selection_model.cpp 4c59ad0
> krita/ui/tool/kis_tool_shape.cc aab57dd
> krita/ui/widgets/kis_floating_message.cpp d53e133
> libs/flake/KoConnectionShape.cpp 09af2dd
> libs/flake/KoOdfWorkaround.h 5faa268
> libs/flake/KoOdfWorkaround.cpp 8a5b593
> libs/flake/KoShape.h fe6cc3f
> libs/flake/KoShape.cpp 6d14a8c
> libs/flake/KoShapeBackground.h 33253a8
> libs/flake/KoShapeBackground.cpp 9d6b29e
> libs/flake/KoShapeBackground_p.h 92acc36
> libs/flake/KoShape_p.h aa6633c
> libs/flake/commands/KoShapeBackgroundCommand.h bee749d
> libs/flake/commands/KoShapeBackgroundCommand.cpp f4acd2c
> libs/flake/svg/SvgParser.cpp 6898ffc
> libs/flake/svg/SvgStyleWriter.h 1327e27
> libs/flake/svg/SvgStyleWriter.cpp 8be614a
> libs/flake/tests/TestShapeBackgroundCommand.cpp e0b69ba
> libs/kopageapp/KoPAPageBase.cpp d56c7fe
> libs/kopageapp/KoPAView.cpp 58b4940
> libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp c0c5afa
> libs/kotext/styles/KoListLevelProperties.cpp 0f99e04
> libs/widgets/KoFillConfigWidget.h 4d71718
> libs/widgets/KoFillConfigWidget.cpp d086eb7
> libs/widgets/KoResourcePopupAction.h 91031e4
> libs/widgets/KoResourcePopupAction.cpp 2d873ca
> plugins/artistictextshape/ArtisticTextShapeFactory.cpp 37552b8
> plugins/chartshape/ChartShape.cpp 55d5eb8
> plugins/dockers/styledocker/StrokeFillWidget.h 212eaa0
> plugins/dockers/styledocker/StrokeFillWidget.cpp d67cabf
> plugins/dockers/styledocker/StyleDocker.h 2408188
> plugins/dockers/styledocker/StyleDocker.cpp 052b2ee
> plugins/dockers/styledocker/StylePreview.h db33b3f
> plugins/dockers/styledocker/StylePreview.cpp 39f8b42
> plugins/pathshapes/ellipse/EllipseShapeFactory.cpp 0a4c68d
> plugins/pathshapes/enhancedpath/EnhancedPathParameter.cpp 29d2ad2
> plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp f1e3974
> plugins/pathshapes/rectangle/RectangleShapeFactory.cpp 689abfe
> plugins/pathshapes/star/StarShapeFactory.cpp dd34c06
> plugins/textshape/TextShape.cpp b230f0a
> stage/part/KPrEndOfSlideShowPage.cpp 061aa58
> words/part/KWPageStyle.h b2eeb43
> words/part/KWPageStyle.cpp f53dab5
> words/part/KWPageStyle_p.h 356af3a
> words/part/frames/KWFrameLayout.cpp 6b2a31e
>
> Diff: http://git.reviewboard.kde.org/r/111615/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Boudewijn Rempt
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111615/">http://git.reviewboard.kde.org/r/111615/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- C.</p>
<br />
<p>On July 29th, 2013, 8:33 a.m. UTC, Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra and Jan Hambrecht.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated July 29, 2013, 8:33 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch wraps KoShapeBackground in a QPointer instead of doing manual \
refcounting. Bug 321714 shows, imo, that the manual refcounting is fragile and \
sometimes breaks. I don't remember why we weren't supposed to use QPointer \
(other than that it gets a little ugly with subclassing), but it seems a good fit \
here.
There are other classes that do manual refcounting, and I think those should be \
converted, too -- but in another patch.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=321714">321714</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>karbon/plugins/tools/KarbonPatternEditStrategy.h <span style="color: \
grey">(b66b78d)</span></li>
<li>karbon/plugins/tools/KarbonGradientTool.cpp <span style="color: \
grey">(79d4fde)</span></li>
<li>karbon/plugins/tools/KarbonGradientEditStrategy.cpp <span style="color: \
grey">(0bf30d1)</span></li>
<li>karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp <span \
style="color: grey">(2517164)</span></li>
<li>karbon/plugins/tools/CalligraphyTool/KarbonCalligraphicShape.cpp <span \
style="color: grey">(e9921b8)</span></li>
<li>filters/karbon/wmf/WmfExport.cpp <span style="color: grey">(bf0aa85)</span></li>
<li>karbon/plugins/tools/KarbonPatternEditStrategy.cpp <span style="color: \
grey">(1b4e0c0)</span></li>
<li>karbon/plugins/tools/KarbonPatternTool.cpp <span style="color: \
grey">(5c0ac36)</span></li>
<li>karbon/ui/KarbonView.cpp <span style="color: grey">(7e54ede)</span></li>
<li>karbon/ui/widgets/KarbonPaletteBarWidget.cpp <span style="color: \
grey">(5898872)</span></li>
<li>karbon/ui/widgets/KarbonSmallStylePreview.cpp <span style="color: \
grey">(f6d76cf)</span></li>
<li>krita/ui/flake/kis_shape_selection_model.cpp <span style="color: \
grey">(4c59ad0)</span></li>
<li>krita/ui/tool/kis_tool_shape.cc <span style="color: grey">(aab57dd)</span></li>
<li>krita/ui/widgets/kis_floating_message.cpp <span style="color: \
grey">(d53e133)</span></li>
<li>libs/flake/KoConnectionShape.cpp <span style="color: grey">(09af2dd)</span></li>
<li>libs/flake/KoOdfWorkaround.h <span style="color: grey">(5faa268)</span></li>
<li>libs/flake/KoOdfWorkaround.cpp <span style="color: grey">(8a5b593)</span></li>
<li>libs/flake/KoShape.h <span style="color: grey">(fe6cc3f)</span></li>
<li>libs/flake/KoShape.cpp <span style="color: grey">(6d14a8c)</span></li>
<li>libs/flake/KoShapeBackground.h <span style="color: grey">(33253a8)</span></li>
<li>libs/flake/KoShapeBackground.cpp <span style="color: grey">(9d6b29e)</span></li>
<li>libs/flake/KoShapeBackground_p.h <span style="color: grey">(92acc36)</span></li>
<li>libs/flake/KoShape_p.h <span style="color: grey">(aa6633c)</span></li>
<li>libs/flake/commands/KoShapeBackgroundCommand.h <span style="color: \
grey">(bee749d)</span></li>
<li>libs/flake/commands/KoShapeBackgroundCommand.cpp <span style="color: \
grey">(f4acd2c)</span></li>
<li>libs/flake/svg/SvgParser.cpp <span style="color: grey">(6898ffc)</span></li>
<li>libs/flake/svg/SvgStyleWriter.h <span style="color: grey">(1327e27)</span></li>
<li>libs/flake/svg/SvgStyleWriter.cpp <span style="color: \
grey">(8be614a)</span></li>
<li>libs/flake/tests/TestShapeBackgroundCommand.cpp <span style="color: \
grey">(e0b69ba)</span></li>
<li>libs/kopageapp/KoPAPageBase.cpp <span style="color: grey">(d56c7fe)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(58b4940)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp <span \
style="color: grey">(c0c5afa)</span></li>
<li>libs/kotext/styles/KoListLevelProperties.cpp <span style="color: \
grey">(0f99e04)</span></li>
<li>libs/widgets/KoFillConfigWidget.h <span style="color: \
grey">(4d71718)</span></li>
<li>libs/widgets/KoFillConfigWidget.cpp <span style="color: \
grey">(d086eb7)</span></li>
<li>libs/widgets/KoResourcePopupAction.h <span style="color: \
grey">(91031e4)</span></li>
<li>libs/widgets/KoResourcePopupAction.cpp <span style="color: \
grey">(2d873ca)</span></li>
<li>plugins/artistictextshape/ArtisticTextShapeFactory.cpp <span style="color: \
grey">(37552b8)</span></li>
<li>plugins/chartshape/ChartShape.cpp <span style="color: \
grey">(55d5eb8)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.h <span style="color: \
grey">(212eaa0)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.cpp <span style="color: \
grey">(d67cabf)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.h <span style="color: \
grey">(2408188)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.cpp <span style="color: \
grey">(052b2ee)</span></li>
<li>plugins/dockers/styledocker/StylePreview.h <span style="color: \
grey">(db33b3f)</span></li>
<li>plugins/dockers/styledocker/StylePreview.cpp <span style="color: \
grey">(39f8b42)</span></li>
<li>plugins/pathshapes/ellipse/EllipseShapeFactory.cpp <span style="color: \
grey">(0a4c68d)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathParameter.cpp <span style="color: \
grey">(29d2ad2)</span></li>
<li>plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp <span style="color: \
grey">(f1e3974)</span></li>
<li>plugins/pathshapes/rectangle/RectangleShapeFactory.cpp <span style="color: \
grey">(689abfe)</span></li>
<li>plugins/pathshapes/star/StarShapeFactory.cpp <span style="color: \
grey">(dd34c06)</span></li>
<li>plugins/textshape/TextShape.cpp <span style="color: grey">(b230f0a)</span></li>
<li>stage/part/KPrEndOfSlideShowPage.cpp <span style="color: \
grey">(061aa58)</span></li>
<li>words/part/KWPageStyle.h <span style="color: grey">(b2eeb43)</span></li>
<li>words/part/KWPageStyle.cpp <span style="color: grey">(f53dab5)</span></li>
<li>words/part/KWPageStyle_p.h <span style="color: grey">(356af3a)</span></li>
<li>words/part/frames/KWFrameLayout.cpp <span style="color: \
grey">(6b2a31e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111615/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic