[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 111305: "ko"-prefix installed, but so far namespace-less libs: msooxml, odfreader
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2013-06-29 7:45:52
Message-ID: 20130629074552.1438.10858 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111305/#review35267
-----------------------------------------------------------
as for the subdirs i think the should be without prefix. the prefix is something we \
have to endure with librarynames.
- C. Boemann
On June 29, 2013, 12:40 a.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111305/
> -----------------------------------------------------------
>
> (Updated June 29, 2013, 12:40 a.m.)
>
>
> Review request for Calligra, C. Boemann and Inge Wallin.
>
>
> Description
> -------
>
> The installed libs "libmsooxml", "libodfreader", "libvectorimage", "libtextlayout" \
> ideally also get a prefix. Attached patch does that.
> It does not touch "pigment", "flake", "basicflakes", as these have unique enough \
> names IMHO, so no clash can be expected. Also does not touch the internal static \
> libs which do not (yet?) get installed: mso, writerperfect. libRtfReader would also \
> be a candidate, but it is unclear to me whether we have the original clone of that \
> lib in our repo, and the other one (on sf.net) should be removed. So ignoring that \
> one here.
> Open questions for me:
> * "kundo2", "kformdesigner", "kformula" just use a k as prefix, so might clash with \
> libs sometimes in kdelibs/kdeplatform? So better instead prefix with ko, not just \
> k?
> * also rename the subdirs in the repo? libs/ currently has a mix also without this \
> patch: "main", "odf" and "rdf" are without ko, the other have the prefix in the \
> subdir name. What would you think about a follow-up patch which adds consistency \
> there? Will write an email to the mailinglist about that to query what people \
> think, after this patch has been handled (discarded/committed).
>
> Diffs
> -----
>
> CMakeLists.txt 53fa5bd
> filters/karbon/wmf/CMakeLists.txt bc278f1
> filters/libmsooxml/CMakeLists.txt a9827cb
> filters/libodfreader/CMakeLists.txt 71571f8
> filters/sheets/excel/export/CMakeLists.txt efd8e1a
> filters/sheets/excel/import/CMakeLists.txt 06c6f9f
> filters/sheets/xlsx/CMakeLists.txt 1a3ca07
> filters/stage/pptx/CMakeLists.txt ea87a0e
> filters/words/ascii/CMakeLists.txt e9846f9
> filters/words/docx/import/CMakeLists.txt 32472dc
> filters/words/epub/CMakeLists.txt 8954e75
> filters/words/msword-odf/CMakeLists.txt 7479b5e
> libs/kopageapp/CMakeLists.txt 35db53f
> libs/main/CMakeLists.txt d74851b
> libs/textlayout/CMakeLists.txt 3d9edfe
> libs/textlayout/tests/CMakeLists.txt 71dc053
> libs/vectorimage/CMakeLists.txt 2c25ce8
> plugins/chartshape/CMakeLists.txt 1a7fbe3
> plugins/commentshape/CMakeLists.txt bf90d37
> plugins/textediting/spellcheck/CMakeLists.txt 0dec50e
> plugins/textshape/CMakeLists.txt 322f93e
> plugins/variables/CMakeLists.txt 6e47086
> plugins/vectorshape/CMakeLists.txt 739b9ba
> stage/part/CMakeLists.txt 6eaf356
> stage/plugins/variable/CMakeLists.txt 0893a76
> words/part/CMakeLists.txt 437f443
>
> Diff: http://git.reviewboard.kde.org/r/111305/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111305/">http://git.reviewboard.kde.org/r/111305/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">as for the subdirs i \
think the should be without prefix. the prefix is something we have to endure with \
librarynames.</pre> <br />
<p>- C.</p>
<br />
<p>On June 29th, 2013, 12:40 a.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra, C. Boemann and Inge Wallin.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated June 29, 2013, 12:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The installed libs "libmsooxml", "libodfreader", \
"libvectorimage", "libtextlayout" ideally also get a prefix. \
Attached patch does that.
It does not touch "pigment", "flake", "basicflakes", as \
these have unique enough names IMHO, so no clash can be expected. Also does not touch \
the internal static libs which do not (yet?) get installed: mso, writerperfect. \
libRtfReader would also be a candidate, but it is unclear to me whether we have the \
original clone of that lib in our repo, and the other one (on sf.net) should be \
removed. So ignoring that one here.
Open questions for me:
* "kundo2", "kformdesigner", "kformula" just use a k as \
prefix, so might clash with libs sometimes in kdelibs/kdeplatform? So better instead \
prefix with ko, not just k?
* also rename the subdirs in the repo? libs/ currently has a mix also without this \
patch: "main", "odf" and "rdf" are without ko, the \
other have the prefix in the subdir name. What would you think about a follow-up \
patch which adds consistency there? Will write an email to the mailinglist about that \
to query what people think, after this patch has been handled \
(discarded/committed).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(53fa5bd)</span></li>
<li>filters/karbon/wmf/CMakeLists.txt <span style="color: \
grey">(bc278f1)</span></li>
<li>filters/libmsooxml/CMakeLists.txt <span style="color: \
grey">(a9827cb)</span></li>
<li>filters/libodfreader/CMakeLists.txt <span style="color: \
grey">(71571f8)</span></li>
<li>filters/sheets/excel/export/CMakeLists.txt <span style="color: \
grey">(efd8e1a)</span></li>
<li>filters/sheets/excel/import/CMakeLists.txt <span style="color: \
grey">(06c6f9f)</span></li>
<li>filters/sheets/xlsx/CMakeLists.txt <span style="color: \
grey">(1a3ca07)</span></li>
<li>filters/stage/pptx/CMakeLists.txt <span style="color: \
grey">(ea87a0e)</span></li>
<li>filters/words/ascii/CMakeLists.txt <span style="color: \
grey">(e9846f9)</span></li>
<li>filters/words/docx/import/CMakeLists.txt <span style="color: \
grey">(32472dc)</span></li>
<li>filters/words/epub/CMakeLists.txt <span style="color: \
grey">(8954e75)</span></li>
<li>filters/words/msword-odf/CMakeLists.txt <span style="color: \
grey">(7479b5e)</span></li>
<li>libs/kopageapp/CMakeLists.txt <span style="color: grey">(35db53f)</span></li>
<li>libs/main/CMakeLists.txt <span style="color: grey">(d74851b)</span></li>
<li>libs/textlayout/CMakeLists.txt <span style="color: grey">(3d9edfe)</span></li>
<li>libs/textlayout/tests/CMakeLists.txt <span style="color: \
grey">(71dc053)</span></li>
<li>libs/vectorimage/CMakeLists.txt <span style="color: grey">(2c25ce8)</span></li>
<li>plugins/chartshape/CMakeLists.txt <span style="color: \
grey">(1a7fbe3)</span></li>
<li>plugins/commentshape/CMakeLists.txt <span style="color: \
grey">(bf90d37)</span></li>
<li>plugins/textediting/spellcheck/CMakeLists.txt <span style="color: \
grey">(0dec50e)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(322f93e)</span></li>
<li>plugins/variables/CMakeLists.txt <span style="color: grey">(6e47086)</span></li>
<li>plugins/vectorshape/CMakeLists.txt <span style="color: \
grey">(739b9ba)</span></li>
<li>stage/part/CMakeLists.txt <span style="color: grey">(6eaf356)</span></li>
<li>stage/plugins/variable/CMakeLists.txt <span style="color: \
grey">(0893a76)</span></li>
<li>words/part/CMakeLists.txt <span style="color: grey">(437f443)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111305/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic