[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 111147: Rename KoCanvasResourceManager::resourceChanged
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2013-06-20 9:20:59
Message-ID: 20130620092059.23183.61367 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111147/#review34739
-----------------------------------------------------------
Ship it!
Ship It!
- C. Boemann
On June 20, 2013, 8:53 a.m., Boudewijn Rempt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111147/
> -----------------------------------------------------------
>
> (Updated June 20, 2013, 8:53 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> We have a bunch of signals all called "resourceChanged". This patch renames \
> KoCanvasResourceManager::resourceChanged to \
> KoCanvasResourceManager::canvasResourceChanged, to make it easier to grep and find \
> all places where we connect to that signal.
> Plan::Project::resourceChanged
> KoAbstractResourceServerAdapter::resourceChanged
> KoDocumentResourceManager::resourceChanged
>
> are the other places (that I know of).
>
>
> Diffs
> -----
>
> karbon/ui/KarbonZoomController.h 8a82f96
> karbon/ui/KarbonZoomController.cpp 0b82f50
> krita/image/kis_default_bounds.h d51124b
> krita/image/kis_layer.cc 96b7216
> krita/image/kis_paint_device.cc 4b1f6c3
> krita/image/kis_paint_layer.cc 4494309
> krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_base.h \
> ca4e759 krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_base.cpp \
> 774a30e krita/plugins/extensions/dockers/advancedcolorselector/kis_minimal_shade_selector.h \
> 0e996dd krita/plugins/extensions/dockers/advancedcolorselector/kis_minimal_shade_selector.cpp \
> 6d88766 krita/plugins/extensions/dockers/advancedcolorselector/kis_my_paint_shade_selector.h \
> d6b65d8 krita/plugins/extensions/dockers/advancedcolorselector/kis_my_paint_shade_selector.cpp \
> 7401846 krita/plugins/extensions/dockers/artisticcolorselector/artisticcolorselector_dock.h \
> 8fbe831 krita/plugins/extensions/dockers/artisticcolorselector/artisticcolorselector_dock.cpp \
> 0376183 krita/plugins/extensions/dockers/digitalmixer/digitalmixer_dock.h 11d9ff4
> krita/plugins/extensions/dockers/digitalmixer/digitalmixer_dock.cc f9466f4
> krita/plugins/extensions/dockers/smallcolorselector/smallcolorselector_dock.h \
> b0badb6 krita/plugins/extensions/dockers/smallcolorselector/smallcolorselector_dock.cc \
> 9965225 krita/plugins/tools/tool_crop/kis_tool_crop.h 7e835d1
> krita/plugins/tools/tool_crop/kis_tool_crop.cc 7e49d5d
> krita/ui/kis_canvas_resource_provider.h 61a0ec8
> krita/ui/kis_canvas_resource_provider.cpp a328ab1
> krita/ui/tool/kis_tool.h 565a60f
> krita/ui/tool/kis_tool.cc 511221c
> krita/ui/tool/kis_tool_freehand_helper.cpp 03c28fc
> krita/ui/tool/kis_tool_paint.h d2174b8
> krita/ui/tool/kis_tool_paint.cc ac5ae96
> krita/ui/widgets/kis_filter_selector_widget.cc 2dbad35
> krita/ui/widgets/kis_scratch_pad.cpp aa62626
> libs/flake/KoCanvasResourceManager.h d396a58
> libs/flake/KoCanvasResourceManager.cpp 1a91afa
> libs/flake/KoToolBase.h 65777d1
> libs/flake/KoToolBase.cpp c35e076
> libs/flake/KoToolBase_p.h 624fa86
> libs/flake/tests/TestResourceManager.cpp bac9a3f
> libs/kotext/KoFind.h 4b16355
> libs/kotext/KoFind.cpp 0ec57f3
> libs/main/KoRulerController.cpp 26a4cd7
> libs/widgets/KoStrokeConfigWidget.h 7eec2a4
> libs/widgets/KoStrokeConfigWidget.cpp 105e3f7
> plugins/defaultTools/defaulttool/DefaultTool.h 18aac59
> plugins/defaultTools/defaulttool/DefaultTool.cpp 6a19185
> plugins/defaultTools/defaulttool/DefaultToolTransformWidget.cpp a5e8069
> plugins/defaultTools/defaulttool/DefaultToolWidget.cpp 0e5eb1f
> plugins/defaultTools/guidestool/GuidesTool.h 0f9afec
> plugins/defaultTools/guidestool/GuidesTool.cpp 6058866
> plugins/dockers/shapeproperties/ShapePropertiesDocker.h 4f422b2
> plugins/dockers/shapeproperties/ShapePropertiesDocker.cpp 507fa89
> plugins/dockers/styledocker/StyleDocker.h 13cf77f
> plugins/dockers/styledocker/StyleDocker.cpp ffec9c4
> plugins/textshape/TextTool.h b5ad2e0
> plugins/textshape/TextTool.cpp 37ba52e
> words/part/KWStatusBar.h 1644f27
> words/part/KWStatusBar.cpp 34cd834
> words/part/dockers/KWRdfDocker.h 5d253b7
> words/part/dockers/KWRdfDocker.cpp 84e63d7
>
> Diff: http://git.reviewboard.kde.org/r/111147/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Boudewijn Rempt
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111147/">http://git.reviewboard.kde.org/r/111147/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- C.</p>
<br />
<p>On June 20th, 2013, 8:53 a.m. UTC, Boudewijn Rempt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Boudewijn Rempt.</div>
<p style="color: grey;"><i>Updated June 20, 2013, 8:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We have a bunch of signals all called "resourceChanged". This \
patch renames KoCanvasResourceManager::resourceChanged to \
KoCanvasResourceManager::canvasResourceChanged, to make it easier to grep and find \
all places where we connect to that signal.
Plan::Project::resourceChanged
KoAbstractResourceServerAdapter::resourceChanged
KoDocumentResourceManager::resourceChanged
are the other places (that I know of).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>karbon/ui/KarbonZoomController.h <span style="color: grey">(8a82f96)</span></li>
<li>karbon/ui/KarbonZoomController.cpp <span style="color: \
grey">(0b82f50)</span></li>
<li>krita/image/kis_default_bounds.h <span style="color: grey">(d51124b)</span></li>
<li>krita/image/kis_layer.cc <span style="color: grey">(96b7216)</span></li>
<li>krita/image/kis_paint_device.cc <span style="color: grey">(4b1f6c3)</span></li>
<li>krita/image/kis_paint_layer.cc <span style="color: grey">(4494309)</span></li>
<li>krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_base.h \
<span style="color: grey">(ca4e759)</span></li>
<li>krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_base.cpp \
<span style="color: grey">(774a30e)</span></li>
<li>krita/plugins/extensions/dockers/advancedcolorselector/kis_minimal_shade_selector.h \
<span style="color: grey">(0e996dd)</span></li>
<li>krita/plugins/extensions/dockers/advancedcolorselector/kis_minimal_shade_selector.cpp \
<span style="color: grey">(6d88766)</span></li>
<li>krita/plugins/extensions/dockers/advancedcolorselector/kis_my_paint_shade_selector.h \
<span style="color: grey">(d6b65d8)</span></li>
<li>krita/plugins/extensions/dockers/advancedcolorselector/kis_my_paint_shade_selector.cpp \
<span style="color: grey">(7401846)</span></li>
<li>krita/plugins/extensions/dockers/artisticcolorselector/artisticcolorselector_dock.h \
<span style="color: grey">(8fbe831)</span></li>
<li>krita/plugins/extensions/dockers/artisticcolorselector/artisticcolorselector_dock.cpp \
<span style="color: grey">(0376183)</span></li>
<li>krita/plugins/extensions/dockers/digitalmixer/digitalmixer_dock.h <span \
style="color: grey">(11d9ff4)</span></li>
<li>krita/plugins/extensions/dockers/digitalmixer/digitalmixer_dock.cc <span \
style="color: grey">(f9466f4)</span></li>
<li>krita/plugins/extensions/dockers/smallcolorselector/smallcolorselector_dock.h \
<span style="color: grey">(b0badb6)</span></li>
<li>krita/plugins/extensions/dockers/smallcolorselector/smallcolorselector_dock.cc \
<span style="color: grey">(9965225)</span></li>
<li>krita/plugins/tools/tool_crop/kis_tool_crop.h <span style="color: \
grey">(7e835d1)</span></li>
<li>krita/plugins/tools/tool_crop/kis_tool_crop.cc <span style="color: \
grey">(7e49d5d)</span></li>
<li>krita/ui/kis_canvas_resource_provider.h <span style="color: \
grey">(61a0ec8)</span></li>
<li>krita/ui/kis_canvas_resource_provider.cpp <span style="color: \
grey">(a328ab1)</span></li>
<li>krita/ui/tool/kis_tool.h <span style="color: grey">(565a60f)</span></li>
<li>krita/ui/tool/kis_tool.cc <span style="color: grey">(511221c)</span></li>
<li>krita/ui/tool/kis_tool_freehand_helper.cpp <span style="color: \
grey">(03c28fc)</span></li>
<li>krita/ui/tool/kis_tool_paint.h <span style="color: grey">(d2174b8)</span></li>
<li>krita/ui/tool/kis_tool_paint.cc <span style="color: grey">(ac5ae96)</span></li>
<li>krita/ui/widgets/kis_filter_selector_widget.cc <span style="color: \
grey">(2dbad35)</span></li>
<li>krita/ui/widgets/kis_scratch_pad.cpp <span style="color: \
grey">(aa62626)</span></li>
<li>libs/flake/KoCanvasResourceManager.h <span style="color: \
grey">(d396a58)</span></li>
<li>libs/flake/KoCanvasResourceManager.cpp <span style="color: \
grey">(1a91afa)</span></li>
<li>libs/flake/KoToolBase.h <span style="color: grey">(65777d1)</span></li>
<li>libs/flake/KoToolBase.cpp <span style="color: grey">(c35e076)</span></li>
<li>libs/flake/KoToolBase_p.h <span style="color: grey">(624fa86)</span></li>
<li>libs/flake/tests/TestResourceManager.cpp <span style="color: \
grey">(bac9a3f)</span></li>
<li>libs/kotext/KoFind.h <span style="color: grey">(4b16355)</span></li>
<li>libs/kotext/KoFind.cpp <span style="color: grey">(0ec57f3)</span></li>
<li>libs/main/KoRulerController.cpp <span style="color: grey">(26a4cd7)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.h <span style="color: \
grey">(7eec2a4)</span></li>
<li>libs/widgets/KoStrokeConfigWidget.cpp <span style="color: \
grey">(105e3f7)</span></li>
<li>plugins/defaultTools/defaulttool/DefaultTool.h <span style="color: \
grey">(18aac59)</span></li>
<li>plugins/defaultTools/defaulttool/DefaultTool.cpp <span style="color: \
grey">(6a19185)</span></li>
<li>plugins/defaultTools/defaulttool/DefaultToolTransformWidget.cpp <span \
style="color: grey">(a5e8069)</span></li>
<li>plugins/defaultTools/defaulttool/DefaultToolWidget.cpp <span style="color: \
grey">(0e5eb1f)</span></li>
<li>plugins/defaultTools/guidestool/GuidesTool.h <span style="color: \
grey">(0f9afec)</span></li>
<li>plugins/defaultTools/guidestool/GuidesTool.cpp <span style="color: \
grey">(6058866)</span></li>
<li>plugins/dockers/shapeproperties/ShapePropertiesDocker.h <span style="color: \
grey">(4f422b2)</span></li>
<li>plugins/dockers/shapeproperties/ShapePropertiesDocker.cpp <span style="color: \
grey">(507fa89)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.h <span style="color: \
grey">(13cf77f)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.cpp <span style="color: \
grey">(ffec9c4)</span></li>
<li>plugins/textshape/TextTool.h <span style="color: grey">(b5ad2e0)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(37ba52e)</span></li>
<li>words/part/KWStatusBar.h <span style="color: grey">(1644f27)</span></li>
<li>words/part/KWStatusBar.cpp <span style="color: grey">(34cd834)</span></li>
<li>words/part/dockers/KWRdfDocker.h <span style="color: grey">(5d253b7)</span></li>
<li>words/part/dockers/KWRdfDocker.cpp <span style="color: \
grey">(84e63d7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111147/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic