[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 110949: Renaming "Page Borders" to "Page Markers" in Calligra Sheets
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2013-06-11 6:47:57
Message-ID: 20130611064757.6748.17056 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110949/#review34104
-----------------------------------------------------------
I think "Page Outline" would be a better name then (you should be able to change that \
by replacing in the diff file and applying the diff to a clean tree)
- C. Boemann
On June 11, 2013, 5:24 a.m., Jigar Raisinghani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110949/
> -----------------------------------------------------------
>
> (Updated June 11, 2013, 5:24 a.m.)
>
>
> Review request for Calligra, Inge Wallin and Marijn Kruisselbrink.
>
>
> Description
> -------
>
> Currently, Calligra Sheets has a feature called Page Borders which displays the \
> boundaries for pages. This is useful to get an idea of where a page ends and new \
> page begins. But these are NOT actual Borders/Boundaries but just the Markers. Page \
> Borders would mean ACTUAL Borders(customizable) and not just markers. So, Renaming \
> "Page Borders" to "Page Markers"
>
> Diffs
> -----
>
> filters/sheets/excel/import/ExcelImport.cpp 53decbd
> filters/sheets/excel/import/excelimporttoods.cc 6f6c574
> filters/sheets/libkspreadexport/KSpreadLeader.cc 9880b11
> sheets/ApplicationSettings.h c3828f2
> sheets/ApplicationSettings.cpp c779129
> sheets/Sheet.h 7090a8c
> sheets/Sheet.cpp 7d3548a
> sheets/commands/PageBreakCommand.cpp 7f0f49a
> sheets/commands/SheetCommands.h 68a30e1
> sheets/commands/SheetCommands.cpp b501c06
> sheets/functions/TODO/settings.xml f2fd91a
> sheets/interfaces/SheetAdaptor.h cf0ec69
> sheets/interfaces/SheetAdaptor.cpp c4a51ce
> sheets/part/View.h 4be69c4
> sheets/part/View.cpp 131e645
> sheets/part/dialogs/InterfaceOptionsWidget.ui 0afc27c
> sheets/part/dialogs/PreferenceDialog.cpp 721ce25
> sheets/part/dialogs/SheetPropertiesDialog.h 2330ae6
> sheets/part/dialogs/SheetPropertiesDialog.cpp 858fdb3
> sheets/part/dialogs/SheetPropertiesWidget.ui 1d41fc7
> sheets/sheets.kcfg c0ec520
> sheets/sheets.rc 6256df6
> sheets/sheets_readonly.rc 1e9e248
> sheets/ui/CellView.cpp d2b6e26
>
> Diff: http://git.reviewboard.kde.org/r/110949/diff/
>
>
> Testing
> -------
>
> Yes, Page Borders renamed to Page Markers successfully.
>
>
> Thanks,
>
> Jigar Raisinghani
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110949/">http://git.reviewboard.kde.org/r/110949/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think "Page \
Outline" would be a better name then (you should be able to change that by \
replacing in the diff file and applying the diff to a clean tree)</pre> <br />
<p>- C.</p>
<br />
<p>On June 11th, 2013, 5:24 a.m. UTC, Jigar Raisinghani wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra, Inge Wallin and Marijn Kruisselbrink.</div>
<div>By Jigar Raisinghani.</div>
<p style="color: grey;"><i>Updated June 11, 2013, 5:24 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, Calligra Sheets has a feature called Page Borders which \
displays the boundaries for pages. This is useful to get an idea of where a page ends \
and new page begins. But these are NOT actual Borders/Boundaries but just the \
Markers. Page Borders would mean ACTUAL Borders(customizable) and not just markers. \
So, Renaming "Page Borders" to "Page Markers" </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, Page Borders renamed to Page Markers successfully.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/sheets/excel/import/ExcelImport.cpp <span style="color: \
grey">(53decbd)</span></li>
<li>filters/sheets/excel/import/excelimporttoods.cc <span style="color: \
grey">(6f6c574)</span></li>
<li>filters/sheets/libkspreadexport/KSpreadLeader.cc <span style="color: \
grey">(9880b11)</span></li>
<li>sheets/ApplicationSettings.h <span style="color: grey">(c3828f2)</span></li>
<li>sheets/ApplicationSettings.cpp <span style="color: grey">(c779129)</span></li>
<li>sheets/Sheet.h <span style="color: grey">(7090a8c)</span></li>
<li>sheets/Sheet.cpp <span style="color: grey">(7d3548a)</span></li>
<li>sheets/commands/PageBreakCommand.cpp <span style="color: \
grey">(7f0f49a)</span></li>
<li>sheets/commands/SheetCommands.h <span style="color: grey">(68a30e1)</span></li>
<li>sheets/commands/SheetCommands.cpp <span style="color: \
grey">(b501c06)</span></li>
<li>sheets/functions/TODO/settings.xml <span style="color: \
grey">(f2fd91a)</span></li>
<li>sheets/interfaces/SheetAdaptor.h <span style="color: grey">(cf0ec69)</span></li>
<li>sheets/interfaces/SheetAdaptor.cpp <span style="color: \
grey">(c4a51ce)</span></li>
<li>sheets/part/View.h <span style="color: grey">(4be69c4)</span></li>
<li>sheets/part/View.cpp <span style="color: grey">(131e645)</span></li>
<li>sheets/part/dialogs/InterfaceOptionsWidget.ui <span style="color: \
grey">(0afc27c)</span></li>
<li>sheets/part/dialogs/PreferenceDialog.cpp <span style="color: \
grey">(721ce25)</span></li>
<li>sheets/part/dialogs/SheetPropertiesDialog.h <span style="color: \
grey">(2330ae6)</span></li>
<li>sheets/part/dialogs/SheetPropertiesDialog.cpp <span style="color: \
grey">(858fdb3)</span></li>
<li>sheets/part/dialogs/SheetPropertiesWidget.ui <span style="color: \
grey">(1d41fc7)</span></li>
<li>sheets/sheets.kcfg <span style="color: grey">(c0ec520)</span></li>
<li>sheets/sheets.rc <span style="color: grey">(6256df6)</span></li>
<li>sheets/sheets_readonly.rc <span style="color: grey">(1e9e248)</span></li>
<li>sheets/ui/CellView.cpp <span style="color: grey">(d2b6e26)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110949/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic