'Review Request 110723: Add tests for adding applied styles and applying added styles'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Review Request 110723: Add tests for adding applied styles and applying added styles
From:       "Elvis Stansvik" <elvstone () gmail ! com>
Date:       2013-05-30 13:30:38
Message-ID: 20130530133038.30438.46933 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110723/
-----------------------------------------------------------

Review request for Calligra.

Description
-------

These four style manager tests simply checks that the added para/char styles are marked as used, and that \
the correct signals are emitted.

Diffs
-----

  libs/kotext/styles/KoCharacterStyle.h b4c0670 
  libs/kotext/styles/KoParagraphStyle.h 6c39098 
  libs/kotext/styles/tests/TestStyleManager.h bbe58f6 
  libs/kotext/styles/tests/TestStyleManager.cpp a418472 

Diff: http://git.reviewboard.kde.org/r/110723/diff/

Testing
-------

Passes here.

Thanks,

Elvis Stansvik

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110723/">http://git.reviewboard.kde.org/r/110723/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Elvis Stansvik.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These four style manager tests simply checks \
that the added para/char styles are marked as used, and that the correct signals are emitted.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Passes here.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/kotext/styles/KoCharacterStyle.h <span style="color: grey">(b4c0670)</span></li>

 <li>libs/kotext/styles/KoParagraphStyle.h <span style="color: grey">(6c39098)</span></li>

 <li>libs/kotext/styles/tests/TestStyleManager.h <span style="color: grey">(bbe58f6)</span></li>

 <li>libs/kotext/styles/tests/TestStyleManager.cpp <span style="color: grey">(a418472)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110723/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 