[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 110708: Add some basic unit tests for the style manager
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2013-05-30 6:33:21
Message-ID: 20130530063321.17416.40606 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110708/#review33395
-----------------------------------------------------------
Ship it!
Thanks, very nice that you have taken the initiative on this
- C. Boemann
On May 29, 2013, 11:04 a.m., Elvis Stansvik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110708/
> -----------------------------------------------------------
>
> (Updated May 29, 2013, 11:04 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> Add some basic unit tests for the style manager.
>
> The test simply tests that adding/removing styles work and that the correct signals \
> are emitted. I'll see if I can write some more interesting tests later on.
>
> Diffs
> -----
>
> libs/kotext/styles/KoParagraphStyle.h 77050c1
> libs/kotext/styles/KoSectionStyle.h b5ec2e1
> libs/kotext/styles/KoTableCellStyle.h 54f6c27
> libs/kotext/styles/KoTableColumnStyle.h 41f250a2
> libs/kotext/styles/KoTableRowStyle.h aa0638c
> libs/kotext/styles/KoTableStyle.h 339dd2e
> libs/kotext/styles/tests/CMakeLists.txt a054a39
> libs/kotext/styles/tests/TestStyleManager.h PRE-CREATION
> libs/kotext/styles/tests/TestStyleManager.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/110708/diff/
>
>
> Testing
> -------
>
> The tests all pass here.
>
>
> Thanks,
>
> Elvis Stansvik
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110708/">http://git.reviewboard.kde.org/r/110708/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks, very nice that \
you have taken the initiative on this</pre> <br />
<p>- C.</p>
<br />
<p>On May 29th, 2013, 11:04 a.m. UTC, Elvis Stansvik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Elvis Stansvik.</div>
<p style="color: grey;"><i>Updated May 29, 2013, 11:04 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add some basic unit tests for the style manager.
The test simply tests that adding/removing styles work and that the correct signals \
are emitted. I'll see if I can write some more interesting tests later on.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The tests all pass here.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/kotext/styles/KoParagraphStyle.h <span style="color: \
grey">(77050c1)</span></li>
<li>libs/kotext/styles/KoSectionStyle.h <span style="color: \
grey">(b5ec2e1)</span></li>
<li>libs/kotext/styles/KoTableCellStyle.h <span style="color: \
grey">(54f6c27)</span></li>
<li>libs/kotext/styles/KoTableColumnStyle.h <span style="color: \
grey">(41f250a2)</span></li>
<li>libs/kotext/styles/KoTableRowStyle.h <span style="color: \
grey">(aa0638c)</span></li>
<li>libs/kotext/styles/KoTableStyle.h <span style="color: \
grey">(339dd2e)</span></li>
<li>libs/kotext/styles/tests/CMakeLists.txt <span style="color: \
grey">(a054a39)</span></li>
<li>libs/kotext/styles/tests/TestStyleManager.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/kotext/styles/tests/TestStyleManager.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110708/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic