[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 110383: Implement Distraction-Free mode for Words and Author.
From:       "Commit Hook" <null () kde ! org>
Date:       2013-05-17 7:15:30
Message-ID: 20130517071530.25322.21598 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110383/#review32681
-----------------------------------------------------------


This review has been submitted with commit 4fbaf8bcd99e9787cba5cd226a0c79ffeb42404b \
by Siddharth Sharma on behalf of Mojtaba Shahi Senobari to branch \
krita-psd-plugin-siddharth.

- Commit Hook


On May 11, 2013, 7:14 a.m., mojtaba shahi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110383/
> -----------------------------------------------------------
> 
> (Updated May 11, 2013, 7:14 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Implement Distraction-Free mode for Words and Author.
> Added an action "View->Distractio Free Mode". This action Hide Menu bar, Tool bar, \
> Staus bar, Dock widgets ,Vertical and horizontl scroll bar from view. When you \
> switch to Distractio-Free mode it will rise a floating message say how can you get \
> out from this view. I have added a "Exit Distractio-Free Mode" button to status bar \
> that user can get back to normal view by clicking ont it. (it is visible just in DF \
> mode) Staus bar will show if user moves mouse on status bar at bottom.
> Horizontal and Vertical scroll bars will show when user moves mouse on them.
> Cursor will Hide, user doesn't move mouse after 4 seconds.
> 
> 
> Diffs
> -----
> 
> krita/plugins/tools/tool_crop/kis_tool_crop.cc 05e905b 
> krita/ui/CMakeLists.txt 37e4635 
> krita/ui/kis_view2.cpp 7d4c6da 
> krita/ui/tool/kis_tool.cc 33dbbf0 
> krita/ui/widgets/kis_floating_message.h 0d42e8b 
> krita/ui/widgets/kis_floating_message.cpp d53e133 
> libs/main/KoMainWindow.cpp ea45075 
> libs/main/KoView.cpp c9c82e5 
> libs/widgets/CMakeLists.txt 4e6e362 
> libs/widgets/KoFloatingMessage.h PRE-CREATION 
> libs/widgets/KoFloatingMessage.cpp PRE-CREATION 
> words/part/KWCanvas.cpp 4252ff7 
> words/part/KWGui.h c72234d 
> words/part/KWGui.cpp 803e1b5 
> words/part/KWView.h 6357876 
> words/part/KWView.cpp 5c1cc70 
> words/part/author/author.rc b3b187c 
> words/part/words.rc d2269d1 
> 
> Diff: http://git.reviewboard.kde.org/r/110383/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Distraction-Free Mode
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/distraction-free_mode_1.png
>  Distraction-Free mode with  Status bar
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/distraction-free_mode_2.png
>  Distraction-Free mode with vertical scroll bar
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/distraction-free_mode_3.png
>  
> 
> Thanks,
> 
> mojtaba shahi
> 
> 


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110383/">http://git.reviewboard.kde.org/r/110383/</a>
  </td>
    </tr>
   </table>
   <br />





 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 4fbaf8bcd99e9787cba5cd226a0c79ffeb42404b by Siddharth Sharma on \
behalf of Mojtaba Shahi Senobari to branch krita-psd-plugin-siddharth.</pre>  <br />









<p>- Commit</p>


<br />
<p>On May 11th, 2013, 7:14 a.m. UTC, mojtaba shahi wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By mojtaba shahi.</div>


<p style="color: grey;"><i>Updated May 11, 2013, 7:14 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Implement Distraction-Free mode for Words and Author. Added an action \
&quot;View-&gt;Distractio Free Mode&quot;. This action Hide Menu bar, Tool bar, Staus \
bar, Dock widgets ,Vertical and horizontl scroll bar from view. When you switch to \
Distractio-Free mode it will rise a floating message say how can you get out from \
this view. I have added a &quot;Exit Distractio-Free Mode&quot; button to status bar \
that user can get back to normal view by clicking ont it. (it is visible just in DF \
mode) Staus bar will show if user moves mouse on status bar at bottom.
Horizontal and Vertical scroll bars will show when user moves mouse on them.
Cursor will Hide, user doesn&#39;t move mouse after 4 seconds.</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>krita/plugins/tools/tool_crop/kis_tool_crop.cc <span style="color: \
grey">(05e905b)</span></li>

 <li>krita/ui/CMakeLists.txt <span style="color: grey">(37e4635)</span></li>

 <li>krita/ui/kis_view2.cpp <span style="color: grey">(7d4c6da)</span></li>

 <li>krita/ui/tool/kis_tool.cc <span style="color: grey">(33dbbf0)</span></li>

 <li>krita/ui/widgets/kis_floating_message.h <span style="color: \
grey">(0d42e8b)</span></li>

 <li>krita/ui/widgets/kis_floating_message.cpp <span style="color: \
grey">(d53e133)</span></li>

 <li>libs/main/KoMainWindow.cpp <span style="color: grey">(ea45075)</span></li>

 <li>libs/main/KoView.cpp <span style="color: grey">(c9c82e5)</span></li>

 <li>libs/widgets/CMakeLists.txt <span style="color: grey">(4e6e362)</span></li>

 <li>libs/widgets/KoFloatingMessage.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/widgets/KoFloatingMessage.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>words/part/KWCanvas.cpp <span style="color: grey">(4252ff7)</span></li>

 <li>words/part/KWGui.h <span style="color: grey">(c72234d)</span></li>

 <li>words/part/KWGui.cpp <span style="color: grey">(803e1b5)</span></li>

 <li>words/part/KWView.h <span style="color: grey">(6357876)</span></li>

 <li>words/part/KWView.cpp <span style="color: grey">(5c1cc70)</span></li>

 <li>words/part/author/author.rc <span style="color: grey">(b3b187c)</span></li>

 <li>words/part/words.rc <span style="color: grey">(d2269d1)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110383/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/distraction-free_mode_1.png">Distraction-Free \
Mode</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/distraction-free_mode_2.png">Distraction-Free \
mode with  Status bar</a></li>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/10/distraction-free_mode_3.png">Distraction-Free \
mode with vertical scroll bar</a></li>

</ul>





  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic