[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 109214: Kexi asks for passwords without modal dialogs; improved messages and assi
From:       Adam Pigg <piggz1 () gmail ! com>
Date:       2013-05-06 8:38:21
Message-ID: CANFkB1xmRHMpwAqgEeMEuf_OA4Aj=xPq-fqLZZj6VAQBEkOLjA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Sorry!

You need to remind me about these things, im just soo busy atm :/


On Sun, May 5, 2013 at 11:12 PM, Friedrich W. H. Kossebau
<kossebau@kde.org>wrote:

> Am Samstag, 4. Mai 2013, 23:44:47 schrieb Jaroslaw Staniek:
> > Hi,
> > After 2 months of waiting because it's high time for 2.7, I committed
> this
> > breaking the review rule. But I don't know what's the reason that nobody
> > reviewed. Is the change too large or complicated?
> >
> > Or what to do to get general (i.e. checking style, obvious mistakes, too
> > complex areas) reviews from non-Kexi people from Calligra? I sometimes
> > review non-Kexi code, without particular pattern, can I count for the
> same?
>
> Well, at least I, given that you explicitely listed 5 people as reviewers,
> assumed any of them will be more qualified to give this a review, so
> ignored
> that one. Like I would ignore Krita or other related requests where lots of
> people are listed explicitely.
>
> Possibly some flag to ask explicitely non-core-kexi developers is needed
> then?
>
> Cheers
> Friedrich
> _______________________________________________
> calligra-devel mailing list
> calligra-devel@kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
>

[Attachment #5 (text/html)]

<div dir="ltr">Sorry!<div><br></div><div style>You need to remind me about these \
things, im just soo busy atm :/</div></div><div class="gmail_extra"><br><br><div \
class="gmail_quote">On Sun, May 5, 2013 at 11:12 PM, Friedrich W. H. Kossebau <span \
dir="ltr">&lt;<a href="mailto:kossebau@kde.org" \
target="_blank">kossebau@kde.org</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Am Samstag, 4. Mai 2013, 23:44:47 schrieb Jaroslaw \
Staniek:<br> <div class="im">&gt; Hi,<br>
&gt; After 2 months of waiting because it&#39;s high time for 2.7, I committed \
this<br> &gt; breaking the review rule. But I don&#39;t know what&#39;s the reason \
that nobody<br> &gt; reviewed. Is the change too large or complicated?<br>
&gt;<br>
&gt; Or what to do to get general (i.e. checking style, obvious mistakes, too<br>
&gt; complex areas) reviews from non-Kexi people from Calligra? I sometimes<br>
&gt; review non-Kexi code, without particular pattern, can I count for the same?<br>
<br>
</div>Well, at least I, given that you explicitely listed 5 people as reviewers,<br>
assumed any of them will be more qualified to give this a review, so ignored<br>
that one. Like I would ignore Krita or other related requests where lots of<br>
people are listed explicitely.<br>
<br>
Possibly some flag to ask explicitely non-core-kexi developers is needed then?<br>
<br>
Cheers<br>
Friedrich<br>
_______________________________________________<br>
calligra-devel mailing list<br>
<a href="mailto:calligra-devel@kde.org">calligra-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/calligra-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/calligra-devel</a><br> \
</blockquote></div><br></div>



_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel


[prev in list] [next in list] [prev in thread] [next in thread]