'Re: Review Request 109806: Kexi - By default missing CSV values imported as empty texts.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 109806: Kexi - By default missing CSV values imported as empty texts.
From:       "Tomasz Olszak" <olszak.tomasz () gmail ! com>
Date:       2013-04-15 20:51:22
Message-ID: 20130415205122.8970.99195 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109806/
-----------------------------------------------------------

(Updated April 15, 2013, 8:51 p.m.)

Review request for Calligra and Jarosław Staniek.

Changes
-------

Fixed pointed out mistakes. Diff updated.

Description
-------

[CSV Import]
* By default missing CSV text values imported as empty text .
* Added option which enabled old behavior(missing values imported as NULLs to \
database)

This addresses bug 317509.
    http://bugs.kde.org/show_bug.cgi?id=317509

Diffs (updated)
-----

  kexi/doc/dev/settings.txt 7911352 
  kexi/plugins/importexport/csv/kexicsvimportdialog.cpp fc44bec 
  kexi/plugins/importexport/csv/kexicsvimportoptionsdlg.h f6a29a1 
  kexi/plugins/importexport/csv/kexicsvimportoptionsdlg.cpp 18f134c 

Diff: http://git.reviewboard.kde.org/r/109806/diff/

Testing
-------

Imported csv with mixed integer, text, missing values. Handled and tested case with \
multiple missing values ("A","B",,,,"C","D")

Thanks,

Tomasz Olszak

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109806/">http://git.reviewboard.kde.org/r/109806/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra and Jarosław Staniek.</div>
<div>By Tomasz Olszak.</div>

<p style="color: grey;"><i>Updated April 15, 2013, 8:51 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed pointed out mistakes. Diff updated.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">[CSV Import]
* By default missing CSV text values imported as empty text .
* Added option which enabled old behavior(missing values imported as NULLs to \
database) </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Imported csv with mixed integer, text, missing values. Handled and \
tested case with multiple missing values \
(&quot;A&quot;,&quot;B&quot;,,,,&quot;C&quot;,&quot;D&quot;)</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=317509">317509</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kexi/doc/dev/settings.txt <span style="color: grey">(7911352)</span></li>

 <li>kexi/plugins/importexport/csv/kexicsvimportdialog.cpp <span style="color: \
grey">(fc44bec)</span></li>

 <li>kexi/plugins/importexport/csv/kexicsvimportoptionsdlg.h <span style="color: \
grey">(f6a29a1)</span></li>

 <li>kexi/plugins/importexport/csv/kexicsvimportoptionsdlg.cpp <span style="color: \
grey">(18f134c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109806/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 