[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Review Request 109980: Load styles into a new, more generic style manager
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2013-04-12 17:09:24
Message-ID: 20130412170924.2120.33585 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109980/
-----------------------------------------------------------
Review request for Calligra.
Description
-------
Here is step 2 in the plan to create a docx export filter.
It contains code to load styles into a decently generic style manager. The main use \
of this version will be as a much faster alternative to KoOdfStylesReader that forces \
you to reparse the XML of all styles that you want to access. This code loads the \
style content into more easily accessed data structures. The current version only \
supports the Text, Paragraph, and Graphic families because that's what we need in the \
docx filter.
I also have a half-finished patch of Karbon that makes it load, store and save \
graphics styles which it currently discards in all odg files. However that turned out \
to be more difficult than expected because the text based style manager in \
libs/kotext doesn't allow anybody to save any styles outside itself so I'm postponing \
that into a separate patch. This way we can start using these styles when doing the \
docx export.
As a side note, I have also included a new innovative XML stream reader which I will \
port the odf traverser to.
Diffs
-----
CMakeLists.txt ff832cc
filters/libodftraverse/OdfTraverserContext.cpp 884e3d4
libs/odf/CMakeLists.txt 3680486
libs/odf/KoXmlStreamReader.h PRE-CREATION
libs/odf/KoXmlStreamReader.cpp PRE-CREATION
libs/odf/styles/KoOdfStyle.h PRE-CREATION
libs/odf/styles/KoOdfStyle.cpp PRE-CREATION
libs/odf/styles/KoOdfStyleManager.h PRE-CREATION
libs/odf/styles/KoOdfStyleManager.cpp PRE-CREATION
libs/odf/styles/KoOdfStyleProperties.h PRE-CREATION
libs/odf/styles/KoOdfStyleProperties.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/109980/diff/
Testing
-------
Tested the loading of the styles very thoroughly through manual inspection since this \
is what's needed for docx export. Not tested saving as thoroughly but will do that \
when it's used in any real application.
Thanks,
Inge Wallin
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109980/">http://git.reviewboard.kde.org/r/109980/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Inge Wallin.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Here is step 2 in the plan to create a docx export filter.
It contains code to load styles into a decently generic style manager. The main use \
of this version will be as a much faster alternative to KoOdfStylesReader that forces \
you to reparse the XML of all styles that you want to access. This code loads the \
style content into more easily accessed data structures. The current version only \
supports the Text, Paragraph, and Graphic families because that's what we need in \
the docx filter.
I also have a half-finished patch of Karbon that makes it load, store and save \
graphics styles which it currently discards in all odg files. However that turned out \
to be more difficult than expected because the text based style manager in \
libs/kotext doesn't allow anybody to save any styles outside itself so I'm \
postponing that into a separate patch. This way we can start using these styles when \
doing the docx export.
As a side note, I have also included a new innovative XML stream reader which I will \
port the odf traverser to.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested the loading of the styles very thoroughly through manual \
inspection since this is what's needed for docx export. Not tested saving as \
thoroughly but will do that when it's used in any real application.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ff832cc)</span></li>
<li>filters/libodftraverse/OdfTraverserContext.cpp <span style="color: \
grey">(884e3d4)</span></li>
<li>libs/odf/CMakeLists.txt <span style="color: grey">(3680486)</span></li>
<li>libs/odf/KoXmlStreamReader.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/odf/KoXmlStreamReader.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/odf/styles/KoOdfStyle.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/odf/styles/KoOdfStyle.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/odf/styles/KoOdfStyleManager.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/odf/styles/KoOdfStyleManager.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/odf/styles/KoOdfStyleProperties.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/odf/styles/KoOdfStyleProperties.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109980/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic