[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 109746: Expansion of the References section by adding
From: "Aman Madaan" <madaan.amanmadaan () gmail ! com>
Date: 2013-03-29 23:47:26
Message-ID: 20130329234726.13585.26795 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109746/
-----------------------------------------------------------
(Updated March 29, 2013, 11:47 p.m.)
Review request for Calligra.
Changes
-------
This version of the patch fixes 2 major issues pointed out in the previous review.
1. Adding a way to warn a user when adding bookmark using the "quick insert" \
technique.
After trying QValidator and some more things, I settled upon the current method. Now \
the textChanged() signal of the lineedit is caught. If the text currently present is \
an existing bookmark, a warning is displayed with suggestion to go to "Manage \
Bookmarks" in red just below the text edit. Otherwise, a "Valid" in green appears.
2. Merging of Weblinkwidget, Bookmarklink widget and LinkInsertionDialog (in \
LinkInsertionDialog). As suggested, designer is now used to add widgets.
Other changes included removing unnecessary methods, files, brushing up the UI, \
improving the indentation and some other minor fixes in field validation.
Description
-------
This patch adds the following features :
1. Inserting hyperlinks
-- User has a choice of inserting a link by specifying the target and the link \
text. Additionally, the
user may supply values for target and rel attributes using a drop down list.
-- The user may fetch the title from the web page itself (contents of the "title" \
tag ). This feature also
handles URL redirects. For example, ieee.com is finally redirected to \
http://www.ieee.org/index.html.
This feature will especially help in cases when a user has a list of links \
referred to and a list of
references has to be created. Just copy/pasting the URL, clicking fetch and \
then insert will do the job.
2. Linking to bookmarks
-- A user can specify a bookmark name and the link text. To help the user with \
inserting bookmark,
an auto completer is used. This becomes helpful when the bookmarks have been \
given a name that are related to the context. (lastpagefirstpara or conclusions).
3. Adding Bookmark using a labeled widget ( similar to the way footnote and endnote \
labels are entered )
Diffs (updated)
-----
CMakeFiles/cmake.check_cache PRE-CREATION
plugins/textshape/CMakeLists.txt b2bf9ae
plugins/textshape/ReferencesTool.h 21caea8
plugins/textshape/ReferencesTool.cpp 46bf06f
plugins/textshape/dialogs/LinkInsertionDialog.h PRE-CREATION
plugins/textshape/dialogs/LinkInsertionDialog.cpp PRE-CREATION
plugins/textshape/dialogs/LinkInsertionDialog.ui PRE-CREATION
plugins/textshape/dialogs/ManageBookmark.ui PRE-CREATION
plugins/textshape/dialogs/ManageBookmarkDialog.h PRE-CREATION
plugins/textshape/dialogs/ManageBookmarkDialog.cpp PRE-CREATION
plugins/textshape/dialogs/SimpleCitationBibliographyWidget.ui 55699bb
plugins/textshape/dialogs/SimpleLinksWidget.h PRE-CREATION
plugins/textshape/dialogs/SimpleLinksWidget.cpp PRE-CREATION
plugins/textshape/dialogs/SimpleLinksWidget.ui PRE-CREATION
plugins/textshape/dialogs/SimpleTableOfContentsWidget.h adfd010
words/part/KWView.cpp 8639acd
Diff: http://git.reviewboard.kde.org/r/109746/diff/
Testing
-------
I have tested the following components :
1 Inserting Hyperlinks
1.1 Simplest case (works)
1.2 Fetch title from URL (works)
1.3 Fetch title from URL which has re directions (works)
1.4 specify a URL without a scheme (works, appending an http:// to all the schemeless \
urls) 1.5 fetching from an non existing URL (Time out occurs and notifies user about \
the same)
2 Adding Bookmarks
2.1 Simplest case (works)
2.2 Adding a duplicate bookmark i.e. using a name that has been used before(User is \
notified and bookmark addition is aborted)
3 Adding link to a bookmark
3.1 Simplest case (works)
3.2 Adding a link to a non existing bookmark (works,User is notified about non \
existence of the bookmark)
4 Manage bookmarks
4.1 user clicks on manage bookmarks (works, Copy pasted the existing implementation. \
Looks like delete bookmark is broken.)
Thanks,
Aman Madaan
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109746/">http://git.reviewboard.kde.org/r/109746/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Aman Madaan.</div>
<p style="color: grey;"><i>Updated March 29, 2013, 11:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This version of the patch fixes 2 major issues pointed out in the \
previous review.
1. Adding a way to warn a user when adding bookmark using the "quick \
insert" technique.
After trying QValidator and some more things, I settled upon the current method. Now \
the textChanged() signal of the lineedit is caught. If the text currently present is \
an existing bookmark, a warning is displayed with suggestion to go to "Manage \
Bookmarks" in red just below the text edit. Otherwise, a "Valid" in \
green appears.
2. Merging of Weblinkwidget, Bookmarklink widget and LinkInsertionDialog (in \
LinkInsertionDialog). As suggested, designer is now used to add widgets.
Other changes included removing unnecessary methods, files, brushing up the UI, \
improving the indentation and some other minor fixes in field validation.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds the following features :
1. Inserting hyperlinks
-- User has a choice of inserting a link by specifying the target and the link \
text. Additionally, the
user may supply values for target and rel attributes using a drop down list.
-- The user may fetch the title from the web page itself (contents of the \
"title" tag ). This feature also
handles URL redirects. For example, ieee.com is finally redirected to \
http://www.ieee.org/index.html.
This feature will especially help in cases when a user has a list of links \
referred to and a list of
references has to be created. Just copy/pasting the URL, clicking fetch and \
then insert will do the job.
2. Linking to bookmarks
-- A user can specify a bookmark name and the link text. To help the user with \
inserting bookmark,
an auto completer is used. This becomes helpful when the bookmarks have been \
given a name that are related to the context. (lastpagefirstpara or conclusions).
3. Adding Bookmark using a labeled widget ( similar to the way footnote and endnote \
labels are entered ) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have tested the following components :
1 Inserting Hyperlinks
1.1 Simplest case (works)
1.2 Fetch title from URL (works)
1.3 Fetch title from URL which has re directions (works)
1.4 specify a URL without a scheme (works, appending an http:// to all the schemeless \
urls) 1.5 fetching from an non existing URL (Time out occurs and notifies user about \
the same)
2 Adding Bookmarks
2.1 Simplest case (works)
2.2 Adding a duplicate bookmark i.e. using a name that has been used before(User is \
notified and bookmark addition is aborted)
3 Adding link to a bookmark
3.1 Simplest case (works)
3.2 Adding a link to a non existing bookmark (works,User is notified about non \
existence of the bookmark)
4 Manage bookmarks
4.1 user clicks on manage bookmarks (works, Copy pasted the existing implementation. \
Looks like delete bookmark is broken.) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeFiles/cmake.check_cache <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(b2bf9ae)</span></li>
<li>plugins/textshape/ReferencesTool.h <span style="color: \
grey">(21caea8)</span></li>
<li>plugins/textshape/ReferencesTool.cpp <span style="color: \
grey">(46bf06f)</span></li>
<li>plugins/textshape/dialogs/LinkInsertionDialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/LinkInsertionDialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/LinkInsertionDialog.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/ManageBookmark.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/ManageBookmarkDialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/ManageBookmarkDialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleCitationBibliographyWidget.ui <span \
style="color: grey">(55699bb)</span></li>
<li>plugins/textshape/dialogs/SimpleLinksWidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleLinksWidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleLinksWidget.ui <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/dialogs/SimpleTableOfContentsWidget.h <span style="color: \
grey">(adfd010)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(8639acd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109746/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic