[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 109615: turn all filters in filters/ into individual products, make core calligra
From: "Commit Hook" <null () kde ! org>
Date: 2013-03-24 12:10:00
Message-ID: 20130324121000.18465.8532 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109615/
-----------------------------------------------------------
(Updated March 24, 2013, 12:09 p.m.)
Status
------
This change has been marked as submitted.
Review request for Calligra.
Description
-------
Each filter in filters/ got turned into a product with the naming pattern \
"FILTER_A_TO_B", to hint in the name from which file/app to which file/app the filter \
works (I was surprised how many file->file filters there are).
Patch also turns the core calligra libs into a product "CALLIGRA_LIBS", as there are \
other products that do not rely on them, so possibly someone might want to skip \
these. At least it is also interesting to see what relies on them and what not.
Most checks are also fetched into the toplevel CMakeLists.txt, for consistency and \
overview. Also Poppler, WPG & Co. were checked more than once.
Really quite a long list of products. But it should help us to keep an overview what \
is provided by Calligra, instead of having stuff buried somewhere in deep folders.
BTW:
I wonder if meta products like "Words" should not also be able to result in all \
useful stuff to be built, like the suiting filters. That would need the addition of \
another tag next to "NEEDS", e.g. "LIKES", "WANTS" or "WISHES".
Diffs
-----
CMakeLists.txt c4e14e7
cmake/productsets/active.cmake c366a6a
cmake/productsets/all.cmake 5f27fd4
cmake/productsets/creative.cmake 94d1768
cmake/productsets/desktop.cmake a732e36
devtools/cstester/visualimagecompare/CMakeLists.txt 6c46c62
filters/CMakeLists.txt 82bb2f1
filters/flow/CMakeLists.txt ed12fd2
filters/flow/visio/CMakeLists.txt c279d75
filters/flow/visio/import/CMakeLists.txt a20db2a
filters/karbon/CMakeLists.txt ee99220
filters/karbon/karbon1.x/CMakeLists.txt 517480a
filters/karbon/svg/CMakeLists.txt 09ada07
filters/karbon/wmf/CMakeLists.txt e7fff92
filters/karbon/wpg/CMakeLists.txt 351fd37
filters/karbon/xfig/CMakeLists.txt 2e62248
filters/plan/mpxj/CMakeLists.txt 52c331d
filters/sheets/CMakeLists.txt dc9bb06
filters/sheets/csv/CMakeLists.txt f6a5183
filters/sheets/excel/CMakeLists.txt 3f0f5d9
filters/sheets/excel/import/CMakeLists.txt 97661d3
filters/sheets/excel/sidewinder/CMakeLists.txt a35211d
filters/sheets/gnumeric/CMakeLists.txt ea65d20
filters/sheets/html/CMakeLists.txt aa54222
filters/sheets/latex/CMakeLists.txt 36cf84c
filters/sheets/opencalc/CMakeLists.txt 125d0db
filters/sheets/xlsx/CMakeLists.txt 5feddf2
filters/stage/CMakeLists.txt 91b07d8
filters/stage/kpr2odf/CMakeLists.txt 8cd64b9
filters/stage/powerpoint/CMakeLists.txt bc91c63
filters/stage/pptx/CMakeLists.txt a2d8f39
filters/words/CMakeLists.txt 51aebb8
filters/words/ascii/CMakeLists.txt f4dbf37
filters/words/docx/CMakeLists.txt 8a341a0
filters/words/epub/CMakeLists.txt 53513a1
filters/words/msword-odf/CMakeLists.txt b1d6adc
filters/words/rtf/CMakeLists.txt 954fbfd
filters/words/rtf/import/CMakeLists.txt aa0a94d
filters/words/wordperfect/CMakeLists.txt ad6de17
filters/words/wordperfect/import/CMakeLists.txt 6b15094
filters/words/works/CMakeLists.txt c279d75
filters/words/works/import/CMakeLists.txt 7a11da8
krita/plugins/formats/CMakeLists.txt 4b9090d
krita/plugins/formats/ora/CMakeLists.txt a285498
libs/CMakeLists.txt 8e23b21
Diff: http://git.reviewboard.kde.org/r/109615/diff/
Testing
-------
Still builds fine for all default productsets for me.
Thanks,
Friedrich W. H. Kossebau
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109615/">http://git.reviewboard.kde.org/r/109615/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated March 24, 2013, 12:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Each filter in filters/ got turned into a product with the naming \
pattern "FILTER_A_TO_B", to hint in the name from which file/app to which \
file/app the filter works (I was surprised how many file->file filters there are).
Patch also turns the core calligra libs into a product "CALLIGRA_LIBS", as \
there are other products that do not rely on them, so possibly someone might want to \
skip these. At least it is also interesting to see what relies on them and what not.
Most checks are also fetched into the toplevel CMakeLists.txt, for consistency and \
overview. Also Poppler, WPG & Co. were checked more than once.
Really quite a long list of products. But it should help us to keep an overview what \
is provided by Calligra, instead of having stuff buried somewhere in deep folders.
BTW:
I wonder if meta products like "Words" should not also be able to result in \
all useful stuff to be built, like the suiting filters. That would need the addition \
of another tag next to "NEEDS", e.g. "LIKES", "WANTS" \
or "WISHES".</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Still builds fine for all default productsets for me.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(c4e14e7)</span></li>
<li>cmake/productsets/active.cmake <span style="color: grey">(c366a6a)</span></li>
<li>cmake/productsets/all.cmake <span style="color: grey">(5f27fd4)</span></li>
<li>cmake/productsets/creative.cmake <span style="color: grey">(94d1768)</span></li>
<li>cmake/productsets/desktop.cmake <span style="color: grey">(a732e36)</span></li>
<li>devtools/cstester/visualimagecompare/CMakeLists.txt <span style="color: \
grey">(6c46c62)</span></li>
<li>filters/CMakeLists.txt <span style="color: grey">(82bb2f1)</span></li>
<li>filters/flow/CMakeLists.txt <span style="color: grey">(ed12fd2)</span></li>
<li>filters/flow/visio/CMakeLists.txt <span style="color: \
grey">(c279d75)</span></li>
<li>filters/flow/visio/import/CMakeLists.txt <span style="color: \
grey">(a20db2a)</span></li>
<li>filters/karbon/CMakeLists.txt <span style="color: grey">(ee99220)</span></li>
<li>filters/karbon/karbon1.x/CMakeLists.txt <span style="color: \
grey">(517480a)</span></li>
<li>filters/karbon/svg/CMakeLists.txt <span style="color: \
grey">(09ada07)</span></li>
<li>filters/karbon/wmf/CMakeLists.txt <span style="color: \
grey">(e7fff92)</span></li>
<li>filters/karbon/wpg/CMakeLists.txt <span style="color: \
grey">(351fd37)</span></li>
<li>filters/karbon/xfig/CMakeLists.txt <span style="color: \
grey">(2e62248)</span></li>
<li>filters/plan/mpxj/CMakeLists.txt <span style="color: grey">(52c331d)</span></li>
<li>filters/sheets/CMakeLists.txt <span style="color: grey">(dc9bb06)</span></li>
<li>filters/sheets/csv/CMakeLists.txt <span style="color: \
grey">(f6a5183)</span></li>
<li>filters/sheets/excel/CMakeLists.txt <span style="color: \
grey">(3f0f5d9)</span></li>
<li>filters/sheets/excel/import/CMakeLists.txt <span style="color: \
grey">(97661d3)</span></li>
<li>filters/sheets/excel/sidewinder/CMakeLists.txt <span style="color: \
grey">(a35211d)</span></li>
<li>filters/sheets/gnumeric/CMakeLists.txt <span style="color: \
grey">(ea65d20)</span></li>
<li>filters/sheets/html/CMakeLists.txt <span style="color: \
grey">(aa54222)</span></li>
<li>filters/sheets/latex/CMakeLists.txt <span style="color: \
grey">(36cf84c)</span></li>
<li>filters/sheets/opencalc/CMakeLists.txt <span style="color: \
grey">(125d0db)</span></li>
<li>filters/sheets/xlsx/CMakeLists.txt <span style="color: \
grey">(5feddf2)</span></li>
<li>filters/stage/CMakeLists.txt <span style="color: grey">(91b07d8)</span></li>
<li>filters/stage/kpr2odf/CMakeLists.txt <span style="color: \
grey">(8cd64b9)</span></li>
<li>filters/stage/powerpoint/CMakeLists.txt <span style="color: \
grey">(bc91c63)</span></li>
<li>filters/stage/pptx/CMakeLists.txt <span style="color: \
grey">(a2d8f39)</span></li>
<li>filters/words/CMakeLists.txt <span style="color: grey">(51aebb8)</span></li>
<li>filters/words/ascii/CMakeLists.txt <span style="color: \
grey">(f4dbf37)</span></li>
<li>filters/words/docx/CMakeLists.txt <span style="color: \
grey">(8a341a0)</span></li>
<li>filters/words/epub/CMakeLists.txt <span style="color: \
grey">(53513a1)</span></li>
<li>filters/words/msword-odf/CMakeLists.txt <span style="color: \
grey">(b1d6adc)</span></li>
<li>filters/words/rtf/CMakeLists.txt <span style="color: grey">(954fbfd)</span></li>
<li>filters/words/rtf/import/CMakeLists.txt <span style="color: \
grey">(aa0a94d)</span></li>
<li>filters/words/wordperfect/CMakeLists.txt <span style="color: \
grey">(ad6de17)</span></li>
<li>filters/words/wordperfect/import/CMakeLists.txt <span style="color: \
grey">(6b15094)</span></li>
<li>filters/words/works/CMakeLists.txt <span style="color: \
grey">(c279d75)</span></li>
<li>filters/words/works/import/CMakeLists.txt <span style="color: \
grey">(7a11da8)</span></li>
<li>krita/plugins/formats/CMakeLists.txt <span style="color: \
grey">(4b9090d)</span></li>
<li>krita/plugins/formats/ora/CMakeLists.txt <span style="color: \
grey">(a285498)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(8e23b21)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109615/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic