'Re: Review Request 109226: from allways true to (probably) what is wanted'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 109226: from allways true to (probably) what is wanted
From:       "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date:       2013-03-02 3:50:56
Message-ID: 20130302035056.24704.20894 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109226/#review28371
-----------------------------------------------------------

Ship it!

Looks good, please shipt

- Thorsten Zachmann

On March 1, 2013, 3:41 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109226/
> -----------------------------------------------------------
> 
> (Updated March 1, 2013, 3:41 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> a>=1 || a<=4 is always true. a>=1 && a<=4 not always.
> 
> 
> Diffs
> -----
> 
>   sheets/Style.cpp a3a3976 
> 
> Diff: http://git.reviewboard.kde.org/r/109226/diff/
> 
> 
> Testing
> -------
> 
> I see the same failed tests as before.
> 
>         169 - krita-ui-KisDoc2Test (Failed)
>         172 - krita-ui-FreehandStrokeTest (Failed)
>         173 - krita-ui-KisSelectionManagerTest (Failed)
>         174 - krita-ui-KisNodeManagerTest (Failed)
>         176 - krita-ui-KisNodeShapesGraphTest (Failed)
>         182 - krita-ui-KisActionManagerTest (Failed)
>         191 - krita-plugin-format-jpeg_test (Failed)
>         210 - libs-store-storage (Failed)
>         216 - libs-textlayout-TestBlockLayout (Failed)
>         229 - libs-kotext-styles-TestOpenDocumentStyle (Failed)
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109226/">http://git.reviewboard.kde.org/r/109226/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, please \
shipt</pre>  <br />

<p>- Thorsten</p>

<br />
<p>On March 1st, 2013, 3:41 p.m. UTC, Jaime Torres Amate wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Jaime Torres Amate.</div>

<p style="color: grey;"><i>Updated March 1, 2013, 3:41 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">a&gt;=1 || a&lt;=4 is always true. a&gt;=1 &amp;&amp; a&lt;=4 not \
always.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I see the same failed tests as before.

        169 - krita-ui-KisDoc2Test (Failed)
        172 - krita-ui-FreehandStrokeTest (Failed)
        173 - krita-ui-KisSelectionManagerTest (Failed)
        174 - krita-ui-KisNodeManagerTest (Failed)
        176 - krita-ui-KisNodeShapesGraphTest (Failed)
        182 - krita-ui-KisActionManagerTest (Failed)
        191 - krita-plugin-format-jpeg_test (Failed)
        210 - libs-store-storage (Failed)
        216 - libs-textlayout-TestBlockLayout (Failed)
        229 - libs-kotext-styles-TestOpenDocumentStyle (Failed)
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>sheets/Style.cpp <span style="color: grey">(a3a3976)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109226/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 