'Re: Review Request 109225: initialize two membes'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 109225: initialize two membes
From:       "C. Boemann" <cbr () boemann ! dk>
Date:       2013-03-01 20:22:21
Message-ID: 20130301202221.31121.42037 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109225/#review28362
-----------------------------------------------------------

Ship it!

Ship It!

- C. Boemann

On March 1, 2013, 3:24 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109225/
> -----------------------------------------------------------
> 
> (Updated March 1, 2013, 3:24 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Avoid valgrind warnings about those members used without being initialized.
> 
> 
> Diffs
> -----
> 
>   libs/widgets/KoZoomController.cpp 37ccb2f 
>   words/part/KWView.cpp 554caf5 
> 
> Diff: http://git.reviewboard.kde.org/r/109225/diff/
> 
> 
> Testing
> -------
> 
> The first try, with values 0, increased the number of failed test in "make test".
> With those numbers, the failing test do not increment. 
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109225/">http://git.reviewboard.kde.org/r/109225/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- C.</p>

<br />
<p>On March 1st, 2013, 3:24 p.m. UTC, Jaime Torres Amate wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Jaime Torres Amate.</div>

<p style="color: grey;"><i>Updated March 1, 2013, 3:24 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Avoid valgrind \
warnings about those members used without being initialized. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The first try, with \
values 0, increased the number of failed test in &quot;make test&quot;. With those numbers, the \
failing test do not increment. </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/widgets/KoZoomController.cpp <span style="color: grey">(37ccb2f)</span></li>

 <li>words/part/KWView.cpp <span style="color: grey">(554caf5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109225/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 