'Re: Review Request 109123: Set the freehand tool curve exactness default value to 1'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 109123: Set the freehand tool curve exactness default value to 1
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2013-03-01 13:44:35
Message-ID: 20130301134435.21623.49755 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109123/#review28329
-----------------------------------------------------------

Ship it!

Cool, I'll push it!

- Boudewijn Rempt

On March 1, 2013, 4:33 a.m., Somsubhra Bairi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109123/
> -----------------------------------------------------------
> 
> (Updated March 1, 2013, 4:33 a.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Description
> -------
> 
> Set the freehand tool curve exactness default value to 1
> 
> 
> This addresses bug 313593.
>     http://bugs.kde.org/show_bug.cgi?id=313593
> 
> 
> Diffs
> -----
> 
>   krita/plugins/tools/defaulttools/kis_tool_pencil.cc aace615 
>   libs/basicflakes/tools/KoPencilTool.h 0d586c4 
>   libs/basicflakes/tools/KoPencilTool.cpp f6ac4c9 
> 
> Diff: http://git.reviewboard.kde.org/r/109123/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Somsubhra Bairi
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109123/">http://git.reviewboard.kde.org/r/109123/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cool, I&#39;ll push \
it!</pre>  <br />

<p>- Boudewijn</p>

<br />
<p>On March 1st, 2013, 4:33 a.m. UTC, Somsubhra Bairi wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra and Boudewijn Rempt.</div>
<div>By Somsubhra Bairi.</div>

<p style="color: grey;"><i>Updated March 1, 2013, 4:33 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Set the freehand tool curve exactness default value to 1</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=313593">313593</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>krita/plugins/tools/defaulttools/kis_tool_pencil.cc <span style="color: \
grey">(aace615)</span></li>

 <li>libs/basicflakes/tools/KoPencilTool.h <span style="color: \
grey">(0d586c4)</span></li>

 <li>libs/basicflakes/tools/KoPencilTool.cpp <span style="color: \
grey">(f6ac4c9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109123/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 