[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Review Request 109002: Turning stage into modebox
From:       "Jean-Nicolas Artaud" <jeannicolasartaud () gmail ! com>
Date:       2013-02-18 9:14:24
Message-ID: 20130218091424.23196.88504 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109002/
-----------------------------------------------------------

Review request for Calligra and C. Boemann.


Description
-------

Turns stage into modebox.
Totaly remove the Stroke and Fill docker.
Add the background fill widget, especialy needed in stage.


Diffs
-----

  flow/part/FlowView.cpp b30dbe9 
  libs/kopageapp/CMakeLists.txt 35db53f 
  libs/kopageapp/KoPAView.h 80b9f78 
  libs/kopageapp/KoPAView.cpp 58b4940 
  libs/kopageapp/tools/backgroundTool/BackgroundToolWidget.ui 937e569 
  libs/kopageapp/tools/backgroundTool/CMakeLists.txt 339c671 
  libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h 45a240f 
  libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp 69f7649 
  libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.h cb75621 
  libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp b803e79 
  libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp c0c5afa 
  libs/kopageapp/widgets/KoPABackgroundFillWidget.h PRE-CREATION 
  libs/kopageapp/widgets/KoPABackgroundFillWidget.cpp PRE-CREATION 
  libs/widgets/KoFillConfigWidget.h 04b185a 
  libs/widgets/KoFillConfigWidget.cpp d086eb7 
  plugins/dockers/CMakeLists.txt dde9e22 
  plugins/dockers/Plugin.cpp 9b6c442 
  plugins/dockers/styledocker/StrokeFillWidget.h 212eaa0 
  plugins/dockers/styledocker/StrokeFillWidget.cpp d67cabf 
  plugins/dockers/styledocker/StyleButtonBox.h e2957fa 
  plugins/dockers/styledocker/StyleButtonBox.cpp 291a5af 
  plugins/dockers/styledocker/StyleDocker.h 13cf77f 
  plugins/dockers/styledocker/StyleDocker.cpp ffec9c4 
  plugins/dockers/styledocker/StyleDockerFactory.h acd91ac 
  plugins/dockers/styledocker/StyleDockerFactory.cpp 5898610 
  plugins/dockers/styledocker/StylePreview.h db33b3f 
  plugins/dockers/styledocker/StylePreview.cpp 39f8b42 
  plugins/textshape/dialogs/SimpleTableWidget.ui cf9efa0 
  stage/part/CMakeLists.txt de57a0f 
  stage/part/KPrPageLayoutWidget.h PRE-CREATION 
  stage/part/KPrPageLayoutWidget.cpp PRE-CREATION 
  stage/part/KPrView.cpp 078b34b 
  stage/part/dockers/KPrPageLayoutDocker.h ed7a547 
  stage/part/dockers/KPrPageLayoutDocker.cpp e0e3113 

Diff: http://git.reviewboard.kde.org/r/109002/diff/


Testing
-------

I played around with the stage-designtool2-boemann branch.


Thanks,

Jean-Nicolas Artaud


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109002/">http://git.reviewboard.kde.org/r/109002/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra and C. Boemann.</div>
<div>By Jean-Nicolas Artaud.</div>







<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Turns stage into modebox. Totaly remove the Stroke and Fill docker.
Add the background fill widget, especialy needed in stage.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I played around with the stage-designtool2-boemann branch.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>flow/part/FlowView.cpp <span style="color: grey">(b30dbe9)</span></li>

 <li>libs/kopageapp/CMakeLists.txt <span style="color: grey">(35db53f)</span></li>

 <li>libs/kopageapp/KoPAView.h <span style="color: grey">(80b9f78)</span></li>

 <li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(58b4940)</span></li>

 <li>libs/kopageapp/tools/backgroundTool/BackgroundToolWidget.ui <span style="color: \
grey">(937e569)</span></li>

 <li>libs/kopageapp/tools/backgroundTool/CMakeLists.txt <span style="color: \
grey">(339c671)</span></li>

 <li>libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h <span style="color: \
grey">(45a240f)</span></li>

 <li>libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp <span style="color: \
grey">(69f7649)</span></li>

 <li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.h <span \
style="color: grey">(cb75621)</span></li>

 <li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp <span \
style="color: grey">(b803e79)</span></li>

 <li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp <span \
style="color: grey">(c0c5afa)</span></li>

 <li>libs/kopageapp/widgets/KoPABackgroundFillWidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/kopageapp/widgets/KoPABackgroundFillWidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/widgets/KoFillConfigWidget.h <span style="color: \
grey">(04b185a)</span></li>

 <li>libs/widgets/KoFillConfigWidget.cpp <span style="color: \
grey">(d086eb7)</span></li>

 <li>plugins/dockers/CMakeLists.txt <span style="color: grey">(dde9e22)</span></li>

 <li>plugins/dockers/Plugin.cpp <span style="color: grey">(9b6c442)</span></li>

 <li>plugins/dockers/styledocker/StrokeFillWidget.h <span style="color: \
grey">(212eaa0)</span></li>

 <li>plugins/dockers/styledocker/StrokeFillWidget.cpp <span style="color: \
grey">(d67cabf)</span></li>

 <li>plugins/dockers/styledocker/StyleButtonBox.h <span style="color: \
grey">(e2957fa)</span></li>

 <li>plugins/dockers/styledocker/StyleButtonBox.cpp <span style="color: \
grey">(291a5af)</span></li>

 <li>plugins/dockers/styledocker/StyleDocker.h <span style="color: \
grey">(13cf77f)</span></li>

 <li>plugins/dockers/styledocker/StyleDocker.cpp <span style="color: \
grey">(ffec9c4)</span></li>

 <li>plugins/dockers/styledocker/StyleDockerFactory.h <span style="color: \
grey">(acd91ac)</span></li>

 <li>plugins/dockers/styledocker/StyleDockerFactory.cpp <span style="color: \
grey">(5898610)</span></li>

 <li>plugins/dockers/styledocker/StylePreview.h <span style="color: \
grey">(db33b3f)</span></li>

 <li>plugins/dockers/styledocker/StylePreview.cpp <span style="color: \
grey">(39f8b42)</span></li>

 <li>plugins/textshape/dialogs/SimpleTableWidget.ui <span style="color: \
grey">(cf9efa0)</span></li>

 <li>stage/part/CMakeLists.txt <span style="color: grey">(de57a0f)</span></li>

 <li>stage/part/KPrPageLayoutWidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>stage/part/KPrPageLayoutWidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>stage/part/KPrView.cpp <span style="color: grey">(078b34b)</span></li>

 <li>stage/part/dockers/KPrPageLayoutDocker.h <span style="color: \
grey">(ed7a547)</span></li>

 <li>stage/part/dockers/KPrPageLayoutDocker.cpp <span style="color: \
grey">(e0e3113)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109002/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic