[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 108996: update calligraactive.desktop: sync mimetypes with those of Sheets, Stage
From: "Commit Hook" <null () kde ! org>
Date: 2013-02-17 18:04:00
Message-ID: 20130217180400.12751.40467 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108996/#review27592
-----------------------------------------------------------
This review has been submitted with commit 2ef1b9ea5bc1245977208c4678fae85f143497a2 \
by Friedrich W. H. Kossebau to branch master.
- Commit Hook
On Feb. 17, 2013, 4:41 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108996/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2013, 4:41 p.m.)
>
>
> Review request for Calligra and Shantanu Tushar.
>
>
> Description
> -------
>
> CalligraActive should offer itself as handler for the same mimetypes as the \
> "normal" programs Sheets, Stage & Words do, or? Any osso entries are not expected \
> to be used again. And the x-Window-Icon also seems outdated Maemo stuff.
> Attached patch removes all those entries considered outdated and lists all \
> mimetypes which are also listed in sheets.desktop, stage.desktop and words.desktop \
> (ideally mimetypes for whom a filter might not be installed should be listed in \
> separate desktop files, like e.g. Okular does it, cmp. also Calligra's \
> okularodpgenerator, but that needs to be discussed first. so for now just syncing \
> behaviour)
> Okay to also backport to 2.6?
>
>
> Diffs
> -----
>
> active/calligraactive.desktop 1771d2b
>
> Diff: http://git.reviewboard.kde.org/r/108996/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108996/">http://git.reviewboard.kde.org/r/108996/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 2ef1b9ea5bc1245977208c4678fae85f143497a2 by Friedrich W. H. \
Kossebau to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On February 17th, 2013, 4:41 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra and Shantanu Tushar.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Feb. 17, 2013, 4:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">CalligraActive should offer itself as handler for the same mimetypes as \
the "normal" programs Sheets, Stage & Words do, or? Any osso entries \
are not expected to be used again. And the x-Window-Icon also seems outdated Maemo \
stuff.
Attached patch removes all those entries considered outdated and lists all mimetypes \
which are also listed in sheets.desktop, stage.desktop and words.desktop (ideally \
mimetypes for whom a filter might not be installed should be listed in separate \
desktop files, like e.g. Okular does it, cmp. also Calligra's okularodpgenerator, \
but that needs to be discussed first. so for now just syncing behaviour)
Okay to also backport to 2.6?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>active/calligraactive.desktop <span style="color: grey">(1771d2b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108996/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic