[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 108444: Fix cash on creating new character style
From: "Commit Hook" <null () kde ! org>
Date: 2013-01-18 20:05:00
Message-ID: 20130118200500.22884.67060 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108444/#review25759
-----------------------------------------------------------
This review has been submitted with commit eb2696c33941d0c62cd23fbb75b0fa3c7c957c55 \
by Pierre Stirnweiss to branch calligra/2.6.
- Commit Hook
On Jan. 18, 2013, 2:09 p.m., Pierre Stirnweiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108444/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 2:09 p.m.)
>
>
> Review request for Calligra and Friedrich W. H. Kossebau.
>
>
> Description
> -------
>
> When creating a new character style, Words crashed because an null pointer was \
> passed around and used. Also, the name of the style was not updated.
>
> This addresses bug 313233.
> http://bugs.kde.org/show_bug.cgi?id=313233
>
>
> Diffs
> -----
>
> plugins/textshape/dialogs/CharacterGeneral.cpp d3eead6
> plugins/textshape/dialogs/FormattingPreview.cpp 1ed3b83
> plugins/textshape/dialogs/StyleManager.h a45a58a
> plugins/textshape/dialogs/StyleManager.cpp c561d35
> plugins/textshape/dialogs/StylesModel.cpp 80ea48d
>
> Diff: http://git.reviewboard.kde.org/r/108444/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pierre Stirnweiss
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108444/">http://git.reviewboard.kde.org/r/108444/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit eb2696c33941d0c62cd23fbb75b0fa3c7c957c55 by Pierre Stirnweiss \
to branch calligra/2.6.</pre> <br />
<p>- Commit</p>
<br />
<p>On January 18th, 2013, 2:09 p.m. UTC, Pierre Stirnweiss wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra and Friedrich W. H. Kossebau.</div>
<div>By Pierre Stirnweiss.</div>
<p style="color: grey;"><i>Updated Jan. 18, 2013, 2:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When creating a new character style, Words crashed because an null \
pointer was passed around and used. Also, the name of the style was not \
updated.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=313233">313233</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/textshape/dialogs/CharacterGeneral.cpp <span style="color: \
grey">(d3eead6)</span></li>
<li>plugins/textshape/dialogs/FormattingPreview.cpp <span style="color: \
grey">(1ed3b83)</span></li>
<li>plugins/textshape/dialogs/StyleManager.h <span style="color: \
grey">(a45a58a)</span></li>
<li>plugins/textshape/dialogs/StyleManager.cpp <span style="color: \
grey">(c561d35)</span></li>
<li>plugins/textshape/dialogs/StylesModel.cpp <span style="color: \
grey">(80ea48d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108444/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic