'Review Request 108444: Fix cash on creating new character style'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Review Request 108444: Fix cash on creating new character style
From:       "Pierre Stirnweiss" <pstirnweiss () googlemail ! com>
Date:       2013-01-16 20:45:11
Message-ID: 20130116204511.11954.36841 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108444/
-----------------------------------------------------------

Review request for Calligra and Friedrich W. H. Kossebau.

Description
-------

When creating a new character style, Words crashed because an null pointer was passed \
around and used. Also, the name of the style was not updated.

This addresses bug 313233.
    http://bugs.kde.org/show_bug.cgi?id=313233

Diffs
-----

  plugins/textshape/dialogs/StylesModel.cpp 80ea48d 
  plugins/textshape/dialogs/StyleManager.cpp c561d35 
  plugins/textshape/dialogs/StyleManager.h a45a58a 
  plugins/textshape/dialogs/FormattingPreview.cpp 1ed3b83 
  plugins/textshape/dialogs/CharacterGeneral.cpp d3eead6 

Diff: http://git.reviewboard.kde.org/r/108444/diff/

Testing
-------

Thanks,

Pierre Stirnweiss

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108444/">http://git.reviewboard.kde.org/r/108444/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra and Friedrich W. H. Kossebau.</div>
<div>By Pierre Stirnweiss.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When creating a new character style, Words crashed because an null \
pointer was passed around and used. Also, the name of the style was not \
updated.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=313233">313233</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/textshape/dialogs/StylesModel.cpp <span style="color: \
grey">(80ea48d)</span></li>

 <li>plugins/textshape/dialogs/StyleManager.cpp <span style="color: \
grey">(c561d35)</span></li>

 <li>plugins/textshape/dialogs/StyleManager.h <span style="color: \
grey">(a45a58a)</span></li>

 <li>plugins/textshape/dialogs/FormattingPreview.cpp <span style="color: \
grey">(1ed3b83)</span></li>

 <li>plugins/textshape/dialogs/CharacterGeneral.cpp <span style="color: \
grey">(d3eead6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108444/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 