'Review Request: Merge textshape-stylesWidget-PierreSt in master'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Review Request: Merge textshape-stylesWidget-PierreSt in master
From:       "Pierre Stirnweiss" <pstirnweiss () googlemail ! com>
Date:       2013-01-01 9:55:11
Message-ID: 20130101095511.13161.37193 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108060/
-----------------------------------------------------------

Review request for Calligra, Inge Wallin and C. Boemann.

Description
-------

The branch has now functional StylesCombo with sorting of styles according =
to usage. The titles could use some artist/usability skills in order to sta=
nd out a bit more. However this is outside of my reach.
There are some unused/commented out code that are foundations for later wor=
k i plan on doing.

Diffs
-----

  plugins/textshape/dialogs/AbstractStylesModel.h 6fddd0e =

  plugins/textshape/dialogs/DockerStylesComboModel.h 933c83d =

  plugins/textshape/dialogs/DockerStylesComboModel.cpp be83819 =

  plugins/textshape/dialogs/SimpleCharacterWidget.h 71fc022 =

  plugins/textshape/dialogs/SimpleCharacterWidget.cpp 744b8b9 =

  plugins/textshape/dialogs/SimpleParagraphWidget.h 6e0bed5 =

  plugins/textshape/dialogs/SimpleParagraphWidget.cpp 7337242 =

  plugins/textshape/dialogs/StylesCombo.h 4916ff1 =

  plugins/textshape/dialogs/StylesCombo.cpp 470903a =

  plugins/textshape/dialogs/StylesDelegate.cpp 9ad9de5 =

  plugins/textshape/dialogs/StylesFilteredModelBase.h 4a81c0a =

  plugins/textshape/dialogs/StylesFilteredModelBase.cpp f448a3c =

  plugins/textshape/dialogs/StylesModel.h c904d39 =

  plugins/textshape/dialogs/StylesModel.cpp 5c42ff4 =

Diff: http://git.reviewboard.kde.org/r/108060/diff/

Testing
-------

Played around with the combo. Also fixed some issues spotted by Boemann ear=
lier.

Thanks,

Pierre Stirnweiss

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108060/">http://git.reviewboard.kde.org/r/108060/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra, Inge Wallin and C. Boemann.</div>
<div>By Pierre Stirnweiss.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The branch has now functional StylesCombo with sorting of styles \
according to usage. The titles could use some artist/usability skills in order to \
stand out a bit more. However this is outside of my reach. There are some \
unused/commented out code that are foundations for later work i plan on doing. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Played around with the combo. Also fixed some issues spotted by Boemann \
earlier.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/textshape/dialogs/AbstractStylesModel.h <span style="color: \
grey">(6fddd0e)</span></li>

 <li>plugins/textshape/dialogs/DockerStylesComboModel.h <span style="color: \
grey">(933c83d)</span></li>

 <li>plugins/textshape/dialogs/DockerStylesComboModel.cpp <span style="color: \
grey">(be83819)</span></li>

 <li>plugins/textshape/dialogs/SimpleCharacterWidget.h <span style="color: \
grey">(71fc022)</span></li>

 <li>plugins/textshape/dialogs/SimpleCharacterWidget.cpp <span style="color: \
grey">(744b8b9)</span></li>

 <li>plugins/textshape/dialogs/SimpleParagraphWidget.h <span style="color: \
grey">(6e0bed5)</span></li>

 <li>plugins/textshape/dialogs/SimpleParagraphWidget.cpp <span style="color: \
grey">(7337242)</span></li>

 <li>plugins/textshape/dialogs/StylesCombo.h <span style="color: \
grey">(4916ff1)</span></li>

 <li>plugins/textshape/dialogs/StylesCombo.cpp <span style="color: \
grey">(470903a)</span></li>

 <li>plugins/textshape/dialogs/StylesDelegate.cpp <span style="color: \
grey">(9ad9de5)</span></li>

 <li>plugins/textshape/dialogs/StylesFilteredModelBase.h <span style="color: \
grey">(4a81c0a)</span></li>

 <li>plugins/textshape/dialogs/StylesFilteredModelBase.cpp <span style="color: \
grey">(f448a3c)</span></li>

 <li>plugins/textshape/dialogs/StylesModel.h <span style="color: \
grey">(c904d39)</span></li>

 <li>plugins/textshape/dialogs/StylesModel.cpp <span style="color: \
grey">(5c42ff4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108060/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 