From calligra-devel Sun Nov 18 10:59:41 2012 From: "Boudewijn Rempt" Date: Sun, 18 Nov 2012 10:59:41 +0000 To: calligra-devel Subject: Re: Review Request: Move fileproperties plugin out of libs/main into tools/properties (and make it w Message-Id: <20121118105941.17074.33928 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=calligra-devel&m=135325638529401 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4729522425716024958==" --===============4729522425716024958== Content-Type: multipart/alternative; boundary="===============8362426402668049185==" --===============8362426402668049185== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107353/#review22159 ----------------------------------------------------------- Ship it! I agree with the move. Have you checked with the author, David Faure, wheth= er he had any reason to keep it in libs/main? = - Boudewijn Rempt On Nov. 17, 2012, 2:58 a.m., Friedrich W. H. Kossebau wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107353/ > ----------------------------------------------------------- > = > (Updated Nov. 17, 2012, 2:58 a.m.) > = > = > Review request for Calligra. > = > = > Description > ------- > = > Did you know that Calligra also installs a fileproperties dialog plugin, = to show the general meta data and the author info? > = > I did not, until I wondered where those pages in the fileproperties dialo= g plugin came from (e.g. select "Properties" on a ODF file in Dolphin and s= elect the "General" or "Last saved by" tabs). > This plugin better lives next to its cousin, the thumbnailer plugin, in t= he tools part of the sources tree (even if developing tools and user tools = ideally would be in separate tree branches in the sources). > So the attached patch moves all files belonging to this plugin into the n= ew dir "tools/properties" (any better name proposal?). Additionally it make= s it also work again, by teaching KoDocumentInfoDlg to also deal with a KoD= ocumentInfo object without an attached KoDocument, like in the case of the = fileproperties plugin, and turning off the entries in the "General" tab whi= ch are redundant in the fileproperties dialog (path & type). > = > Okay to backport to 2.6? > = > Setting the Authors profile does not work correctly currently, but that i= s a separate problem I will look next into. The dialog shows at least any s= et Author info correctly. > = > = > Diffs > ----- > = > libs/main/CMakeLists.txt ae68a2b = > libs/main/KoDocInfoPropsFactory.cpp c1d89b9 = > libs/main/KoDocumentInfoDlg.cpp 920c05c = > libs/main/koDocumentInfoAboutWidget.ui a5133ed = > libs/main/kodocinfopropspage.desktop 5acfbc0 = > tools/CMakeLists.txt b0eb900 = > tools/properties/CMakeLists.txt PRE-CREATION = > tools/properties/KoDocInfoPropsFactory.cpp PRE-CREATION = > tools/properties/calligradocinfopropspage.desktop PRE-CREATION = > = > Diff: http://git.reviewboard.kde.org/r/107353/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Friedrich W. H. Kossebau > = > --===============8362426402668049185== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107353/

Ship it!

I agree wi=
th the move. Have you checked with the author, David Faure, whether he had =
any reason to keep it in libs/main?

- Boudewijn


On November 17th, 2012, 2:58 a.m., Friedrich W. H. Kossebau wrote:

Review request for Calligra.
By Friedrich W. H. Kossebau.

Updated Nov. 17, 2012, 2:58 a.m.

Descripti= on 

Did you know that Calligra also installs a fileproperties di=
alog plugin, to show the general meta data and the author info?

I did not, until I wondered where those pages in the fileproperties dialog =
plugin came from (e.g. select "Properties" on a ODF file in Dolph=
in and select the "General" or "Last saved by" tabs).
This plugin better lives next to its cousin, the thumbnailer plugin, in the=
 tools part of the sources tree (even if developing tools and user tools id=
eally would be in separate tree branches in the sources).
So the attached patch moves all files belonging to this plugin into the new=
 dir "tools/properties" (any better name proposal?). Additionally=
 it makes it also work again, by teaching KoDocumentInfoDlg to also deal wi=
th a KoDocumentInfo object without an attached KoDocument, like in the case=
 of the fileproperties plugin, and turning off the entries in the "Gen=
eral" tab which are redundant in the fileproperties dialog (path &=
 type).

Okay to backport to 2.6?

Setting the Authors profile does not work correctly currently, but that is =
a separate problem I will look next into. The dialog shows at least any set=
 Author info correctly.

Diffs=

  • libs/main/CMakeLists.txt (ae68a2b)<= /li>
  • libs/main/KoDocInfoPropsFactory.cpp (c1d89= b9)
  • libs/main/KoDocumentInfoDlg.cpp (920c05c)<= /span>
  • libs/main/koDocumentInfoAboutWidget.ui (a5= 133ed)
  • libs/main/kodocinfopropspage.desktop (5acf= bc0)
  • tools/CMakeLists.txt (b0eb900)
  • tools/properties/CMakeLists.txt (PRE-CREAT= ION)
  • tools/properties/KoDocInfoPropsFactory.cpp (PRE-CREATION)
  • tools/properties/calligradocinfopropspage.desktop (PRE-CREATION)

View Diff
--===============8362426402668049185==-- --===============4729522425716024958== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel --===============4729522425716024958==--