[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request: Move fileproperties plugin out of libs/main into tools/properties (and make it w
From: "Friedrich W. H. Kossebau" <kossebau () kde ! org>
Date: 2012-11-18 13:36:11
Message-ID: 20121118133611.28732.3216 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107353/
-----------------------------------------------------------
(Updated Nov. 18, 2012, 1:36 p.m.)
Review request for Calligra and David Faure.
Changes
-------
Adding David to requested reviewers, for the answer to Boud's question "whe=
ther he had any reason to keep it in libs/main?".
Description (updated)
-------
Did you know that Calligra also installs a fileproperties dialog plugin, to=
show the general meta data and the author info?
I did not, until I wondered where those pages in the fileproperties dialog =
plugin came from (e.g. select "Properties" on a ODF file in Dolphin and sel=
ect the "General" or "Last saved by" tabs).
This plugin better lives next to its cousin, the thumbnailer plugin, in the=
tools part of the sources tree (even if developing tools and user tools id=
eally would be in separate tree branches in the sources).
So the attached patch moves all files belonging to this plugin into the new=
dir "tools/properties" (any better name proposal?). Additionally it makes =
it also work again, by teaching KoDocumentInfoDlg to also deal with a KoDoc=
umentInfo object without an attached KoDocument, like in the case of the fi=
leproperties plugin, and turning off the entries in the "General" tab which=
are redundant in the fileproperties dialog (path & type).
Okay to backport to 2.6?
Setting the Authors profile does not work correctly currently, but that is =
a separate problem I will look next into. The dialog shows at least any set=
Author info correctly.
Background info:
* the kpropsdlg plugin was originally added to lib/kofficecore by Simon Hau=
smann with what is now 642a4005ee5be7844efcd97090c135180bad3e07 (back in 20=
00)
* it was resurrected by David Faure and kept in libs/main (successor of lib=
/kofficecore) with 64b06543d48444a10caf21389a028bdc1300c43b (in 2010)
Diffs
-----
libs/main/CMakeLists.txt ae68a2b =
libs/main/KoDocInfoPropsFactory.cpp c1d89b9 =
libs/main/KoDocumentInfoDlg.cpp 920c05c =
libs/main/koDocumentInfoAboutWidget.ui a5133ed =
libs/main/kodocinfopropspage.desktop 5acfbc0 =
tools/CMakeLists.txt b0eb900 =
tools/properties/CMakeLists.txt PRE-CREATION =
tools/properties/KoDocInfoPropsFactory.cpp PRE-CREATION =
tools/properties/calligradocinfopropspage.desktop PRE-CREATION =
Diff: http://git.reviewboard.kde.org/r/107353/diff/
Testing
-------
Thanks,
Friedrich W. H. Kossebau
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107353/">http://git.reviewboard.kde.org/r/107353/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra and David Faure.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Nov. 18, 2012, 1:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding David to requested reviewers, for the answer to Boud's \
question "whether he had any reason to keep it in libs/main?". </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Did you know that Calligra also installs a fileproperties dialog plugin, \
to show the general meta data and the author info?
I did not, until I wondered where those pages in the fileproperties dialog plugin \
came from (e.g. select "Properties" on a ODF file in Dolphin and select the \
"General" or "Last saved by" tabs). This plugin better lives next \
to its cousin, the thumbnailer plugin, in the tools part of the sources tree (even if \
developing tools and user tools ideally would be in separate tree branches in the \
sources). So the attached patch moves all files belonging to this plugin into the new \
dir "tools/properties" (any better name proposal?). Additionally it makes \
it also work again, by teaching KoDocumentInfoDlg to also deal with a KoDocumentInfo \
object without an attached KoDocument, like in the case of the fileproperties plugin, \
and turning off the entries in the "General" tab which are redundant in the \
fileproperties dialog (path & type).
Okay to backport to 2.6?
Setting the Authors profile does not work correctly currently, but that is a separate \
problem I will look next into. The dialog shows at least any set Author info \
correctly.
Background info:
* the kpropsdlg plugin was originally added to lib/kofficecore by Simon Hausmann with \
what is now 642a4005ee5be7844efcd97090c135180bad3e07 (back in 2000)
* it was resurrected by David Faure and kept in libs/main (successor of \
lib/kofficecore) with 64b06543d48444a10caf21389a028bdc1300c43b (in 2010)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/main/CMakeLists.txt <span style="color: grey">(ae68a2b)</span></li>
<li>libs/main/KoDocInfoPropsFactory.cpp <span style="color: \
grey">(c1d89b9)</span></li>
<li>libs/main/KoDocumentInfoDlg.cpp <span style="color: grey">(920c05c)</span></li>
<li>libs/main/koDocumentInfoAboutWidget.ui <span style="color: \
grey">(a5133ed)</span></li>
<li>libs/main/kodocinfopropspage.desktop <span style="color: \
grey">(5acfbc0)</span></li>
<li>tools/CMakeLists.txt <span style="color: grey">(b0eb900)</span></li>
<li>tools/properties/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tools/properties/KoDocInfoPropsFactory.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>tools/properties/calligradocinfopropspage.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107353/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic