'Re: Review Request: Adding 18n support for calligra active'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request: Adding 18n support for calligra active
From:       "Sujith Haridasan" <sujith.h () gmail ! com>
Date:       2012-10-27 4:58:33
Message-ID: 20121027045833.23598.86424 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107064/
-----------------------------------------------------------

(Updated Oct. 27, 2012, 4:58 a.m.)

Review request for Calligra and Shantanu Tushar Jha.

Changes
-------

Fixed the issues mentioned in the previous patch as review. The following f=
ixes are done:

1)PresentationTopToolbar.qml : i18n("Slide %1 of %2", root.documentControll=
er.documentHandler.currentSlideNumber, root.documentController.documentHand=
ler.totalNumberOfSlides)

2) TextDocumentCenterOverlay.qml : i18n("Page %1", (index + 1))

Thank's Yuri Chornoivan for the valuable comments.

Description
-------

Adding i18n support for the calligra active.

Diffs (updated)
-----

  active/qml/PresentationFindToolbar.qml 3102954 =

  active/qml/PresentationTopToolbar.qml bf06418 =

  active/qml/SpreadsheetFindToolbar.qml 9fd34ff =

  active/qml/TextDocumentCenterOverlay.qml 2a1ee93 =

  active/qml/TextDocumentFindToolbar.qml 71996d8 =

Diff: http://git.reviewboard.kde.org/r/107064/diff/

Testing
-------

Tested with sample doc, presentation and spreadsheet.

Thanks,

Sujith Haridasan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107064/">http://git.reviewboard.kde.org/r/107064/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra and Shantanu Tushar Jha.</div>
<div>By Sujith Haridasan.</div>

<p style="color: grey;"><i>Updated Oct. 27, 2012, 4:58 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed the issues mentioned in the previous patch as review. The \
following fixes are done:

1)PresentationTopToolbar.qml : i18n(&quot;Slide %1 of %2&quot;, \
root.documentController.documentHandler.currentSlideNumber, \
root.documentController.documentHandler.totalNumberOfSlides)

2) TextDocumentCenterOverlay.qml : i18n(&quot;Page %1&quot;, (index + 1))

Thank&#39;s Yuri Chornoivan for the valuable comments.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adding i18n support for the calligra active.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with sample doc, presentation and spreadsheet.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>active/qml/PresentationFindToolbar.qml <span style="color: \
grey">(3102954)</span></li>

 <li>active/qml/PresentationTopToolbar.qml <span style="color: \
grey">(bf06418)</span></li>

 <li>active/qml/SpreadsheetFindToolbar.qml <span style="color: \
grey">(9fd34ff)</span></li>

 <li>active/qml/TextDocumentCenterOverlay.qml <span style="color: \
grey">(2a1ee93)</span></li>

 <li>active/qml/TextDocumentFindToolbar.qml <span style="color: \
grey">(71996d8)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107064/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 