[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request: Fixing the text search navigation in calligra active spreadsheet
From: "Commit Hook" <null () kde ! org>
Date: 2012-10-26 18:56:49
Message-ID: 20121026185649.14258.3899 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107052/#review20970
-----------------------------------------------------------
This review has been submitted with commit 77a0ec3ec1e13e3267513f10a2f74b21=
e77c30d6 by Sujith Haridasan to branch master.
- Commit Hook
On Oct. 26, 2012, 11:43 a.m., Sujith Haridasan wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107052/
> -----------------------------------------------------------
> =
> (Updated Oct. 26, 2012, 11:43 a.m.)
> =
> =
> Review request for Calligra and Shantanu Tushar Jha.
> =
> =
> Description
> -------
> =
> The text search navigation in calligra active spreadsheet had following i=
ssues:
> =
> 1) when user searches for text in a sheet and moves to another, the searc=
h doesn't lands up in a
> proper position in next/previous sheet.
> =
> 2) There were issues with the sheet navigation with respect to the text s=
earch.
> =
> These issues are fixed using this patch.
> =
> =
> Diffs
> -----
> =
> active/src/CASpreadsheetHandler.cpp 69a59db =
> =
> Diff: http://git.reviewboard.kde.org/r/107052/diff/
> =
> =
> Testing
> -------
> =
> This is tested using a sample spreadsheet.
> =
> =
> Thanks,
> =
> Sujith Haridasan
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107052/">http://git.reviewboard.kde.org/r/107052/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 77a0ec3ec1e13e3267513f10a2f74b21e77c30d6 by Sujith Haridasan to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On October 26th, 2012, 11:43 a.m., Sujith Haridasan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra and Shantanu Tushar Jha.</div>
<div>By Sujith Haridasan.</div>
<p style="color: grey;"><i>Updated Oct. 26, 2012, 11:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The text search navigation in calligra active spreadsheet had following \
issues:
1) when user searches for text in a sheet and moves to another, the search \
doesn't lands up in a proper position in next/previous sheet.
2) There were issues with the sheet navigation with respect to the text search.
These issues are fixed using this patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is tested using a sample spreadsheet.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>active/src/CASpreadsheetHandler.cpp <span style="color: \
grey">(69a59db)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107052/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic