[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request: Add support for overwriting object with the same name
From: "Oleg Kukharchuk" <oleg.kuh () gmail ! com>
Date: 2012-10-16 9:46:48
Message-ID: 20121016094648.5338.74208 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106903/#review20448
-----------------------------------------------------------
Ship it!
Ship It!
- Oleg Kukharchuk
On Oct. 15, 2012, 8:57 p.m., Jarosław Staniek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106903/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2012, 8:57 p.m.)
>
>
> Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.
>
>
> Description
> -------
>
> If name of existing object is picked when saving a new object, the existing object \
> should be removed and replaced by the new one.
>
> This addresses bug 308461.
> http://bugs.kde.org/show_bug.cgi?id=308461
>
>
> Diffs
> -----
>
> kexi/core/KexiMainWindowIface.h 64e3ec7a7656b23c277af8b036f74b9b22217916
> kexi/core/KexiView.h b089043be77d35f136f0e16b8ab1ed5171f2ac77
> kexi/core/KexiView.cpp 38131625dd8f2df5bf6f3b6c265994eb843e3987
> kexi/core/KexiWindow.h e920bad76b10dabc381ac87b5a4c00db98b7e8c9
> kexi/core/KexiWindow.cpp 98cf1691bf61784a8b1547c9073cdb62d14c3ac0
> kexi/core/kexiproject.cpp aea53ae20d5c637a767580c03ddff3ed2174fbaf
> kexi/main/CMakeLists.txt f0f926f5f7d5fb45869ed5e3b6b67512439f7d9a
> kexi/main/KexiMainWindow.h 4640946e9f610d8be51d3a02fd463edea6036028
> kexi/main/KexiMainWindow.cpp 6140fc9d63b4afd90d6f7d454cc5344caade8e26
> kexi/main/kexinamedialog.h c32c4aaeb43792f04f8c5a92a5865d9bbb078140
> kexi/main/kexinamedialog.cpp d1a6b6c12c30ebc7efe0160a5b966455804ccb7d
> kexi/main/kexinamewidget.h 870c3668128798b25ab7d646393c5c6eb9086b9a
> kexi/main/kexinamewidget.cpp 588a48bee449c41638710de94d231eb279b8e809
> kexi/plugins/autoforms/KexiAutoFormDesignView.h \
> 00e5673be6a985cfec9831b4ab48217ffa994680 \
> kexi/plugins/autoforms/KexiAutoFormDesignView.cpp \
> 648800c51c17f022a2ac0c78911bf2ca5bb2ed95 kexi/plugins/forms/kexiformview.h \
> 72fe54ba37159a47e914338a57c6af6a522a79aa kexi/plugins/forms/kexiformview.cpp \
> 4cc42346e2387f0da40620d45593290fcf9b7260 \
> kexi/plugins/importexport/csv/kexicsvimportdialog.cpp \
> 18fafd486c13cfae943f2af0078fca93b83c4315 \
> kexi/plugins/queries/kexiquerydesignerguieditor.h \
> 312d1426a55c716acd5a4e902adf1b978088c494 \
> kexi/plugins/queries/kexiquerydesignerguieditor.cpp \
> 422f48d22649168b74a148e630407f8e1e46c9d0 \
> kexi/plugins/queries/kexiquerydesignersql.h \
> ca1a7ff4b7c15d0737d57f05892a5896be0d0358 \
> kexi/plugins/queries/kexiquerydesignersql.cpp \
> 0ebfe28e1ef1d8e4f53efc568b3e85c868632631 kexi/plugins/queries/kexiqueryview.h \
> fd750b87b9b38afe78a1fd3db7c5fded4c9ca54b kexi/plugins/queries/kexiqueryview.cpp \
> 483dc6392458dbb92704bbe1a22f8dc333aa60c7 \
> kexi/plugins/reports/kexireportdesignview.h \
> a893028c863977f2c2304f4a10a130f022b213da \
> kexi/plugins/reports/kexireportdesignview.cpp \
> 17212f21fbc455cc5ccaf89d5bd81ef759d1942d \
> kexi/plugins/scripting/kexiscripting/kexiscriptdesignview.h \
> b2307662ed94d3e7f511557528cdcccf0e0ec091 \
> kexi/plugins/scripting/kexiscripting/kexiscriptdesignview.cpp \
> 8e247f6f1e3af56ec017270d1f5b88026b12283b \
> kexi/plugins/tables/kexitabledesignerview.h \
> 10a6eba4769f47ddec068d765341b24a5c1ff8fd \
> kexi/plugins/tables/kexitabledesignerview.cpp \
> ec92bde924279bb95b90315469ac1b52856ecee9 kexi/widget/CMakeLists.txt \
> 2d5c0ab6c02394e93565577baa6ba9b851b4c1f8 kexi/widget/KexiNameDialog.h PRE-CREATION \
> kexi/widget/KexiNameDialog.cpp PRE-CREATION
> kexi/widget/KexiNameWidget.h PRE-CREATION
> kexi/widget/KexiNameWidget.cpp PRE-CREATION
> libs/db/connection.h 28ddbfabd2c2086fa80b5dec44c1ad1b9a4faf5b
> libs/db/connection.cpp 90330da044cd8cb56b23640421038089f0717812
> libs/db/drivers/sqlite/sqliteconnection.cpp \
> 2ffaf312c22f3cf0266670d4d8a55ed0f7c1cb0d libs/db/utils.cpp \
> d5a361abce1701650ee0cfbc06274697d8172a11
> Diff: http://git.reviewboard.kde.org/r/106903/diff/
>
>
> Testing
> -------
>
> Properly replaces existing objects
>
>
> Thanks,
>
> Jarosław Staniek
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106903/">http://git.reviewboard.kde.org/r/106903/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Oleg</p>
<br />
<p>On October 15th, 2012, 8:57 p.m., Jarosław Staniek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg \
Kukharchuk.</div> <div>By Jarosław Staniek.</div>
<p style="color: grey;"><i>Updated Oct. 15, 2012, 8:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If name of existing object is picked when saving a new object, the \
existing object should be removed and replaced by the new one.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Properly replaces existing objects</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=308461">308461</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kexi/core/KexiMainWindowIface.h <span style="color: \
grey">(64e3ec7a7656b23c277af8b036f74b9b22217916)</span></li>
<li>kexi/core/KexiView.h <span style="color: \
grey">(b089043be77d35f136f0e16b8ab1ed5171f2ac77)</span></li>
<li>kexi/core/KexiView.cpp <span style="color: \
grey">(38131625dd8f2df5bf6f3b6c265994eb843e3987)</span></li>
<li>kexi/core/KexiWindow.h <span style="color: \
grey">(e920bad76b10dabc381ac87b5a4c00db98b7e8c9)</span></li>
<li>kexi/core/KexiWindow.cpp <span style="color: \
grey">(98cf1691bf61784a8b1547c9073cdb62d14c3ac0)</span></li>
<li>kexi/core/kexiproject.cpp <span style="color: \
grey">(aea53ae20d5c637a767580c03ddff3ed2174fbaf)</span></li>
<li>kexi/main/CMakeLists.txt <span style="color: \
grey">(f0f926f5f7d5fb45869ed5e3b6b67512439f7d9a)</span></li>
<li>kexi/main/KexiMainWindow.h <span style="color: \
grey">(4640946e9f610d8be51d3a02fd463edea6036028)</span></li>
<li>kexi/main/KexiMainWindow.cpp <span style="color: \
grey">(6140fc9d63b4afd90d6f7d454cc5344caade8e26)</span></li>
<li>kexi/main/kexinamedialog.h <span style="color: \
grey">(c32c4aaeb43792f04f8c5a92a5865d9bbb078140)</span></li>
<li>kexi/main/kexinamedialog.cpp <span style="color: \
grey">(d1a6b6c12c30ebc7efe0160a5b966455804ccb7d)</span></li>
<li>kexi/main/kexinamewidget.h <span style="color: \
grey">(870c3668128798b25ab7d646393c5c6eb9086b9a)</span></li>
<li>kexi/main/kexinamewidget.cpp <span style="color: \
grey">(588a48bee449c41638710de94d231eb279b8e809)</span></li>
<li>kexi/plugins/autoforms/KexiAutoFormDesignView.h <span style="color: \
grey">(00e5673be6a985cfec9831b4ab48217ffa994680)</span></li>
<li>kexi/plugins/autoforms/KexiAutoFormDesignView.cpp <span style="color: \
grey">(648800c51c17f022a2ac0c78911bf2ca5bb2ed95)</span></li>
<li>kexi/plugins/forms/kexiformview.h <span style="color: \
grey">(72fe54ba37159a47e914338a57c6af6a522a79aa)</span></li>
<li>kexi/plugins/forms/kexiformview.cpp <span style="color: \
grey">(4cc42346e2387f0da40620d45593290fcf9b7260)</span></li>
<li>kexi/plugins/importexport/csv/kexicsvimportdialog.cpp <span style="color: \
grey">(18fafd486c13cfae943f2af0078fca93b83c4315)</span></li>
<li>kexi/plugins/queries/kexiquerydesignerguieditor.h <span style="color: \
grey">(312d1426a55c716acd5a4e902adf1b978088c494)</span></li>
<li>kexi/plugins/queries/kexiquerydesignerguieditor.cpp <span style="color: \
grey">(422f48d22649168b74a148e630407f8e1e46c9d0)</span></li>
<li>kexi/plugins/queries/kexiquerydesignersql.h <span style="color: \
grey">(ca1a7ff4b7c15d0737d57f05892a5896be0d0358)</span></li>
<li>kexi/plugins/queries/kexiquerydesignersql.cpp <span style="color: \
grey">(0ebfe28e1ef1d8e4f53efc568b3e85c868632631)</span></li>
<li>kexi/plugins/queries/kexiqueryview.h <span style="color: \
grey">(fd750b87b9b38afe78a1fd3db7c5fded4c9ca54b)</span></li>
<li>kexi/plugins/queries/kexiqueryview.cpp <span style="color: \
grey">(483dc6392458dbb92704bbe1a22f8dc333aa60c7)</span></li>
<li>kexi/plugins/reports/kexireportdesignview.h <span style="color: \
grey">(a893028c863977f2c2304f4a10a130f022b213da)</span></li>
<li>kexi/plugins/reports/kexireportdesignview.cpp <span style="color: \
grey">(17212f21fbc455cc5ccaf89d5bd81ef759d1942d)</span></li>
<li>kexi/plugins/scripting/kexiscripting/kexiscriptdesignview.h <span style="color: \
grey">(b2307662ed94d3e7f511557528cdcccf0e0ec091)</span></li>
<li>kexi/plugins/scripting/kexiscripting/kexiscriptdesignview.cpp <span \
style="color: grey">(8e247f6f1e3af56ec017270d1f5b88026b12283b)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.h <span style="color: \
grey">(10a6eba4769f47ddec068d765341b24a5c1ff8fd)</span></li>
<li>kexi/plugins/tables/kexitabledesignerview.cpp <span style="color: \
grey">(ec92bde924279bb95b90315469ac1b52856ecee9)</span></li>
<li>kexi/widget/CMakeLists.txt <span style="color: \
grey">(2d5c0ab6c02394e93565577baa6ba9b851b4c1f8)</span></li>
<li>kexi/widget/KexiNameDialog.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kexi/widget/KexiNameDialog.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kexi/widget/KexiNameWidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kexi/widget/KexiNameWidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/db/connection.h <span style="color: \
grey">(28ddbfabd2c2086fa80b5dec44c1ad1b9a4faf5b)</span></li>
<li>libs/db/connection.cpp <span style="color: \
grey">(90330da044cd8cb56b23640421038089f0717812)</span></li>
<li>libs/db/drivers/sqlite/sqliteconnection.cpp <span style="color: \
grey">(2ffaf312c22f3cf0266670d4d8a55ed0f7c1cb0d)</span></li>
<li>libs/db/utils.cpp <span style="color: \
grey">(d5a361abce1701650ee0cfbc06274697d8172a11)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106903/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic