'Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y
From:       "Elvis Stansvik" <elvstone () gmail ! com>
Date:       2012-07-19 9:34:40
Message-ID: 20120719093440.7713.55545 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104804/
-----------------------------------------------------------

(Updated July 19, 2012, 9:34 a.m.)

Review request for Calligra, Matus Hanzes, Thorsten Zachmann, and C. \
Boemann.

Changes
-------

* Incorporated fix for useStretchPoints(...) from Thorsten.
* Improved docs for useStretchPoints(...) a bit.
* Removed unused 'matrix2' variable.

Many thanks Thorsten, I've just been swamped with school.

Description
-------

This patch adds support for path-stretchpoint-x and path-stretchpoint-y to \
the enhanced path shape. All credit for the patch goes to Matus. I simply \
found it at [1] where it seems to have been forgotten (filed against \
KOffice by mistake?).

[1] https://svn.reviewboard.kde.org/r/5978

This addresses bug 258267.
    http://bugs.kde.org/show_bug.cgi?id=258267

Diffs (updated)
-----

  plugins/pathshapes/enhancedpath/EnhancedPathShape.h 97f7a8d 
  plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp 2c5c728 

Diff: http://git.reviewboard.kde.org/r/104804/diff/

Testing
-------

I tested it with the document in bug 258267.

Thanks,

Elvis Stansvik

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104804/">http://git.reviewboard.kde.org/r/104804/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;">  <tr>
  <td>

<div>Review request for Calligra, Matus Hanzes, Thorsten Zachmann, and C. \
Boemann.</div> <div>By Elvis Stansvik.</div>

<p style="color: grey;"><i>Updated July 19, 2012, 9:34 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Changes</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">* Incorporated fix for useStretchPoints(...) \
                from Thorsten.
* Improved docs for useStretchPoints(...) a bit.
* Removed unused &#39;matrix2&#39; variable.

Many thanks Thorsten, I&#39;ve just been swamped with school.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for path-stretchpoint-x and \
path-stretchpoint-y to the enhanced path shape. All credit for the patch \
goes to Matus. I simply found it at [1] where it seems to have been \
forgotten (filed against KOffice by mistake?).

[1] https://svn.reviewboard.kde.org/r/5978</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tested it with the document in bug 258267.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=258267">258267</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/pathshapes/enhancedpath/EnhancedPathShape.h <span \
style="color: grey">(97f7a8d)</span></li>

 <li>plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp <span \
style="color: grey">(2c5c728)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104804/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 