[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request: renaming style and add new style
From: Pierre Stirnweiss <pstirnweiss () googlemail ! com>
Date: 2012-05-23 14:05:42
Message-ID: CAOjaSmjW0Ldfo3SqYRXC=mO1w5ZJ1-xFOBPrvJ+rEJvZcY6TaQ () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Something like AddUnvalidatedStyle or AddDraftStyle. I'll post some more if
I think of anything else
On Wed, May 23, 2012 at 3:46 PM, C. Boemann <cbo@boemann.dk> wrote:
> On Wednesday 23 May 2012 15:41:43 Pierre Stirnweiss wrote:
> > And since this list uses the styleModel, I see the use case now, even if
> in
> > my mind it is a bit verging on the abuse of the model.
> > I am not so sure about the stylesModel API pollution (method
> > AddNewParagraphStyle) however. Is there a way to make clearer what this
> > really is? Such things otherwise tend to be wrongly used down the line
> > (undo/redo framework is a perfect example). I can already see someone in
> a
> > couple of months looking at the stylesModel API and see
> > AddNewParagraphStyle and think well, that is how you add a new style.
> > For example can't we make that a private method with a less generic name
> > and friend the appropriate classes?
>
> Yes you are right. Right now moji is just trying to get the functionality
> working. I'm not so concerned with the details. After all I am the one who
> asked him to put up this review hald finished and maybe not even
> compiling, to
> just get a glimpse, not to do a review
>
> But if you have an idea for a name please suggest
> _______________________________________________
> calligra-devel mailing list
> calligra-devel@kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
>
[Attachment #5 (text/html)]
Something like AddUnvalidatedStyle or AddDraftStyle. I'll post some more if I \
think of anything else<br><br><div class="gmail_quote">On Wed, May 23, 2012 at 3:46 \
PM, C. Boemann <span dir="ltr"><<a href="mailto:cbo@boemann.dk" \
target="_blank">cbo@boemann.dk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div class="im">On Wednesday 23 May 2012 15:41:43 \
Pierre Stirnweiss wrote:<br> > And since this list uses the styleModel, I see the \
use case now, even if in<br> > my mind it is a bit verging on the abuse of the \
model.<br> > I am not so sure about the stylesModel API pollution (method<br>
> AddNewParagraphStyle) however. Is there a way to make clearer what this<br>
> really is? Such things otherwise tend to be wrongly used down the line<br>
> (undo/redo framework is a perfect example). I can already see someone in a<br>
> couple of months looking at the stylesModel API and see<br>
> AddNewParagraphStyle and think well, that is how you add a new style.<br>
> For example can't we make that a private method with a less generic name<br>
> and friend the appropriate classes?<br>
<br>
</div>Yes you are right. Right now moji is just trying to get the functionality<br>
working. I'm not so concerned with the details. After all I am the one who<br>
asked him to put up this review hald finished and maybe not even compiling, to<br>
just get a glimpse, not to do a review<br>
<br>
But if you have an idea for a name please suggest<br>
<div class="HOEnZb"><div \
class="h5">_______________________________________________<br> calligra-devel mailing \
list<br> <a href="mailto:calligra-devel@kde.org">calligra-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/calligra-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/calligra-devel</a><br> \
</div></div></blockquote></div><br>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic