'Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y
From:       "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date:       2012-05-09 4:45:22
Message-ID: 20120509044522.17760.4634 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104804/#review13598
-----------------------------------------------------------

I have taken another run. In total it looks quite good however there are 3 files \
which seems to be wrong after the patch. Stangely it contains a object that was \
nearly the same as the last time and that was fixed.

I have uploaded the files to http://www.zagge.de/anchor/stretch/

hench-maths.wikispaces.com%2Ffile%2Fview%2FAdding+and+Subtracting+Fractions.ppt

On slide 2 the house is deformed.

www.setoolbelt.org%2Fsystem%2Ffiles%2Fresources%2FTOCs_and_Logic_Models_forAEA_1%30%309_1%30%309.odp

On slide 1 the rounding next to the line is to short. Also it seems to be no longer \
possible to resize the shape in question. (Please note that you need to unlock the \
page to ungroup and change the object). Without the patch the shape looks ok and can \
be resized. Also with the patch the object from the last review can be resized \
without problems.

www.usa.gov%2Fwebcontent%2Fdocuments%2FMachine%20Readable%20-%20Server.ppt

On slide 7 the info i seems to be doubled

- Thorsten Zachmann

On May 8, 2012, 11:20 a.m., Elvis Stansvik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104804/
> -----------------------------------------------------------
> 
> (Updated May 8, 2012, 11:20 a.m.)
> 
> 
> Review request for Calligra, Matus Hanzes, Thorsten Zachmann, and C. Boemann.
> 
> 
> Description
> -------
> 
> This patch adds support for path-stretchpoint-x and path-stretchpoint-y to the \
> enhanced path shape. All credit for the patch goes to Matus. I simply found it at \
> [1] where it seems to have been forgotten (filed against KOffice by mistake?). 
> [1] https://svn.reviewboard.kde.org/r/5978
> 
> 
> This addresses bug 258267.
> http://bugs.kde.org/show_bug.cgi?id=258267
> 
> 
> Diffs
> -----
> 
> plugins/pathshapes/enhancedpath/EnhancedPathShape.h 1919bb1 
> plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp dc29c3a 
> 
> Diff: http://git.reviewboard.kde.org/r/104804/diff/
> 
> 
> Testing
> -------
> 
> I tested it with the document in bug 258267.
> 
> 
> Thanks,
> 
> Elvis Stansvik
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104804/">http://git.reviewboard.kde.org/r/104804/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have taken another \
run. In total it looks quite good however there are 3 files which seems to be wrong \
after the patch. Stangely it contains a object that was nearly the same as the last \
time and that was fixed.

I have uploaded the files to http://www.zagge.de/anchor/stretch/

hench-maths.wikispaces.com%2Ffile%2Fview%2FAdding+and+Subtracting+Fractions.ppt

On slide 2 the house is deformed.

www.setoolbelt.org%2Fsystem%2Ffiles%2Fresources%2FTOCs_and_Logic_Models_forAEA_1%30%309_1%30%309.odp

On slide 1 the rounding next to the line is to short. Also it seems to be no longer \
possible to resize the shape in question. (Please note that you need to unlock the \
page to ungroup and change the object). Without the patch the shape looks ok and can \
be resized. Also with the patch the object from the last review can be resized \
without problems.

www.usa.gov%2Fwebcontent%2Fdocuments%2FMachine%20Readable%20-%20Server.ppt

On slide 7 the info i seems to be doubled
</pre>
 <br />

<p>- Thorsten</p>

<br />
<p>On May 8th, 2012, 11:20 a.m., Elvis Stansvik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra, Matus Hanzes, Thorsten Zachmann, and C. \
Boemann.</div> <div>By Elvis Stansvik.</div>

<p style="color: grey;"><i>Updated May 8, 2012, 11:20 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for path-stretchpoint-x and path-stretchpoint-y \
to the enhanced path shape. All credit for the patch goes to Matus. I simply found it \
at [1] where it seems to have been forgotten (filed against KOffice by mistake?).

[1] https://svn.reviewboard.kde.org/r/5978</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tested it with the document in bug 258267.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=258267">258267</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/pathshapes/enhancedpath/EnhancedPathShape.h <span style="color: \
grey">(1919bb1)</span></li>

 <li>plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp <span style="color: \
grey">(dc29c3a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104804/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 