[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request: Text dragging in the textshapes
From: "Elvis Stansvik" <elvstone () gmail ! com>
Date: 2012-05-05 12:08:12
Message-ID: 20120505120812.16926.86832 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104773/#review13463
-----------------------------------------------------------
Ship it!
Dragging within a text shape, from/to kate and from/to stage works here (Qt=
4.8.1), so ship it!
- Elvis Stansvik
On April 29, 2012, 8:27 p.m., C. Boemann wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104773/
> -----------------------------------------------------------
> =
> (Updated April 29, 2012, 8:27 p.m.)
> =
> =
> Review request for Calligra.
> =
> =
> Description
> -------
> =
> I've implemented so you can drag text around in the text shape. It uses d=
rag and drop so you can drag to and from other applications too
> =
> =
> Diffs
> -----
> =
> libs/flake/KoCanvasControllerWidgetViewport_p.cpp fab7c5c =
> libs/flake/KoToolBase.h 0c0a9e4 =
> libs/flake/KoToolBase.cpp ae3482d =
> libs/flake/KoToolProxy.h 8273980 =
> libs/flake/KoToolProxy.cpp 1e61e5c =
> libs/kotext/KoTextDrag.h 9ad8560 =
> libs/kotext/KoTextDrag.cpp 5140785 =
> libs/kotext/KoTextEditor.h 616b320 =
> libs/kotext/KoTextEditor.cpp 60cff14 =
> libs/kotext/commands/ChangeTrackedDeleteCommand.cpp 562b726 =
> plugins/textshape/TextTool.h 5b42bb6 =
> plugins/textshape/TextTool.cpp 4078e72 =
> =
> Diff: http://git.reviewboard.kde.org/r/104773/diff/
> =
> =
> Testing
> -------
> =
> Tried it as best I could to and from kate and internally in Words.
> =
> =
> Thanks,
> =
> C. Boemann
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104773/">http://git.reviewboard.kde.org/r/104773/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Dragging within a text shape, from/to kate and from/to stage works \
here (Qt 4.8.1), so ship it!</pre> <br />
<p>- Elvis</p>
<br />
<p>On April 29th, 2012, 8:27 p.m., C. Boemann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By C. Boemann.</div>
<p style="color: grey;"><i>Updated April 29, 2012, 8:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've implemented so you can drag text \
around in the text shape. It uses drag and drop so you can drag to and from other applications too</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tried it as best I could to and from kate \
and internally in Words.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/flake/KoCanvasControllerWidgetViewport_p.cpp <span style="color: grey">(fab7c5c)</span></li>
<li>libs/flake/KoToolBase.h <span style="color: grey">(0c0a9e4)</span></li>
<li>libs/flake/KoToolBase.cpp <span style="color: grey">(ae3482d)</span></li>
<li>libs/flake/KoToolProxy.h <span style="color: grey">(8273980)</span></li>
<li>libs/flake/KoToolProxy.cpp <span style="color: grey">(1e61e5c)</span></li>
<li>libs/kotext/KoTextDrag.h <span style="color: grey">(9ad8560)</span></li>
<li>libs/kotext/KoTextDrag.cpp <span style="color: grey">(5140785)</span></li>
<li>libs/kotext/KoTextEditor.h <span style="color: grey">(616b320)</span></li>
<li>libs/kotext/KoTextEditor.cpp <span style="color: grey">(60cff14)</span></li>
<li>libs/kotext/commands/ChangeTrackedDeleteCommand.cpp <span style="color: grey">(562b726)</span></li>
<li>plugins/textshape/TextTool.h <span style="color: grey">(5b42bb6)</span></li>
<li>plugins/textshape/TextTool.cpp <span style="color: grey">(4078e72)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104773/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic