'Re: Review Request: Fixes: show RulerTabChooser in right place, not somewhere on ruler, and only if'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request: Fixes: show RulerTabChooser in right place, not somewhere on ruler, and only if
From:       Adam Pigg <piggz1 () gmail ! com>
Date:       2012-04-19 9:47:35
Message-ID: 4291240943380348824 () unknownmsgid
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

Only looked at the report designer, thanks for removing my hack :-)

--

Sent from my Nokia N9

On 19/04/2012 2:58 Friedrich W. H. Kossebau wrote:
  This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104666/
  Review request for Calligra.
By Friedrich W. H. Kossebau.

*Updated April 19, 2012, 1:58 a.m.*
Changes

And while I was at the ruler code, some more changes/fixes:
* remove no longer needed workaround to hide the tab chooser in
KoReportDesigner.cpp
* on property changes in KoRuler only call update() if the property is
shown, but call if shown
* remove unneededly doubled calls in KoRulerController.cpp

  Description

Currently in all programs (besides Words) the tab chooser is wrongly
displayed somewhere on the horizontal ruler. And also if not needed,
i.e. tabs are no property of the shape.

Attached patch fixes that:
* it puts the tab chooser in the corner for Stage and Karbon (so not
for Krita, because less text oriented)
* it only creates the tab chooser on demand, not always (so it does
not appear for Krita, like now)
* it only shows the tabs chooser if tabs are also shown in the ruler

(not sure that there should be no tab chooser for Krita)

Candidate for 2.4 backport?

  Testing

Started Krita, Karbon, Stage, Words and activated text shapes, had
rulers shown and not shown.

  Diffs (updated)

   - karbon/ui/KarbonView.cpp (2b9a907)
   - libs/kopageapp/KoPAView.cpp (fc28628)
   - libs/koreport/wrtembed/KoReportDesigner.cpp (68a61f9)
   - libs/main/KoRuler.cpp (4272b9b)
   - libs/main/KoRulerController.cpp (39a2e3b)
   - libs/main/KoRuler_p.h (bfeac46)

View Diff <http://git.reviewboard.kde.org/r/104666/diff/>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[Attachment #5 (text/html)]

<html><head></head><body><div id="fenix-user-content">
<p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px"><span \
style="font-family:&#39;NokiaPureTextLight&#39;">Only looked at the report designer, \
thanks for removing my hack :-) <br> <br>--<br></span></p>
<p style="margin-top:0px;margin-bottom:0px;margin-left:0px;margin-right:0px;text-indent:0px"><span \
style="font-family:&#39;NokiaPureTextLight&#39;">Sent from my Nokia \
N9<br></span></p></div><br><div id="fenix-reply-header"> <p>On 19/04/2012 2:58 \
Friedrich W. H. Kossebau wrote:<br></p></div><div id="fenix-quoted-body"><div>  <div \
style="font-family:Verdana,Arial,Helvetica,Sans-Serif">  <table bgcolor="#f9f3c9" \
width="100%" cellpadding="8" style="border:1px #c9c399 solid">  <tbody><tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104666/" \
target="_blank">http://git.reviewboard.kde.org/r/104666/</a>  </td>
    </tr>
   </tbody></table>
   <br>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image:url(&#39;http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png&#39;);background-repeat:repeat-x;border:1px \
black solid">

 <tbody><tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>

<p style="color:grey"><i>Updated April 19, 2012, 1:58 a.m.</i></p>

<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0">  <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">And \
                while I was at the ruler code, some more changes/fixes:
* remove no longer needed workaround to hide the tab chooser in KoReportDesigner.cpp
* on property changes in KoRuler only call update() if the property is shown, but \
                call if shown
* remove unneededly doubled calls in KoRulerController.cpp</pre>
  </td>
 </tr>
</tbody></table>

<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0">  <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Currently \
in all programs (besides Words) the tab chooser is wrongly displayed somewhere on the \
horizontal ruler. And also if not needed, i.e. tabs are no property of the shape.

Attached patch fixes that:
* it puts the tab chooser in the corner for Stage and Karbon (so not for Krita, \
                because less text oriented)
* it only creates the tab chooser on demand, not always (so it does not appear for \
                Krita, like now)
* it only shows the tabs chooser if tabs are also shown in the ruler

(not sure that there should be no tab chooser for Krita)

Candidate for 2.4 backport?</pre>
  </td>
 </tr>
</tbody></table>

<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0">  <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Started \
Krita, Karbon, Stage, Words and activated text shapes, had rulers shown and not \
shown.</pre>

  </td>
 </tr>
</tbody></table>

<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs (updated)</h1>
<ul style="margin-left:3em;padding-left:0">

 <li>karbon/ui/KarbonView.cpp <span style="color:grey">(2b9a907)</span></li>

 <li>libs/kopageapp/KoPAView.cpp <span style="color:grey">(fc28628)</span></li>

 <li>libs/koreport/wrtembed/KoReportDesigner.cpp <span \
style="color:grey">(68a61f9)</span></li>

 <li>libs/main/KoRuler.cpp <span style="color:grey">(4272b9b)</span></li>

 <li>libs/main/KoRulerController.cpp <span style="color:grey">(39a2e3b)</span></li>

 <li>libs/main/KoRuler_p.h <span style="color:grey">(bfeac46)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104666/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>

  </td>
 </tr>
</tbody></table>

  </div>
 </div>

<br>_______________________________________________<br>
calligra-devel mailing list<br>
<a href="mailto:calligra-devel@kde.org">calligra-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/calligra-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/calligra-devel</a><br> \
<br></div><br></body></html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 