[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: warning C4129: '%' : unrecognized character escape sequence
From: Matus Uzak <matus.uzak () ixonos ! com>
Date: 2012-03-19 10:21:48
Message-ID: CAPdReTKUmE_+sbs7XgNeueMHhE8wO50WbWAtu8EPfEFFbiTGNA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi,
I did not catch the irc conversation. The backslash in "\%" seems to be
ignored internally. I don't think it's an undocumented escape sequence
understood by QString, so I would remove it.
Any objections from sebsauer and LukasT who were using those?
-matus
On Sun, Mar 18, 2012 at 4:52 AM, Andrius da Costa Ribas <
andriusmao@gmail.com> wrote:
> Please find attached the patch for 2.4 branch (Either reviewboard does not
> accept patches for non-master or I don't know how to).
>
> 2012/3/17 Andrius da Costa Ribas <andriusmao@gmail.com>
>
>> Hello,
>>
>> As discussed on IRC, some sources contains "\%" invalid escape sequence:
>>
>> filters/libmso/ODrawToOdf.cpp(625): style.addAttribute("svg:x1",
>> QString("%1\%").arg(x1));
>> filters/libmso/ODrawToOdf.cpp(626): style.addAttribute("svg:y1",
>> QString("%1\%").arg(y1));
>> filters/libmso/ODrawToOdf.cpp(627): style.addAttribute("svg:x2",
>> QString("%1\%").arg(x2));
>> filters/libmso/ODrawToOdf.cpp(628): style.addAttribute("svg:y2",
>> QString("%1\%").arg(y2));
>> filters/libmso/ODrawToOdf.cpp(680): style.addAttribute("svg:x1",
>> QString("%1\%").arg(x1));
>> filters/libmso/ODrawToOdf.cpp(681): style.addAttribute("svg:y1",
>> QString("%1\%").arg(y1));
>> filters/libmso/ODrawToOdf.cpp(682): style.addAttribute("svg:x2",
>> QString("%1\%").arg(x2));
>> filters/libmso/ODrawToOdf.cpp(683): style.addAttribute("svg:y2",
>> QString("%1\%").arg(y2));
>> filters/sheets/xlsx/ChartExport.cpp(240):
>> style.addProperty( "draw:opacity", QString( "%1\%" ).arg(
>> chart()->m_areaFormat->m_foreground.alphaF() * 100.0 ),
>> KoGenStyle::GraphicType );
>> filters/sheets/xlsx/ChartExport.cpp(302):
>> style.addProperty( "draw:opacity", QString( "%1\%" ).arg(
>> areaFormat->m_foreground.alphaF() * 100.0 ), KoGenStyle::GraphicType );
>>
>> Is it okay to just replace "\%" by "%" ?
>>
>> Thanks,
>> Andrius.
>>
>
>
> _______________________________________________
> calligra-devel mailing list
> calligra-devel@kde.org
> https://mail.kde.org/mailman/listinfo/calligra-devel
>
>
[Attachment #5 (text/html)]
Hi,<br><br> I did not catch the irc conversation. The backslash in "\%" \
seems to be ignored internally. I don't think it's an undocumented escape \
sequence understood by QString, so I would remove it.<br> Any objections from \
sebsauer and LukasT who were using those?<br><br>-matus<br><br><div \
class="gmail_quote">On Sun, Mar 18, 2012 at 4:52 AM, Andrius da Costa Ribas <span \
dir="ltr"><<a href="mailto:andriusmao@gmail.com">andriusmao@gmail.com</a>></span> \
wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">Please find attached the patch for 2.4 branch (Either \
reviewboard does not accept patches for non-master or I don't know how to).<br> \
<br><div class="gmail_quote">2012/3/17 Andrius da Costa Ribas <span dir="ltr"><<a \
href="mailto:andriusmao@gmail.com" \
target="_blank">andriusmao@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hello,<div><br></div><div>As discussed on IRC, some sources \
contains "\%" invalid escape sequence:</div><div>
<br></div><div><div>filters/libmso/ODrawToOdf.cpp(625): \
style.addAttribute("svg:x1", QString("%1\%").arg(x1));</div> \
<div>filters/libmso/ODrawToOdf.cpp(626): \
style.addAttribute("svg:y1", \
QString("%1\%").arg(y1));</div><div>filters/libmso/ODrawToOdf.cpp(627): \
style.addAttribute("svg:x2", QString("%1\%").arg(x2));</div>
<div>filters/libmso/ODrawToOdf.cpp(628): \
style.addAttribute("svg:y2", \
QString("%1\%").arg(y2));</div><div>filters/libmso/ODrawToOdf.cpp(680): \
style.addAttribute("svg:x1", QString("%1\%").arg(x1));</div>
<div>filters/libmso/ODrawToOdf.cpp(681): \
style.addAttribute("svg:y1", \
QString("%1\%").arg(y1));</div><div>filters/libmso/ODrawToOdf.cpp(682): \
style.addAttribute("svg:x2", QString("%1\%").arg(x2));</div>
<div>filters/libmso/ODrawToOdf.cpp(683): \
style.addAttribute("svg:y2", \
QString("%1\%").arg(y2));</div><div>filters/sheets/xlsx/ChartExport.cpp(240): \
style.addProperty( "draw:opacity", QString( "%1\%" ).arg( \
chart()->m_areaFormat->m_foreground.alphaF() * 100.0 ), KoGenStyle::GraphicType \
);</div>
<div>filters/sheets/xlsx/ChartExport.cpp(302): style.addProperty( \
"draw:opacity", QString( "%1\%" ).arg( \
areaFormat->m_foreground.alphaF() * 100.0 ), KoGenStyle::GraphicType );</div>
</div><div><br></div><div>Is it okay to just replace "\%" by "%" \
?</div><div><br></div><div>Thanks,</div><div>Andrius.</div> </blockquote></div><br>
<br>_______________________________________________<br>
calligra-devel mailing list<br>
<a href="mailto:calligra-devel@kde.org">calligra-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/calligra-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/calligra-devel</a><br> \
<br></blockquote></div>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic